Skip to content

Commit 69e5d9d

Browse files
rodrigoprimojrfnl
authored andcommitted
Generic/DocComment: move parse error test to its own file
Moving a test that needs to be on the last line to its own file. I modified the comment message as, far as I could check, the sniff code to bail early if the doc comment is not properly closed works (as it should) even if there are new lines after it.
1 parent d55b222 commit 69e5d9d

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

src/Standards/Generic/Tests/Commenting/DocCommentUnitTest.1.inc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,5 +258,3 @@
258258
*
259259
* @return void
260260
*/
261-
262-
/** No docblock close tag. Must be last test without new line.

src/Standards/Generic/Tests/Commenting/DocCommentUnitTest.1.inc.fixed

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,5 +263,3 @@
263263
*
264264
* @return void
265265
*/
266-
267-
/** No docblock close tag. Must be last test without new line.

src/Standards/Generic/Tests/Commenting/DocCommentUnitTest.1.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,5 +258,3 @@
258258
*
259259
* @return void
260260
*/
261-
262-
/** No docblock close tag. Must be last test without new line.

src/Standards/Generic/Tests/Commenting/DocCommentUnitTest.1.js.fixed

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,5 +263,3 @@
263263
*
264264
* @return void
265265
*/
266-
267-
/** No docblock close tag. Must be last test without new line.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<?php
2+
3+
// Intentional parse error. Testing that the sniff is *not* triggered
4+
// in this case
5+
6+
/** No docblock close tag. Must be last test without new line.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
// Intentional parse error. Testing that the sniff is *not* triggered
2+
// in this case
3+
4+
/** No docblock close tag. Must be last test without new line.

0 commit comments

Comments
 (0)