Use findEndOfStatement + confirm comparisions inside array values are also banned

Author: gsherwood

src/Standards/Squiz/Sniffs/PHP/DisallowComparisonAssignmentSniff.php

@@ -82,13 +82,7 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        $endStatement = $phpcsFile->findNext(T_SEMICOLON, ($stackPtr + 1));
-        if ($tokens[$stackPtr]['conditions'] !== $tokens[$endStatement]['conditions']) {
-            // This statement doesn't end with a semicolon, which is the case for
-            // the last expression in a for loop.
-            return;
-        }
-
+        $endStatement = $phpcsFile->findEndOfStatement($stackPtr);
         for ($i = ($stackPtr + 1); $i < $endStatement; $i++) {
             if ((isset(Tokens::$comparisonTokens[$tokens[$i]['code']]) === true
                 && $tokens[$i]['code'] !== T_COALESCE)

src/Standards/Squiz/Tests/PHP/DisallowComparisonAssignmentUnitTest.inc

@@ -54,3 +54,11 @@ $a = $b === true ? $c : $d;
 
 $this->_args = $this->_getArgs(($_SERVER['argv'] ?? []));
 $args = ($_SERVER['argv'] ?? []);
+
+$a = [
+    'a' => ($foo) ? $foo : $bar,
+];
+
+$a = [
+    'a' => ($foo) ? fn() => return 1 : fn() => return 2,
+];

src/Standards/Squiz/Tests/PHP/DisallowComparisonAssignmentUnitTest.php

@@ -34,6 +34,8 @@ public function getErrorList()
             10 => 1,
             52 => 1,
             53 => 1,
+            58 => 1,
+            62 => 1,
         ];
 
     }//end getErrorList()