Merge pull request #659 from rodrigoprimo/test-coverage-trait-name-suffix

Generic/TraitNameSuffix: improve code coverage

Author: jrfnl

src/Standards/Generic/Sniffs/NamingConventions/TraitNameSuffixSniff.php

@@ -40,6 +40,7 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $traitName = $phpcsFile->getDeclarationName($stackPtr);
         if ($traitName === null) {
+            // Live coding or parse error. Bow out.
             return;
         }
 

src/Standards/Generic/Tests/NamingConventions/TraitNameSuffixUnitTest.1.inc

@@ -0,0 +1,11 @@
+<?php
+
+trait MissingTraitSuffix {} // Error.
+
+trait GoodTrait {}
+
+trait SuffixCaseIsNotEnforced_tRaIt {}
+
+trait
+    /*comment*/
+    AnotherInvalidTraitName {} // Error.

src/Standards/Generic/Tests/NamingConventions/TraitNameSuffixUnitTest.2.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (no trait name).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+trait

src/Standards/Generic/Tests/NamingConventions/TraitNameSuffixUnitTest.inc

@@ -25,14 +25,22 @@ final class TraitNameSuffixUnitTest extends AbstractSniffUnitTest
      * The key of the array should represent the line number and the value
      * should represent the number of errors that should occur on that line.
      *
+     * @param string $testFile The name of the test file to process.
+     *
      * @return array<int, int>
      */
-    public function getErrorList()
+    public function getErrorList($testFile='')
     {
-        return [
-            3 => 1,
-            9 => 1,
-        ];
+        switch ($testFile) {
+        case 'TraitNameSuffixUnitTest.1.inc':
+            return [
+                3 => 1,
+                9 => 1,
+            ];
+
+        default:
+            return [];
+        }
 
     }//end getErrorList()