Added tests

mnapoli · mnapoli · commit dbb381a95fac · 2013-10-15T18:09:47.000+02:00
diff --git a/tests/UnitTest/PhpDocReader/Fixtures/Class1.php b/tests/UnitTest/PhpDocReader/Fixtures/Class1.php
@@ -0,0 +1,35 @@
+<?php
+
+namespace UnitTest\PhpDocReader\Fixtures;
+
+use UnitTest\PhpDocReader\Fixtures\Class3 as ClassClass3;
+
+class Class1
+{
+    public $propNone;
+
+    /**
+     * @var \UnitTest\PhpDocReader\Fixtures\Class2
+     */
+    public $propFQN;
+
+    /**
+     * @var Class2
+     */
+    public $propLocalName;
+
+    /**
+     * @var ClassClass3
+     */
+    public $propAlias;
+
+    /**
+     * @param                                        $paramNone
+     * @param \UnitTest\PhpDocReader\Fixtures\Class2 $paramFQN
+     * @param Class2                                 $paramLocalName
+     * @param ClassClass3                            $paramAlias
+     */
+    public function foo($paramNone, $paramFQN, $paramLocalName, $paramAlias)
+    {
+    }
+} 
diff --git a/tests/UnitTest/PhpDocReader/Fixtures/Class2.php b/tests/UnitTest/PhpDocReader/Fixtures/Class2.php
@@ -2,7 +2,6 @@
 
 namespace UnitTest\PhpDocReader\Fixtures;
 
-class SomeDependencyFixture
+class Class2
 {
-
 }
diff --git a/tests/UnitTest/PhpDocReader/Fixtures/Class3.php b/tests/UnitTest/PhpDocReader/Fixtures/Class3.php
@@ -0,0 +1,7 @@
+<?php
+
+namespace UnitTest\PhpDocReader\Fixtures;
+
+class Class3
+{
+}
diff --git a/tests/UnitTest/PhpDocReader/Fixtures/Subspace/SomeDependencyFixture.php b/tests/UnitTest/PhpDocReader/Fixtures/Subspace/SomeDependencyFixture.php
diff --git a/tests/UnitTest/PhpDocReader/Fixtures/Subspace/SomeDependencyFixture2.php b/tests/UnitTest/PhpDocReader/Fixtures/Subspace/SomeDependencyFixture2.php
diff --git a/tests/UnitTest/PhpDocReader/FixturesIssue87/SomeDependencyFixture.php b/tests/UnitTest/PhpDocReader/FixturesIssue87/SomeDependencyFixture.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace UnitTest\PhpDocReader\FixturesIssue87;
+
+class SomeDependencyFixture
+{
+
+}
diff --git a/tests/UnitTest/PhpDocReader/FixturesIssue87/Subspace/SomeDependencyFixture.php b/tests/UnitTest/PhpDocReader/FixturesIssue87/Subspace/SomeDependencyFixture.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace UnitTest\PhpDocReader\FixturesIssue87\Subspace;
+
+class SomeDependencyFixture
+{
+
+}
diff --git a/tests/UnitTest/PhpDocReader/FixturesIssue87/Subspace/SomeDependencyFixture2.php b/tests/UnitTest/PhpDocReader/FixturesIssue87/Subspace/SomeDependencyFixture2.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace UnitTest\PhpDocReader\FixturesIssue87\Subspace;
+
+class SomeDependencyFixture2
+{
+
+}
diff --git a/tests/UnitTest/PhpDocReader/FixturesIssue87/TargetFixture1.php b/tests/UnitTest/PhpDocReader/FixturesIssue87/TargetFixture1.php
@@ -1,8 +1,8 @@
 <?php
 
-namespace UnitTest\PhpDocReader\Fixtures;
+namespace UnitTest\PhpDocReader\FixturesIssue87;
 
-use UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture;
+use UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture;
 
 /**
  * Has a dependency locally aliased from another namespace
diff --git a/tests/UnitTest/PhpDocReader/FixturesIssue87/TargetFixture2.php b/tests/UnitTest/PhpDocReader/FixturesIssue87/TargetFixture2.php
@@ -1,8 +1,8 @@
 <?php
 
-namespace UnitTest\PhpDocReader\Fixtures;
+namespace UnitTest\PhpDocReader\FixturesIssue87;
 
-use UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2 as SomeDependencyFixture;
+use UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2 as SomeDependencyFixture;
 
 /**
  * Has a dependency locally aliased to a name in the local namespace of the targets
diff --git a/tests/UnitTest/PhpDocReader/FixturesIssue87/TargetFixture3.php b/tests/UnitTest/PhpDocReader/FixturesIssue87/TargetFixture3.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace UnitTest\PhpDocReader\Fixtures;
+namespace UnitTest\PhpDocReader\FixturesIssue87;
 
 /**
  * Has a dependency in the local namespace
diff --git a/tests/UnitTest/PhpDocReader/FunctionalTest.php b/tests/UnitTest/PhpDocReader/FunctionalTest.php
@@ -0,0 +1,51 @@
+<?php
+
+namespace UnitTest\PhpDocReader;
+
+use PhpDocReader\PhpDocReader;
+use ReflectionParameter;
+use ReflectionProperty;
+
+/**
+ * Functional tests
+ */
+class FunctionalTest extends \PHPUnit_Framework_TestCase
+{
+    public function testReadPropertyType()
+    {
+        $parser = new PhpDocReader();
+
+        $className = 'UnitTest\PhpDocReader\Fixtures\Class1';
+
+        $type = $parser->getPropertyType(new ReflectionProperty($className, 'propNone'));
+        $this->assertNull($type);
+
+        $type = $parser->getPropertyType(new ReflectionProperty($className, 'propFQN'));
+        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Class2', $type);
+
+        $type = $parser->getPropertyType(new ReflectionProperty($className, 'propLocalName'));
+        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Class2', $type);
+
+        $type = $parser->getPropertyType(new ReflectionProperty($className, 'propAlias'));
+        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Class3', $type);
+    }
+
+    public function testReadParamType()
+    {
+        $parser = new PhpDocReader();
+
+        $method = array('UnitTest\PhpDocReader\Fixtures\Class1', 'foo');
+
+        $type = $parser->getParameterType(new ReflectionParameter($method, 'paramNone'));
+        $this->assertNull($type);
+
+        $type = $parser->getParameterType(new ReflectionParameter($method, 'paramFQN'));
+        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Class2', $type);
+
+        $type = $parser->getParameterType(new ReflectionParameter($method, 'paramLocalName'));
+        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Class2', $type);
+
+        $type = $parser->getParameterType(new ReflectionParameter($method, 'paramAlias'));
+        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Class3', $type);
+    }
+}
diff --git a/tests/UnitTest/PhpDocReader/Issue87Test.php b/tests/UnitTest/PhpDocReader/Issue87Test.php
@@ -2,7 +2,6 @@
 
 namespace UnitTest\PhpDocReader;
 
-use Doctrine\Common\Annotations\Annotation\Target;
 use PhpDocReader\PhpDocReader;
 
 /**
@@ -18,7 +17,7 @@ public function testGetParameterTypeUseStatementBeforeLocalNamespace()
     {
         $parser = new PhpDocReader();
 
-        $target1 = new Fixtures\TargetFixture1();
+        $target1 = new FixturesIssue87\TargetFixture1();
 
         $target1ReflectionClass = new \ReflectionClass($target1);
         $target1ReflectionMethod = $target1ReflectionClass->getMethod("SomeMethod");
@@ -27,17 +26,17 @@ public function testGetParameterTypeUseStatementBeforeLocalNamespace()
         $result = $parser->getParameterType($target1ReflectionParams[0]);
 
         //Since TargetFixture1 file has a use statement to the Subspace namespace, that's the one that should be returned
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture', $result);
 
 
         $result = $parser->getParameterType($target1ReflectionParams[1]);
 
         //this parameter should be unaffected by use namespace since it has a relative type path
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2', $result);
 
 
 
-        $target2 = new Fixtures\TargetFixture2();
+        $target2 = new FixturesIssue87\TargetFixture2();
 
         $target2ReflectionClass = new \ReflectionClass($target2);
         $target2ReflectionMethod = $target2ReflectionClass->getMethod("SomeMethod");
@@ -46,17 +45,17 @@ public function testGetParameterTypeUseStatementBeforeLocalNamespace()
         $result = $parser->getParameterType($target2ReflectionParams[0]);
 
         //Since TargetFixture2 file has a use statement with an alias to the Subspace namespace, that's the one that should be returned
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2', $result);
 
 
         $result = $parser->getParameterType($target2ReflectionParams[1]);
 
         //this parameter should be unaffected by use namespace since it has a relative type path
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2', $result);
 
 
 
-        $target3 = new Fixtures\TargetFixture3();
+        $target3 = new FixturesIssue87\TargetFixture3();
 
         $target3ReflectionClass = new \ReflectionClass($target3);
         $target3ReflectionMethod = $target3ReflectionClass->getMethod("SomeMethod");
@@ -65,13 +64,13 @@ public function testGetParameterTypeUseStatementBeforeLocalNamespace()
         $result = $parser->getParameterType($target3ReflectionParams[0]);
 
         //Since TargetFixture3 file has NO use statement, the one local to the target's namespace should be used
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\SomeDependencyFixture', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\SomeDependencyFixture', $result);
 
 
         $result = $parser->getParameterType($target3ReflectionParams[1]);
 
         //this parameter should be unaffected by use namespace since it has a relative type path
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2', $result);
     }
 
 
@@ -83,62 +82,62 @@ public function testGetPropertyTypeUseStatementBeforeLocalNamespace()
     {
         $parser = new PhpDocReader();
 
-        $target1 = new Fixtures\TargetFixture1();
+        $target1 = new FixturesIssue87\TargetFixture1();
 
         $target1ReflectionClass = new \ReflectionClass($target1);
         $target1ReflectionProperty1 = $target1ReflectionClass->getProperty("dependency1");
 
         $result = $parser->getPropertyType($target1ReflectionProperty1);
 
         //Since TargetFixture1 file has a use statement to the Subspace namespace, that's the one that should be returned
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture', $result);
 
 
         $target1ReflectionProperty2 = $target1ReflectionClass->getProperty("dependency2");
 
         $result = $parser->getPropertyType($target1ReflectionProperty2);
 
         //this property should be unaffected by use namespace since it has a relative type path
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2', $result);
 
 
 
-        $target2 = new Fixtures\TargetFixture2();
+        $target2 = new FixturesIssue87\TargetFixture2();
 
         $target2ReflectionClass = new \ReflectionClass($target2);
         $target2ReflectionProperty1 = $target2ReflectionClass->getProperty("dependency1");
 
         $result = $parser->getPropertyType($target2ReflectionProperty1);
 
         //Since TargetFixture2 file has a use statement with an alias to the Subspace namespace, that's the one that should be returned
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2', $result);
 
 
         $target2ReflectionProperty2 = $target2ReflectionClass->getProperty("dependency2");
 
         $result = $parser->getPropertyType($target2ReflectionProperty2);
 
         //this property should be unaffected by use namespace since it has a relative type path
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2', $result);
 
 
 
-        $target3 = new Fixtures\TargetFixture3();
+        $target3 = new FixturesIssue87\TargetFixture3();
 
         $target3ReflectionClass = new \ReflectionClass($target3);
         $target3ReflectionProperty1 = $target3ReflectionClass->getProperty("dependency1");
 
         $result = $parser->getPropertyType($target3ReflectionProperty1);
 
         //Since TargetFixture3 file has NO use statement, the one local to the target's namespace should be used
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\SomeDependencyFixture', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\SomeDependencyFixture', $result);
 
 
         $target3ReflectionProperty2 = $target3ReflectionClass->getProperty("dependency2");
 
         $result = $parser->getPropertyType($target3ReflectionProperty2);
 
         //this property should be unaffected by use namespace since it has a relative type path
-        $this->assertEquals('UnitTest\PhpDocReader\Fixtures\Subspace\SomeDependencyFixture2', $result);
+        $this->assertEquals('UnitTest\PhpDocReader\FixturesIssue87\Subspace\SomeDependencyFixture2', $result);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`
`3`	`3`	`namespace UnitTest\PhpDocReader\Fixtures;`
`4`	`4`
`5`		`-class SomeDependencyFixture`
	`5`	`+class Class2`
`6`	`6`	`{`
`7`		`-`
`8`	`7`	`}`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,7 @@ @@
 +<?php
++
 +namespace UnitTest\PhpDocReader\Fixtures;
++
 +class Class3
 +{
 +}