From e07f98066d1f4408fedbdbebfb4b90998e794be0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gabriel=20L=C3=B3pez?= Date: Wed, 18 Jun 2025 13:24:29 -0600 Subject: [PATCH 1/4] Adding default behavior for select when calculating space for displaying menu options --- src/Select/index.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Select/index.js b/src/Select/index.js index 66e65f518..bc79124a8 100644 --- a/src/Select/index.js +++ b/src/Select/index.js @@ -46,7 +46,12 @@ const Select = ({ styles: customStyles, components, ref, ...rest }) => { return ({ ...base, zIndex: 10 }) + }} {...rest} />; }; From 631ca106d629d9b16912055e5b7a1e3cdb6adae6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gabriel=20L=C3=B3pez?= Date: Wed, 18 Jun 2025 14:11:36 -0600 Subject: [PATCH 2/4] Adding same behavior to Dropdown component of v2 event types --- .../DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js | 5 +++++ src/Select/index.js | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js b/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js index ece4ecc97..5e2eb0c02 100644 --- a/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js +++ b/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js @@ -64,6 +64,8 @@ const Dropdown = ({ details, disabled, id, invalid, onChange, value, ...otherPro isClearable isDisabled={disabled} isMulti={details.multiple} + menuPortalTarget={document.body} + menuPlacement='auto' noOptionsMessage={() => t('select.noOptionsMessage')} onChange={onSelectChange} onKeyDown={(event) => event.key === 'Escape' && isMenuOpen && event.stopPropagation()} @@ -71,6 +73,9 @@ const Dropdown = ({ details, disabled, id, invalid, onChange, value, ...otherPro onMenuOpen={() => setMenuOpen(true)} options={options} placeholder={details.hint} + styles={{ + menuPortal: base => ({ ...base, zIndex: 10 }) + }} value={selectedValue} {...otherProps} />; diff --git a/src/Select/index.js b/src/Select/index.js index bc79124a8..7e157349b 100644 --- a/src/Select/index.js +++ b/src/Select/index.js @@ -45,9 +45,9 @@ const Select = ({ styles: customStyles, components, ref, ...rest }) => { return ({ ...base, zIndex: 10 }) From 13bbbce47db0badf6a5680603afa86bbcac39476 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gabriel=20L=C3=B3pez?= Date: Thu, 19 Jun 2025 12:54:24 -0600 Subject: [PATCH 3/4] Removing z-index from portal styles of dropdown --- .../DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js | 3 --- src/Select/index.js | 5 +---- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js b/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js index 5e2eb0c02..1d2e8321c 100644 --- a/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js +++ b/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js @@ -73,9 +73,6 @@ const Dropdown = ({ details, disabled, id, invalid, onChange, value, ...otherPro onMenuOpen={() => setMenuOpen(true)} options={options} placeholder={details.hint} - styles={{ - menuPortal: base => ({ ...base, zIndex: 10 }) - }} value={selectedValue} {...otherProps} />; diff --git a/src/Select/index.js b/src/Select/index.js index 7e157349b..c35866828 100644 --- a/src/Select/index.js +++ b/src/Select/index.js @@ -48,10 +48,7 @@ const Select = ({ styles: customStyles, components, ref, ...rest }) => { menuPortalTarget={document.body} menuPlacement='auto' ref={ref} - styles={{ - ...selectStyles, - menuPortal: base => ({ ...base, zIndex: 10 }) - }} + styles={selectStyles} {...rest} />; }; From a90d7d29520d1cb1f69d2740fdf67e4c8e5df3c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gabriel=20L=C3=B3pez?= Date: Fri, 20 Jun 2025 10:14:57 -0600 Subject: [PATCH 4/4] Reverting EFB select implementation --- .../DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js b/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js index 1d2e8321c..ece4ecc97 100644 --- a/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js +++ b/src/ReportManager/DetailsSection/SchemaForm/fields/ChoiceList/Dropdown.js @@ -64,8 +64,6 @@ const Dropdown = ({ details, disabled, id, invalid, onChange, value, ...otherPro isClearable isDisabled={disabled} isMulti={details.multiple} - menuPortalTarget={document.body} - menuPlacement='auto' noOptionsMessage={() => t('select.noOptionsMessage')} onChange={onSelectChange} onKeyDown={(event) => event.key === 'Escape' && isMenuOpen && event.stopPropagation()}