-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Description
Addressing a Problem?
In multiple functions, we use a periods
argument to subset the Dataset. However we simply do ds_subset = ds.sel(time=slice(period[0], period[1]))
, which never checks that the entire period is contained within ds
.
Potential Solution
A wrapper function in xs.utils
that checks that the entire period is contained within ds
, and raises an error if it doesn't.
Additional context
Linked to an issue in #360.
Contribution
- I would be willing/able to open a Pull Request to contribute this feature.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request