Skip to content

Commit 4ed4f01

Browse files
authored
Merge pull request #303 from OuhscBbmc/dev
Dev
2 parents 9f9139e + 6cc7ab7 commit 4ed4f01

File tree

72 files changed

+2044
-2586
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+2044
-2586
lines changed

.github/ISSUE_TEMPLATE/unexpected-behavior-issue-template.md

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,25 @@ assignees: ''
77

88
---
99

10-
**Describe the behavior**
11-
Please provide a clear and concise description of the scenario and the behavior. *Be careful not to include tokens, PHI (protected health information), or other information that should not be public!*
10+
Thank you for taking the time to file an issue. Here are some suggestions for writing your issue that should let us respond and help you more quickly.
1211

13-
**Troubleshooter Results**
14-
Please carefully reread the [Troubleshooting Vignette](https://ouhscbbmc.github.io/REDCapR/articles/TroubleshootingApiCalls.html) and thoroughly describe which part(s) doesn't work. Many people have contributed to this document; it is likely that it will help precisely identify the location of the problem, which will help us respond with better advice.
12+
**Troubleshooter**: Please carefully reread the [Troubleshooting Vignette](https://ouhscbbmc.github.io/REDCapR/articles/TroubleshootingApiCalls.html) and thoroughly describe which parts don't work.
1513

16-
If you have advice for improving the [Troubleshooter](https://ouhscbbmc.github.io/REDCapR/articles/TroubleshootingApiCalls.html) or [this issue template](https://github.com/OuhscBbmc/REDCapR/blob/master/.github/ISSUE_TEMPLATE/unexpected-behavior-issue-template.md), we'd love to hear about it.
14+
**Describe the behavior**: Please provide a clear and concise description of the scenario and the behavior. *Be careful not to include tokens, PHI (protected health information), or other information that should not be public!*
1715

18-
**Expected behavior**
19-
A clear and concise description of what you expected to happen.
2016

21-
**Screenshots**
22-
If applicable, add screenshots to help explain your problem.
17+
**Expected behavior**: A clear and concise description of what you expected to happen.
18+
2319

2420
**Desktop (please complete the following information):**
2521
- OS: [e.g. Windows 10]
2622
- REDCap version [e.g. 9.0.1 --look at the bottom of the REDCap web page]
2723
- REDCapR Version [e.g. 0.10.2.9005 --run `packageVersion("REDCapR")`]
2824

2925

30-
**Additional context**
31-
Add any other context about the problem here.
26+
**Additional context**: Add any other information about the specific problem, such as a data dictionary or screenshot.
27+
3228

33-
*Remember, don't include tokens, PHI, or other information that should not be public.*
29+
**Thank you and reminder**:
30+
* Many people have contributed to this package and it's documentation, and it's continually improving. If you have advice for improving the documentation, the [Troubleshooter](https://ouhscbbmc.github.io/REDCapR/articles/TroubleshootingApiCalls.html), or [this issue template](https://github.com/OuhscBbmc/REDCapR/blob/master/.github/ISSUE_TEMPLATE/unexpected-behavior-issue-template.md), we'd love to hear it.
31+
* *Remember, don't include tokens, PHI, or other information that should not be public.*

DESCRIPTION

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Description: Encapsulates functions to streamline calls from R to the REDCap
66
University. The Application Programming Interface (API) offers an avenue
77
to access and modify data programmatically, improving the capacity for
88
literate and reproducible programming.
9-
Version: 0.10.2.9006
9+
Version: 0.11.0
1010
Authors@R: c(person("Will", "Beasley", role = c("aut", "cre"), email =
1111
"wibeasley@hotmail.com", comment = c(ORCID = "0000-0002-5613-5006")),
1212
person("David", "Bard", role = "ctb"),
@@ -18,7 +18,8 @@ Authors@R: c(person("Will", "Beasley", role = c("aut", "cre"), email =
1818
role = "ctb"), person("Hao", "Zhu",
1919
role = "ctb",
2020
comment = c(ORCID = '0000-0002-3386-6076')), person("Felix", "Torres",
21-
role = "ctb", email = "fetorres@ucsd.edu"))
21+
role = "ctb", email = "fetorres@ucsd.edu"), person("Philip", "Chase",
22+
role = "ctb", email = "pbc@ufl.edu"))
2223
URL: https://github.com/OuhscBbmc/REDCapR, http://ouhsc.edu/bbmc/,
2324
http://project-redcap.org
2425
BugReports: https://github.com/OuhscBbmc/REDCapR/issues

NEWS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Upcoming Versions
44
In the future:
55
...
66

7-
Version 0.11 (Released ?)
7+
Version 0.11 (Released 2020-04-20)
88
==========================================================
99

1010
### Breaking Changes (possible, but unlikely)
@@ -25,7 +25,7 @@ Version 0.11 (Released ?)
2525

2626
### Stability Features
2727

28-
* `httr::content()` (which is inside `kernel_api()`) now processes the returned value as "text/csv", by default. This should prevent strange characters from tricking the process as the internal variable `raw_text` is being formed. See the [httr::content()`](https://httr.r-lib.org/reference/content.html) documentation for a list of possible values for the `content_type` parameter. (Thanks to great debugging by @vortexing, #269)
28+
* `httr::content()` (which is inside `kernel_api()`) now processes the returned value as "text/csv", by default. This should prevent strange characters from tricking the process as the internal variable `raw_text` is being formed. See the [httr::content()`](https://httr.r-lib.org/reference/content.html) documentation for a list of possible values for the `content_type` parameter. (Thanks to great debugging by @vortexing #269, @sybandrew #272, & @begavett, #290)
2929

3030
* Similarly, `kernel_api()` now has an `encoding` parameter, which defaults to "UTF-8". (#270)
3131

R/redcap-download-file-oneshot.R

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@
1818
#' Required
1919
#' @param event The name of the event where the file is saved in REDCap.
2020
#' Optional
21+
#' @param repeat_instrument The name of the instrument that is repeating
22+
#' for a given event.
23+
#' Optional
24+
#' @param repeat_instance (only for projects with repeating instruments/events)
25+
#' The repeat instance number of the repeating event (if longitudinal) or the
26+
#' repeating instrument (if classic or longitudinal). Default value is '1'.
27+
#' Optional
2128
#' @param verbose A boolean value indicating if `message`s should be printed
2229
#' to the R console during the operation. Optional.
2330
#' @param config_options A list of options to pass to [httr::POST()] method
@@ -101,6 +108,8 @@ redcap_download_file_oneshot <- function(
101108
record,
102109
field,
103110
event = "",
111+
repeat_instrument = NULL,
112+
repeat_instance = NULL,
104113
verbose = TRUE,
105114
config_options = NULL
106115
) {
@@ -132,6 +141,14 @@ redcap_download_file_oneshot <- function(
132141

133142
if (0L < nchar(event)) post_body$event <- event
134143

144+
if (!is.null(repeat_instrument)) {
145+
if (is.null(repeat_instance)) {
146+
stop("You must specify repeat_instance when specified repeat_instrement");
147+
}
148+
post_body$repeat_instrument <- repeat_instrument
149+
post_body$repeat_instance <- repeat_instance
150+
}
151+
135152
# This is the first of two important lines in the function.
136153
# It retrieves the information from the server and stores it in RAM.
137154
kernel <- kernel_api(redcap_uri, post_body, config_options)

_pkgdown.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ reference:
5050
- redcap_next_free_record_name
5151
- redcap_metadata_read
5252
- redcap_metadata_write
53+
- redcap_survey_link_export_oneshot
5354
- redcap_users_export
5455
- redcap_variables
5556
- redcap_version

cran-comments.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,22 @@
11
Description
22
-----------------------------------------------
3-
This submission includes new features and also addresses some (soon-to-be) breaking changes in the libraries underneath.
4-
5-
I have fixed the three points described in your previous response (documented in [our issue](https://github.com/OuhscBbmc/REDCapR/issues/253)). For the first point, I fixed some markdown syntax so the API's url is correctly interpreted. I'm sorry the test builds below didn't uncover the last two.
3+
This submission includes new features and also addresses a recent breaking change from tibble 3.0.0 (https://github.com/OuhscBbmc/REDCapR/issues/302).
64

75
Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN. -Will Beasley
86

97

108
Test environments
119
-----------------------------------------------
1210

13-
1. Local Ubuntu, R 3.6.1 patched
14-
1. Local Win8, R 3.6.1 patched
11+
1. Local Ubuntu, R 3.6.3 patched
12+
1. Local Win8, R 4.0.0 RC
1513
1. r-hub
16-
1. [Ubuntu Linux 16.04 LTS, R-release, GCC](https://builder.r-hub.io/status/REDCapR_0.10.1.tar.gz-ffc36a958fe44f3fb3263929670f8138)
17-
1. [Fedora Linux, R-devel, clang, gfortran](https://builder.r-hub.io/status/REDCapR_0.10.1.tar.gz-2e2bed0d3cda44429a8f830c2b9d8e92)
18-
1. [Windows Server](https://builder.r-hub.io/status/REDCapR_0.10.1.tar.gz-0c79ee0f9b3e49f7b381348e9f7283b0)
19-
1. [win-builder](https://win-builder.r-project.org/a9ub2IBAb24W), development version.
14+
1. [Ubuntu Linux 16.04 LTS, R-release, GCC](https://builder.r-hub.io/status/REDCapR_0.10.2.9006.tar.gz-71151f2f04454bc18c16430e5d62610b)
15+
1. [Fedora Linux, R-devel, clang, gfortran](https://builder.r-hub.io/status/REDCapR_0.10.2.9006.tar.gz-2f619028b765442f9dc1c34373443d2a)
16+
1. [Windows Server](https://builder.r-hub.io/status/REDCapR_0.10.2.9006.tar.gz-80133501925a411da4c3cf3be8205e29)
17+
1. [win-builder](https://win-builder.r-project.org/xYyWrC1uFjXH), development version.
2018
1. [Travis CI](https://travis-ci.org/OuhscBbmc/REDCapR), Ubuntu 14.04 LTS
21-
1. [AppVeyor](https://ci.appveyor.com/project/wibeasley/REDCapR), Windows Server 2012
19+
1. [AppVeyor](https://ci.appveyor.com/project/wibeasley/REDCapR), Windows Server 2012 R2
2220

2321

2422
R CMD check results

docs/404.html

Lines changed: 26 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)