Skip to content

Reconstruct the solution to include Orchardcore.Commerce.Core (OCC-236) #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
infofromca opened this issue Apr 17, 2024 · 2 comments · May be fixed by #569
Open

Reconstruct the solution to include Orchardcore.Commerce.Core (OCC-236) #429

infofromca opened this issue Apr 17, 2024 · 2 comments · May be fixed by #569
Labels
enhancement New feature or request technical debt Necessary but not urgent code cleanup or reorganization

Comments

@infofromca
Copy link
Contributor

infofromca commented Apr 17, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe

A clear and concise logic and code reuse.

Describe the solution you'd like

Move more common interface (classes) to Orchardcore.Commerce.Abstraction
add a more project called Orchardcore.Commerce.Core for its implementation

Jira issue
@infofromca infofromca added the enhancement New feature or request label Apr 17, 2024
@github-actions github-actions bot changed the title Reconstruct the solution to include Orchardcore.Commerce.Core Reconstruct the solution to include Orchardcore.Commerce.Core (OCC-236) Apr 17, 2024
@sarahelsaig sarahelsaig added the technical debt Necessary but not urgent code cleanup or reorganization label May 6, 2024
@canadacubachina
Copy link

IMO, Add at leat 2 projects, one is OrchardCore.Commerce.Abstraction, another is OrchardCore.Commerce.Core

@canadacubachina canadacubachina mentioned this issue Mar 30, 2025
Closed
@infofromca infofromca linked a pull request Apr 10, 2025 that will close this issue
Open
@sarahelsaig
Copy link
Contributor

When we add Orchardcore.Commerce.Core, all the service implementations in Orchardcore.Commerce whose interfaces are in other Orchardcore.Commerce.* projects should be moved there as well.
Also each of those services have to be reviewed. If there are entangled dependencies between different modules, those have to be rewritten in a provider style. These can be done in follow-up issues, but the issues have to be created before this one is resolved so we don't leave bad surprises for future us.

IMO, Add at leat 2 projects, one is OrchardCore.Commerce.Abstraction, another is OrchardCore.Commerce.Core

We already have that, in src/Libraries/OrchardCore.Commerce.Abstractions.

@infofromca infofromca mentioned this issue Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request technical debt Necessary but not urgent code cleanup or reorganization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reconstruct the solution infofromca/OrchardCore.Commerce
3 participants
@infofromca @sarahelsaig @canadacubachina