Add integration test for request body during redirections.

Author: jcamiel

integration/hurl/tests_ok/follow_redirect/follow_redirect.curl

@@ -1,7 +1,10 @@
 curl --header 'Accept: text/plain' --location 'http://localhost:8000/follow-redirect'
-curl --data '' --header 'Accept: text/plain' --location 'http://localhost:8000/follow-redirect'
+curl --header 'Content-Type: text/plain' --header 'Accept: text/plain' --data 'Hello world!' --location 'http://localhost:8000/follow-redirect-from-post'
 curl --header 'Accept: text/plain' --location 'http://localhost:8000/follow-redirect/relative/foo'
-curl --header 'Authorization: Basic Ym9iQGVtYWlsLmNvbTpzZWNyZXQ=' --location 'http://localhost:8000/follow-redirect-basic-auth'
-curl --location --user 'bob@email.com:secret' 'http://localhost:8000/follow-redirect-basic-auth'
-curl --header 'Authorization: Basic Ym9iQGVtYWlsLmNvbTpzZWNyZXQ=' --location 'http://localhost:8000/follow-redirect-basic-auth'
-curl --data '' --header 'Accept: text/plain' --location 'http://localhost:8000/follow-redirect-308'
+curl --header 'Authorization: Basic Ym9iQGVtYWlsLmNvbTpzZWNyZXQ=' --location 'http://localhost:8000/follow-redirect-basic-auth?change_host=true'
+curl --header 'Authorization: Basic Ym9iQGVtYWlsLmNvbTpzZWNyZXQ=' --location 'http://localhost:8000/follow-redirect-basic-auth?change_host=false'
+curl --location --user 'bob@email.com:secret' 'http://localhost:8000/follow-redirect-basic-auth?change_host=true'
+curl --location --user 'bob@email.com:secret' 'http://localhost:8000/follow-redirect-basic-auth?change_host=false'
+curl --header 'Authorization: Basic Ym9iQGVtYWlsLmNvbTpzZWNyZXQ=' --location 'http://localhost:8000/follow-redirect-basic-auth?change_host=true'
+curl --header 'Authorization: Basic Ym9iQGVtYWlsLmNvbTpzZWNyZXQ=' --location 'http://localhost:8000/follow-redirect-basic-auth?change_host=false'
+curl --header 'Content-Type: text/plain' --header 'Accept: text/plain' --data 'Hello world!' --location 'http://localhost:8000/follow-redirect-308'

integration/hurl/tests_ok/follow_redirect/follow_redirect.hurl

@@ -19,16 +19,17 @@ url == "http://localhost:8000/followed-redirect"
 `Followed redirect!`
 
 
-# On 301, 302, 303, redirected request switch to GET.
-# Otherwise, method are untouched.
-POST http://localhost:8000/follow-redirect
+# On 301, 302, 303, redirected request switch to GET. Otherwise, method are untouched.
+# If method change through redirection, the body request is not transferred through redirections.
+POST http://localhost:8000/follow-redirect-from-post
+Content-Type: text/plain
 Accept: text/plain
+`Hello world!`
 HTTP 200
 [Asserts]
-redirects count == 2
-redirects nth 0 location == "http://localhost:8000/following-redirect"
-redirects nth 1 location == "http://localhost:8000/followed-redirect"
-url == "http://localhost:8000/followed-redirect"
+redirects count == 1
+redirects nth 0 location == "http://localhost:8000/followed-redirect-from-post"
+url == "http://localhost:8000/followed-redirect-from-post"
 `Followed redirect!`
 
 
@@ -118,8 +119,12 @@ header "Location" not exists
 `Followed redirect with Authorization header!`
 
 
+# With a 308 redirection, the method remains POST. In this case, the request body is
+# copy from redirection through redirection.
 POST http://localhost:8000/follow-redirect-308
+Content-Type: text/plain
 Accept: text/plain
+`Hello world!`
 HTTP 200
 [Asserts]
 redirects count == 1

integration/hurl/tests_ok/follow_redirect/follow_redirect.py

@@ -2,12 +2,27 @@
 from flask import Response, redirect, request
 
 
-@app.route("/follow-redirect", methods=["GET", "POST"])
+@app.route("/follow-redirect")
 def follow_redirect():
     assert request.headers["Accept"] == "text/plain"
     return redirect("http://localhost:8000/following-redirect")
 
 
+@app.route("/follow-redirect-from-post", methods=["POST"])
+def follow_redirect_from_post():
+    assert request.headers["Accept"] == "text/plain"
+    assert request.data.decode(encoding="utf-8") == "Hello world!"
+    return redirect("http://localhost:8000/followed-redirect-from-post", code=301)
+
+
+@app.route("/followed-redirect-from-post")
+def followed_redirect_from_post():
+    # A redirection with a method change POST -> GET should not carry the request body.
+    assert request.data == b""
+    assert request.headers["Accept"] == "text/plain"
+    return "Followed redirect!"
+
+
 @app.route("/following-redirect")
 def following_redirect():
     # For this redirection, we construct the response instead of using
@@ -32,6 +47,7 @@ def followed_redirect():
 @app.route("/followed-redirect-post", methods=["POST"])
 def followed_redirect_post():
     assert request.headers["Accept"] == "text/plain"
+    assert request.data.decode(encoding="utf-8") == "Hello world!"
     return "Followed redirect POST!"
 
 

integration/hurl/tests_ok/follow_redirect/follow_redirect_option.hurl

@@ -27,10 +27,11 @@ header "Location" not exists
 
 # On 301, 302, 303, redirected request switch to GET.
 # Otherwise, method are untouched.
-POST http://localhost:8000/follow-redirect
+POST http://localhost:8000/follow-redirect-from-post
 Accept: text/plain
 [Options]
 location: true
+`Hello world!`
 HTTP 200
 [Asserts]
 header "Location" not exists
@@ -41,6 +42,7 @@ POST http://localhost:8000/follow-redirect-308
 Accept: text/plain
 [Options]
 location: true
+`Hello world!`
 HTTP 200
 [Asserts]
 header "Location" not exists