Merge pull request #5 from Orange-OpenSource/fix-warnings

Fix warnings

Author: chazemar

Example/OCast-ObjC/Controllers/OBJCMainVC.m

@@ -128,12 +128,12 @@ - (void)deviceDidDisconnectWithModule:(enum DriverModule)module_ withError:(NSEr
     NSLog(@"-> Driver is disconnected.");
 
     dispatch_async(dispatch_get_main_queue(), ^{
-        _webAppStatus.text = @"disconnected";
-        [_stickIcon setEnabled:NO];
-        [_stickIcon setTintColor: [UIColor blackColor]];
-        _positionLabel.text = @"";
-        _durationLabel.text = @"";
-        _playerState.text = @"idle";
+        self.webAppStatus.text = @"disconnected";
+        [self.stickIcon setEnabled:NO];
+        [self.stickIcon setTintColor: [UIColor blackColor]];
+        self.positionLabel.text = @"";
+        self.durationLabel.text = @"";
+        self.playerState.text = @"idle";
     });
 
     devices = deviceDiscovery.devices;
@@ -212,8 +212,8 @@ - (void)startWebApp {
         NSLog(@"-> WebApp started !");
 
         dispatch_async(dispatch_get_main_queue(), ^{
-            _webAppStatus.text = @"connected";
-            [_stickIcon setTintColor: [UIColor orangeColor]];
+            self.webAppStatus.text = @"connected";
+            [self.stickIcon setTintColor: [UIColor orangeColor]];
         });
     };
 
@@ -230,12 +230,12 @@ - (IBAction)onStopWebApp:(id)sender {
 
 
         dispatch_async(dispatch_get_main_queue(), ^{
-            _webAppStatus.text = @"disconnected";
+            self.webAppStatus.text = @"disconnected";
 
-            [_stickIcon setTintColor: [UIColor blackColor]];
+            [self.stickIcon setTintColor: [UIColor blackColor]];
 
             if ([devices count] == 0) {
-                [_stickIcon setEnabled:NO];
+                [self.stickIcon setEnabled:NO];
             }
 
             if ([deviceDiscovery start] == NO) {
@@ -315,7 +315,7 @@ -(void)onMessageWithData:(NSDictionary *)data {
     NSLog(@"-> Got custom response : %@", data);
 
     dispatch_async(dispatch_get_main_queue(), ^{
-        _customResponseLabel.text = data.description;
+        self.customResponseLabel.text = data.description;
     });
 }
 
@@ -333,23 +333,23 @@ - (void)didReceiveEventWithPlaybackStatus:(PlaybackStatus * _Nonnull)playbackSta
     NSLog(@"-> Got onPlaybackStatus: Mute = %@", playbackStatus.mute ? @"yes":@"no");
 
     dispatch_async(dispatch_get_main_queue(), ^{
-        _positionLabel.text = [NSString stringWithFormat:@"%f", playbackStatus.position];
-        _durationLabel.text = [NSString stringWithFormat:@"%f", playbackStatus.duration];
+        self.positionLabel.text = [NSString stringWithFormat:@"%f", playbackStatus.position];
+        self.durationLabel.text = [NSString stringWithFormat:@"%f", playbackStatus.duration];
         switch (playbackStatus.state) {
             case PlayerStateIdle:
-                _playerState.text = @"idle";
+                self.playerState.text = @"idle";
                 break;
             case PlayerStatePaused:
-                _playerState.text = @"paused";
+                self.playerState.text = @"paused";
                 break;
             case PlayerStatePlaying:
-                _playerState.text = @"playing";
+                self.playerState.text = @"playing";
                 break;
             case PlayerStateBuffering:
-                _playerState.text = @"buffering";
+                self.playerState.text = @"buffering";
                 break;
             case PlayerStateUnknown:
-                _playerState.text = @"unknown";
+                self.playerState.text = @"unknown";
                 break;
             default:
                 break;

Example/OCast-Swift/Base.lproj/Main.storyboard

@@ -545,7 +545,7 @@
                         </constraints>
                     </view>
                     <navigationItem key="navigationItem" id="gqE-8O-E8g">
-                        <barButtonItem key="rightBarButtonItem" image="playtoNotConnected" style="plain" id="uqd-4S-7xj">
+                        <barButtonItem key="rightBarButtonItem" image="playtoNotConnected" id="uqd-4S-7xj">
                             <color key="tintColor" red="0.0" green="0.0" blue="0.0" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
                         </barButtonItem>
                     </navigationItem>

OCast/Classes/Core/Device/DeviceDiscovery.swift

@@ -117,13 +117,11 @@ import CocoaAsyncSocket
     }
 
     /**
-     Initializes a new deviceDiscoevry class.
+     Initializes a new deviceDiscovery class.
      - Parameters:
-         - sender: module that will receive further notifications
          - searchTargets: list of device targets to search for
          - policy:  `Reliability` level for discovery process
      */
-
     @objc public init(forTargets searchTargets: Array<String>, withPolicy policy: DeviceDiscovery.Reliability) {
         mSearchIdx = 0
         self.mSearchTargets = searchTargets
@@ -145,9 +143,8 @@ import CocoaAsyncSocket
     }
 
     /**
-     Initializes a new deviceDiscoevry class. The `Reliability` level is set to `.high` by default (a MSEARCH is sent every 3s. If no anwser after 6s, the device is considered as lost).
+     Initializes a new deviceDiscovery class. The `Reliability` level is set to `.high` by default (a MSEARCH is sent every 3s. If no anwser after 6s, the device is considered as lost).
      - Parameters:
-         - sender: module that will receive further notifications
          - searchTargets: List of device targets to search for
      */
     public convenience init(forTargets searchTargets: Array<String>) {

OCast/Classes/Core/Device/DeviceManager.swift

@@ -49,7 +49,6 @@ import Foundation
      Initializes a new DeviceManager.
 
      - Parameters:
-         - sender: module that will receive further notifications
          - device: the device to be managed
          - certificateInfo: Optional. An array of certificates to establish secured connections to the device.
      */

OCast/Classes/Core/Models/Public.swift

@@ -145,9 +145,9 @@ public struct DataMapper {
     /// Initializer
     ///
     /// - Parameters:
-    ///   - serverRootCACert: The root server certificate (DER format) used for SSL one-way (can be nil if the serverCACert includes the root certificate)
-    ///   - serverCACert: The server certificate (DER format) used for SSL one-way
-    ///   - clientCert: The client certificate (DER format) used for SSL two-way
+    ///   - serverRootCACertificate: The root server certificate (DER format) used for SSL one-way (can be nil if the serverCACert includes the root certificate)
+    ///   - serverCACertificate: The server certificate (DER format) used for SSL one-way
+    ///   - clientCertificate: The client certificate (DER format) used for SSL two-way
     ///   - password: The password used for SSL two way
     public init(serverRootCACertificate: Data?, serverCACertificate: Data?, clientCertificate: Data?, password: String?) {
         self.serverRootCACertificate = serverRootCACertificate