Skip to content

Commit e67e8b4

Browse files
committed
up
1 parent 27f0a9b commit e67e8b4

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

contracts/utils/Memory.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ library Memory {
1515
type Pointer is bytes32;
1616

1717
/// @dev Returns a `Pointer` to the current free `Pointer`.
18-
function getFreePointer() internal pure returns (Pointer ptr) {
18+
function getFreeMemoryPointer() internal pure returns (Pointer ptr) {
1919
assembly ("memory-safe") {
2020
ptr := mload(0x40)
2121
}
@@ -24,7 +24,7 @@ library Memory {
2424
/// @dev Sets the free `Pointer` to a specific value.
2525
///
2626
/// WARNING: Everything after the pointer may be overwritten.
27-
function setFreePointer(Pointer ptr) internal pure {
27+
function setFreeMemoryPointer(Pointer ptr) internal pure {
2828
assembly ("memory-safe") {
2929
mstore(0x40, ptr)
3030
}

docs/modules/ROOT/pages/utilities.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -480,11 +480,11 @@ Note that each iteration allocates new memory for `tempData`, causing the memory
480480
[source,solidity]
481481
----
482482
function processMultipleItems(uint256[] memory items) internal {
483-
Memory.Pointer ptr = Memory.getFreePointer(); // Cache pointer
483+
Memory.Pointer ptr = Memory.getFreeMemoryPointer(); // Cache pointer
484484
for (uint256 i = 0; i < items.length; i++) {
485485
bytes memory tempData = abi.encode(items[i], block.timestamp);
486486
// Process tempData...
487-
Memory.setFreePointer(ptr); // Reset pointer for reuse
487+
Memory.setFreeMemoryPointer(ptr); // Reset pointer for reuse
488488
}
489489
}
490490
----

test/utils/Memory.t.sol

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ contract MemoryTest is Test {
1313
// - moving the free memory pointer to far causes OOG errors
1414
uint256 constant END_PTR = type(uint24).max;
1515

16-
function testGetSetFreePointer(uint256 seed) public pure {
16+
function testGetsetFreeMemoryPointer(uint256 seed) public pure {
1717
bytes32 ptr = bytes32(bound(seed, START_PTR, END_PTR));
18-
ptr.asPointer().setFreePointer();
19-
assertEq(Memory.getFreePointer().asBytes32(), ptr);
18+
ptr.asPointer().setFreeMemoryPointer();
19+
assertEq(Memory.getFreeMemoryPointer().asBytes32(), ptr);
2020
}
2121

2222
function testSymbolicContentPointer(uint256 seed) public pure {
@@ -25,9 +25,9 @@ contract MemoryTest is Test {
2525
}
2626

2727
function testCopy(bytes memory data, uint256 destSeed) public pure {
28-
uint256 minDestPtr = Memory.getFreePointer().asUint256();
28+
uint256 minDestPtr = Memory.getFreeMemoryPointer().asUint256();
2929
Memory.Pointer destPtr = bytes32(bound(destSeed, minDestPtr, minDestPtr + END_PTR)).asPointer();
30-
destPtr.addOffset(data.length + 32).setFreePointer();
30+
destPtr.addOffset(data.length + 32).setFreeMemoryPointer();
3131
destPtr.copy(data.asPointer(), data.length + 32);
3232
bytes memory copiedData = destPtr.asBytes();
3333
assertEq(data.length, copiedData.length);

test/utils/Memory.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,23 +16,23 @@ describe('Memory', function () {
1616
describe('free pointer', function () {
1717
it('sets free memory pointer', async function () {
1818
const ptr = ethers.toBeHex(0xa0, 32);
19-
await expect(this.mock.$setFreePointer(ptr)).to.not.be.reverted;
19+
await expect(this.mock.$setFreeMemoryPointer(ptr)).to.not.be.reverted;
2020
});
2121

2222
it('gets free memory pointer', async function () {
23-
await expect(this.mock.$getFreePointer()).to.eventually.equal(
23+
await expect(this.mock.$getFreeMemoryPointer()).to.eventually.equal(
2424
ethers.toBeHex(0x80, 32), // Default pointer
2525
);
2626
});
2727
});
2828

2929
it('load extracts a word', async function () {
30-
const ptr = await this.mock.$getFreePointer();
30+
const ptr = await this.mock.$getFreeMemoryPointer();
3131
await expect(this.mock.$load(ptr)).to.eventually.equal(ethers.toBeHex(0, 32));
3232
});
3333

3434
it('loadByte extracts a byte', async function () {
35-
const ptr = await this.mock.$getFreePointer();
35+
const ptr = await this.mock.$getFreeMemoryPointer();
3636
await expect(this.mock.$loadByte(ptr, 0)).to.eventually.equal(ethers.toBeHex(0, 1));
3737
});
3838

0 commit comments

Comments
 (0)