Skip to content

Commit ccb39d2

Browse files
authored
Improve general documentation for 5.2 (#5310)
1 parent 7105693 commit ccb39d2

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

contracts/governance/utils/VotesExtended.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ abstract contract VotesExtended is Votes {
1313
using Checkpoints for Checkpoints.Trace160;
1414
using Checkpoints for Checkpoints.Trace208;
1515

16-
mapping(address delegatee => Checkpoints.Trace160) private _delegateCheckpoints;
16+
mapping(address delegator => Checkpoints.Trace160) private _delegateCheckpoints;
1717
mapping(address account => Checkpoints.Trace208) private _balanceOfCheckpoints;
1818

1919
/**

contracts/interfaces/draft-IERC4337.sol

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ pragma solidity ^0.8.20;
2727
* - `callData` (`bytes`)
2828
* - `accountGasLimits` (`bytes32`): concatenation of verificationGas (16 bytes) and callGas (16 bytes)
2929
* - `preVerificationGas` (`uint256`)
30-
* - `gasFees` (`bytes32`): concatenation of maxPriorityFee (16 bytes) and maxFeePerGas (16 bytes)
30+
* - `gasFees` (`bytes32`): concatenation of maxPriorityFeePerGas (16 bytes) and maxFeePerGas (16 bytes)
3131
* - `paymasterAndData` (`bytes`): concatenation of paymaster fields (or empty)
3232
* - `signature` (`bytes`)
3333
*/
@@ -38,8 +38,8 @@ struct PackedUserOperation {
3838
bytes callData;
3939
bytes32 accountGasLimits; // `abi.encodePacked(verificationGasLimit, callGasLimit)` 16 bytes each
4040
uint256 preVerificationGas;
41-
bytes32 gasFees; // `abi.encodePacked(maxPriorityFee, maxFeePerGas)` 16 bytes each
42-
bytes paymasterAndData; // `abi.encodePacked(paymaster, paymasterVerificationGasLimit, paymasterPostOpGasLimit, paymasterData)`
41+
bytes32 gasFees; // `abi.encodePacked(maxPriorityFeePerGas, maxFeePerGas)` 16 bytes each
42+
bytes paymasterAndData; // `abi.encodePacked(paymaster, paymasterVerificationGasLimit, paymasterPostOpGasLimit, paymasterData)` (20 bytes, 16 bytes, 16 bytes, dynamic)
4343
bytes signature;
4444
}
4545

contracts/proxy/Clones.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,8 @@ library Clones {
163163
* access the arguments within the implementation, use {fetchCloneArgs}.
164164
*
165165
* This function uses the create2 opcode and a `salt` to deterministically deploy the clone. Using the same
166-
* `implementation` and `salt` multiple times will revert, since the clones cannot be deployed twice at the same
167-
* address.
166+
* `implementation`, `args` and `salt` multiple time will revert, since the clones cannot be deployed twice
167+
* at the same address.
168168
*/
169169
function cloneDeterministicWithImmutableArgs(
170170
address implementation,

contracts/utils/NoncesKeyed.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ abstract contract NoncesKeyed is Nonces {
3535
* @dev Same as {_useNonce} but checking that `nonce` is the next valid for `owner`.
3636
*
3737
* This version takes the key and the nonce in a single uint256 parameter:
38-
* - use the first 8 bytes for the key
39-
* - use the last 24 bytes for the nonce
38+
* - use the first 24 bytes for the key
39+
* - use the last 8 bytes for the nonce
4040
*/
4141
function _useCheckedNonce(address owner, uint256 keyNonce) internal virtual override {
4242
(uint192 key, ) = _unpack(keyNonce);

0 commit comments

Comments
 (0)