bugs for First Person Body Support (#1396)

[yohjimane]

All issues below effect branch #1396 and must be completed before we can merge.

• 1. mixed build errors, can cause first person body to appear floating. The second error occurs on dev branch in mixed builds too.
• No longer an issue with new camera positioning method 9dd1ae2

---

• 2. being around NPCs causes first person body position to deviate
• fixed with 900c327

---

• 3. possible to clip through object if facing away from them
• No longer an issue new camera positioning method 9dd1ae2

---

• 4. First person body position can "jitter" between original position and corrected position
• fixed with 60ac2ea
• More info in discord msg

jitter_bug.mp4

---

• 5. New jitter bug introduced with 60ac2ea
• fixed with fcbac9f

2023-08-17_17-37-08.mp4

---

• 6. First person body syncs at low frame rate in some conditions. I think it depends on whether or not our body can currently cast a shadow. Possibly some performance optimization we need to disable.

• fixed with c32e866

• Can be easily reproduced with the settings: r__actor_shadow off and g_first_person_body on

• In the video below, I am turning headlamp on, which causes the body to render smoothly. When it is off, the body renders at lower frame rate

2023-08-04.18-55-47.mp4

---

• 7. Actor headlamp is in incorrect position
• It needs to be corrected similarly to CWeapon position correction
• Would be best if we can find a generic solution that works for CWeapon, CTorch, CCustomDetector etc...
• fixed with new camera positioning method 9dd1ae2

---

• 8. IK is incorrectly based on original position
• It should be corrected using camera direction similarly to CWeapon position correction.
• fixed with new camera positioning method 9dd1ae2

[yohjimane]

The last of the bugs have been resolved due to the newer camera implementation 5749b5d

Closing this out. There is one remaining bug, but it could be considered both first person and third person bug, so i will make a new ticket for it :)