fix linter warnings

Author: pstorch

README.md

@@ -1,7 +1,9 @@
 # <img src="assets/LOGO2.svg" alt="OpenTracks logo" height="40"></img>OSM Dashboard for OpenTracks
 
-_OSM Dashboard_ is a companion application for [OpenTracks](https://github.com/OpenTracksApp/OpenTracks).
-It adds the functionality to show tracks on a map using data from [OpenStreetMap](https://www.openstreetmap.org).
+_OSM Dashboard_ is a companion application
+for [OpenTracks](https://github.com/OpenTracksApp/OpenTracks).
+It adds the functionality to show tracks on a map using data
+from [OpenStreetMap](https://www.openstreetmap.org).
 OSM Dashboard updates the provided data from OpenTracks in real-time.
 
 <table>
@@ -48,42 +50,53 @@ OSM Dashboard updates the provided data from OpenTracks in real-time.
     </tr>
 </table>
 
-
 ## Features:
+
 * _Online map data_: download map data on-demand
 * _Offline map data_: use on-device stored map data
-* _In app download of offline maps_: download offline maps from within the app, from [https://ftp-stud.hs-esslingen.de](https://ftp-stud.hs-esslingen.de/pub/Mirrors/download.mapsforge.org/maps/v5/)
+* _In app download of offline maps_: download offline maps from within the app,
+  from [https://ftp-stud.hs-esslingen.de](https://ftp-stud.hs-esslingen.de/pub/Mirrors/download.mapsforge.org/maps/v5/)
 * _Map themes_: support for custom map themes for offline maps
 
 __Required permissions:__
-* _INTERNET_: required for online maps (only required for the full version, the pure offline version doesn't need any permission)
+
+* _INTERNET_: required for online maps (only required for the full version, the pure offline version
+  doesn't need any permission)
 
 ## Maps
 
-The map implementation is based on the [Mapsforge VTM](https://github.com/mapsforge/vtm) library. This also defines the types of offline maps which can be used.
+The map implementation is based on the [Mapsforge VTM](https://github.com/mapsforge/vtm) library.
+This also defines the types of offline maps which can be used.
 
 The default online map is provided by [OpenStreetMap.org](https://openstreetmap.org).
-Join the community and help to improve the map, see [www.openstreetmap.org/fixthemap](https://www.openstreetmap.org/fixthemap).
+Join the community and help to improve the map,
+see [www.openstreetmap.org/fixthemap](https://www.openstreetmap.org/fixthemap).
 
-Please consider downloading an offline map to decrease the server load and save your mobile data plan. Some offline maps can be found here:
+Please consider downloading an offline map to decrease the server load and save your mobile data
+plan. Some offline maps can be found here:
 
 - [Mapsforge](http://download.mapsforge.org/)
 - [Freizeitkarte Android](https://www.freizeitkarte-osm.de/android/en/)
 - [OpenAndroMaps](https://www.openandromaps.org/en)
 
-**Some maps require special themes to render correctly!** These need to be downloaded and configured accordingly.
+**Some maps require special themes to render correctly!** These need to be downloaded and configured
+accordingly.
 
-Offline maps can be downloaded via the menu `Map download` or by visiting the above mentioned websites and clicking the download links. Some browsers (e.g. Firefox) require a long click on the link and "Open link in external app" and then choose OSMDashboard.
+Offline maps can be downloaded via the menu `Map download` or by visiting the above mentioned
+websites and clicking the download links. Some browsers (e.g. Firefox) require a long click on the
+link and "Open link in external app" and then choose OSMDashboard.
 
-Manually downloaded offline maps or maps shared by other apps can be opened from your Android device. Select the directory in the menu `Map directory`.
+Manually downloaded offline maps or maps shared by other apps can be opened from your Android
+device. Select the directory in the menu `Map directory`.
 
 ## Screenshots
+
 <div>
-    <img width="15%" src="fastlane/metadata/android/en-US/images/phoneScreenshots/1-info-view.png">
-    <img width="15%" src="fastlane/metadata/android/en-US/images/phoneScreenshots/2-single-track-map-view.png">
-    <img width="15%" src="fastlane/metadata/android/en-US/images/phoneScreenshots/3-multi-track-map-view.png">
-    <img width="15%" src="fastlane/metadata/android/en-US/images/phoneScreenshots/4-simple-theme-map-view.png">
-    <img width="15%" src="fastlane/metadata/android/en-US/images/phoneScreenshots/5-map-download-view.png">
-    <img width="15%" src="fastlane/metadata/android/en-US/images/phoneScreenshots/6-map-selection-view.png">
-    <img width="15%" src="fastlane/metadata/android/en-US/images/phoneScreenshots/7-map-3d.png">
+    <img style="max-width: 200px;" src="fastlane/metadata/android/en-US/images/phoneScreenshots/1-info-view.png" alt="1-info-view">
+    <img style="max-width: 200px;" src="fastlane/metadata/android/en-US/images/phoneScreenshots/2-single-track-map-view.png" alt="2-single-track-map-view">
+    <img style="max-width: 200px;" src="fastlane/metadata/android/en-US/images/phoneScreenshots/3-multi-track-map-view.png" alt="3-multi-track-map-view">
+    <img style="max-width: 200px;" src="fastlane/metadata/android/en-US/images/phoneScreenshots/4-simple-theme-map-view.png" alt="4-simple-theme-map-view">
+    <img style="max-width: 200px;" src="fastlane/metadata/android/en-US/images/phoneScreenshots/5-map-download-view.png" alt="5-map-download-view.png">
+    <img style="max-width: 200px;" src="fastlane/metadata/android/en-US/images/phoneScreenshots/6-map-selection-view.png" alt="6-map-selection-view">
+    <img style="max-width: 200px;" src="fastlane/metadata/android/en-US/images/phoneScreenshots/7-map-3d.png" alt="7-map-3d">
 </div>

src/main/java/de/storchp/opentracks/osmplugin/dashboardapi/TrackPoint.java

@@ -114,12 +114,12 @@ public static TrackPointsBySegments readTrackPointsBySegments(ContentResolver re
                 if (lastTrackPoint.isPause()) {
                     debug.trackpointsPause++;
                     if (!lastTrackPoint.hasValidLocation()) {
-                       if (segment.size() > 0) {
-                           var previousTrackpoint = segment.get(segment.size() - 1);
-                           if (previousTrackpoint.hasValidLocation()) {
-                               segment.add(new TrackPoint(trackId, trackPointId, previousTrackpoint.getLatLong().getLatitude(), previousTrackpoint.getLatLong().getLongitude(), type, speed));
-                           }
-                       }
+                        if (!segment.isEmpty()) {
+                            var previousTrackpoint = segment.get(segment.size() - 1);
+                            if (previousTrackpoint.hasValidLocation()) {
+                                segment.add(new TrackPoint(trackId, trackPointId, previousTrackpoint.getLatLong().getLatitude(), previousTrackpoint.getLatLong().getLongitude(), type, speed));
+                            }
+                        }
                     }
                     lastTrackPoint = null;
                 }
@@ -145,5 +145,5 @@ public GeoPoint getLatLong() {
     public double getSpeed() {
         return speed;
     }
-    
+
 }

src/main/java/de/storchp/opentracks/osmplugin/dashboardapi/Waypoint.java

@@ -16,6 +16,9 @@
 
 import de.storchp.opentracks.osmplugin.utils.MapUtils;
 
+/**
+ * @noinspection unused
+ */
 public class Waypoint {
 
     public static final String _ID = "_id";

src/main/java/de/storchp/opentracks/osmplugin/maps/StyleColorCreator.java

@@ -16,6 +16,9 @@ public StyleColorCreator(double start) {
         this.h = start;
     }
 
+    /**
+     * @noinspection SameParameterValue
+     */
     private int convertHSVtoColorRGB(double hue, double saturation, double value) {
         double i = Math.floor(hue * 6);
         double f = hue * 6 - i;

src/main/java/de/storchp/opentracks/osmplugin/utils/MapUtils.java

@@ -49,17 +49,7 @@ private static double distance(GeoPoint c0, GeoPoint c1, GeoPoint c2) {
             return c2.sphericalDistance(c0);
         }
 
-        double s0lat = c0.getLatitude() * UnitConversions.DEG_TO_RAD;
-        double s0lng = c0.getLongitude() * UnitConversions.DEG_TO_RAD;
-        double s1lat = c1.getLatitude() * UnitConversions.DEG_TO_RAD;
-        double s1lng = c1.getLongitude() * UnitConversions.DEG_TO_RAD;
-        double s2lat = c2.getLatitude() * UnitConversions.DEG_TO_RAD;
-        double s2lng = c2.getLongitude() * UnitConversions.DEG_TO_RAD;
-
-        double s2s1lat = s2lat - s1lat;
-        double s2s1lng = s2lng - s1lng;
-        double u = ((s0lat - s1lat) * s2s1lat + (s0lng - s1lng) * s2s1lng)
-                / (s2s1lat * s2s1lat + s2s1lng * s2s1lng);
+        double u = calcU(c0, c1, c2);
 
         if (u <= 0) {
             return c0.sphericalDistance(c1);
@@ -75,6 +65,20 @@ private static double distance(GeoPoint c0, GeoPoint c1, GeoPoint c2) {
         return sa.sphericalDistance(sb);
     }
 
+    private static double calcU(GeoPoint c0, GeoPoint c1, GeoPoint c2) {
+        double s0lat = c0.getLatitude() * UnitConversions.DEG_TO_RAD;
+        double s0lng = c0.getLongitude() * UnitConversions.DEG_TO_RAD;
+        double s1lat = c1.getLatitude() * UnitConversions.DEG_TO_RAD;
+        double s1lng = c1.getLongitude() * UnitConversions.DEG_TO_RAD;
+        double s2lat = c2.getLatitude() * UnitConversions.DEG_TO_RAD;
+        double s2lng = c2.getLongitude() * UnitConversions.DEG_TO_RAD;
+
+        double s2s1lat = s2lat - s1lat;
+        double s2s1lng = s2lng - s1lng;
+        return ((s0lat - s1lat) * s2s1lat + (s0lng - s1lng) * s2s1lng)
+                / (s2s1lat * s2s1lat + s2s1lng * s2s1lng);
+    }
+
     /**
      * Decimates the given trackPoints for a given zoom level.
      * This uses a Douglas-Peucker decimation algorithm.
@@ -99,7 +103,7 @@ public static List<TrackPoint> decimate(int tolerance, List<TrackPoint> trackPoi
 
         if (n > 2) {
             stack.push(new int[]{0, (n - 1)});
-            while (stack.size() > 0) {
+            while (!stack.isEmpty()) {
                 current = stack.pop();
                 maxDist = 0;
                 for (idx = current[0] + 1; idx < current[1]; ++idx) {

src/main/java/de/storchp/opentracks/osmplugin/utils/PreferencesUtils.java

@@ -76,14 +76,6 @@ public static boolean isShowPauseMarkers() {
         return getBoolean(R.string.APP_PREF_SHOW_PAUSE_MARKERS, resources.getBoolean(R.bool.show_pause_markers_default));
     }
 
-    public static String getLastDownloadUrl(String defaultDownloadUrl) {
-        return getString(R.string.APP_PREF_LAST_DOWNLOAD_URL, defaultDownloadUrl);
-    }
-
-    public static void setLastDownloadUrl(String lastDownloadUrl) {
-        setString(R.string.APP_PREF_LAST_DOWNLOAD_URL, lastDownloadUrl);
-    }
-
     private static Set<Uri> getUris(String keyId) {
         return sharedPrefs.getStringSet(keyId, Collections.emptySet()).stream()
                 .map(PreferencesUtils::parseUri)

src/main/java/de/storchp/opentracks/osmplugin/utils/TrackStatistics.java

@@ -4,6 +4,9 @@
 
 import de.storchp.opentracks.osmplugin.dashboardapi.Track;
 
+/**
+ * @noinspection unused
+ */
 public class TrackStatistics {
 
     private String category = "unknown";

src/main/res/layout/map.xml

@@ -10,7 +10,7 @@
         android:id="@+id/mapView"
         android:layout_width="fill_parent"
         android:layout_height="fill_parent"
-        android:layout_alignParentStart="true"/>
+        android:layout_alignParentStart="true" />
 
     <TextView
         android:id="@+id/share_picture_title"
@@ -30,7 +30,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignParentTop="true"
-        android:layout_alignParentEnd="true"
+        android:layout_alignEnd="@id/mapView"
         android:layout_marginTop="90dp"
         android:layout_marginEnd="8dp"
         android:textAlignment="textEnd"
@@ -77,7 +77,7 @@
             android:orientation="horizontal"
             app:flow_horizontalGap="4dp"
             app:flow_verticalGap="4dp"
-            app:flow_verticalStyle = "spread"
+            app:flow_verticalStyle="spread"
             app:flow_horizontalStyle="spread"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintEnd_toEndOf="parent"

src/main/res/values-ca/strings.xml

@@ -24,7 +24,6 @@
     <string name="delete_theme_question">Esborra tema \"%s\"\?</string>
     <string name="delete_theme_error">El tema de la supressió fallat</string>
     <string name="overwrite_map_question">El mapa \"%s\" ja existeix! Suprimir i descarregar de nou\?</string>
-    <string name="cancel_download_question">Cancel·la la baixada actual\?</string>
     <string name="error_loading_offline_map">Error de lectura configurat els mapes fora de línia</string>
     <string name="track_smoothing_menu">Pista suavitzat</string>
     <string name="pip_mode">Imatge en mode d\'imatge</string>
@@ -40,14 +39,12 @@
     <string name="offline_map_info">Els mapes fora de línia es pot descarregar a través del menú <b>Mapa de descàrrega</b> o per visitar els esmentats llocs web i feu clic en els enllaços de descàrrega. Alguns navegadors (per exemple, el Firefox) requereixen un llarg feu clic a l\'enllaç i Obrir enllaç extern aplicació i, a continuació seleccioneu OSMDashboard.</string>
     <string name="online_map_consent">No hi ha cap mapa en línia configurat. Si us plau, accepta utilitzar el mapa en línia des de openstreetmap.org. Això podria fuita de la teva ubicació actual. Veure https://operations.osmfoundation.org/policies/tiles/ per a rajola d\'ús i política de privadesa.</string>
     <string name="choose_map_to_download">Triar un mapa per a descarregar</string>
-    <string name="download_instruction">Esteu visualitzant el contingut de https://ftp-stud.hs-esslingen.de.</string>
     <string name="delete_map_error">Mapa de la supressió fallat</string>
     <string name="overwrite_theme_question">El tema \"%s\" ja existeix! Suprimir i descarregar de nou\?</string>
     <string name="track_smoothing_info">Definir la tolerància en metres per la pista suavitzat algorisme. Introduïu 0 a desactivar el seguiment regulador.
 \nCanviar entra en vigor després de tornar a carregar la pista.</string>
     <string name="map_mode_direction">Mapa del moviment de direcció</string>
     <string name="no_map_configured">No teniu els mapes fora de línia encara no s\'ha configurat.</string>
-    <string name="startDownload">Inicia La Baixada</string>
     <string name="error_reg_content_observer">Error en el registre OpenTracksContentObserver</string>
     <string name="toggle_full_screen_mode">Canvia el mode de pantalla completa</string>
     <string name="share">Compartir</string>

src/main/res/values-co/strings.xml

@@ -21,10 +21,8 @@
     <string name="map_mode_north_top">Piazzà u nordu insù</string>
     <string name="track_smoothing_menu">Allisciata di u tracciatu</string>
     <string name="settings_ui_dynamic_colors_summary">Impiegà i culori dinamichi definiti da l’utilizatore (solu Android 12è più ; richiede un rilanciu manuale)</string>
-    <string name="cancel_download_question">Abbandunà u scaricamentu attuale ?</string>
     <string name="version_info"><b>Versione :</b> %s - %s (%d)</string>
     <string name="distance_km">Distanza in km</string>
-    <string name="startDownload">Lancià u scaricamentu</string>
     <string name="unit_mile_per_hour">mph</string>
     <string name="delete_theme_question">Squassà u tema « %s » ?</string>
     <string name="unit_feet">ft</string>
@@ -91,7 +89,6 @@
     <string name="unit_meter">m</string>
     <string name="settings_night_mode_option_day">Ghjornu</string>
     <string name="usage_info">Impiegate <b><a href="https://f-droid.org/packages/de.dennisguse.opentracks">OpenTracks</a></b>, selezziunate un tracciatu è fate un cliccu nant’à l’icona di carta per affissà u tracciatu nant’à a carta.</string>
-    <string name="download_instruction">Eccu a lista di u cuntenutu di u situ https://ftp-stud.hs-esslingen.de.</string>
     <string name="pip_mode">Mode fiura-nant’à-fiura (intarsiatura PIP)</string>
     <string name="unit_minute_per_mile">min/mi</string>
     <string name="map_theme_info"><b>Certe carte richiedenu temi speziali per una restituzione curretta !</b> Quelli temi devenu esse scaricati è cunfigurati in cunsequenza.</string>