Skip to content

Commit e1b5aed

Browse files
authored
Merge pull request #32 from OpenRL-Lab/dev
format
2 parents 4388b06 + c95d699 commit e1b5aed

File tree

8 files changed

+33
-28
lines changed

8 files changed

+33
-28
lines changed

openplugin/install/__init__.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@
1717
""""""
1818

1919
from openplugin.install.local_install import install_local_plugin
20-
from openplugin.install.zip_install import install_zip_plugin
2120
from openplugin.install.remote_install import remote_install
2221
from openplugin.install.uninstall import uninstall_plugin
22+
from openplugin.install.zip_install import install_zip_plugin
23+
24+
2325
def install_plugin(plugin_name: str) -> bool:
2426
if plugin_name == "./" or plugin_name == ".":
2527
print("Installing current directory as plugin...")
@@ -31,8 +33,7 @@ def install_plugin(plugin_name: str) -> bool:
3133

3234
return remote_install(plugin_name)
3335

36+
3437
def reinstall_plugin(plugin_name: str) -> bool:
3538
uninstall_plugin(plugin_name)
3639
return install_plugin(plugin_name)
37-
38-

openplugin/install/list_plugins.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
""""""
1818
from openplugin.utils.util import (
19+
get_plugin_directory,
1920
get_plugin_list,
2021
get_plugin_version,
21-
get_plugin_directory,
2222
)
2323

2424

@@ -27,5 +27,5 @@ def list_plugins() -> bool:
2727
plugin_directory = get_plugin_directory()
2828
print("Installed plugins:")
2929
for plugin in plugin_list:
30-
plugin_version = get_plugin_version(plugin_directory/plugin)
30+
plugin_version = get_plugin_version(plugin_directory / plugin)
3131
print(f"{plugin}:{plugin_version}")

openplugin/install/local_install.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
import tempfile
2222
import zipfile
2323

24-
2524
from openplugin.utils.local_plugin_utils import check_local_plugin
26-
from openplugin.utils.util import get_plugin_directory, make_zip_file,get_plugin_version
25+
from openplugin.utils.util import (
26+
get_plugin_directory,
27+
get_plugin_version,
28+
make_zip_file,
29+
)
2730

2831

2932
def install_local_plugin() -> bool:

openplugin/install/remote_install.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,19 @@
1616

1717
""""""
1818
import io
19-
2019
import zipfile
20+
2121
import requests
2222

2323
from openplugin.utils.util import (
2424
get_plugin_directory,
2525
get_plugin_list,
26-
get_zip_file_url,
2726
get_plugin_version,
27+
get_zip_file_url,
2828
)
2929

30-
def remote_install(plugin_name: str)-> bool:
30+
31+
def remote_install(plugin_name: str) -> bool:
3132
plugin_list = get_plugin_list()
3233
if plugin_name in plugin_list:
3334
print("Plugin {} already installed!".format(plugin_name))
@@ -47,5 +48,5 @@ def remote_install(plugin_name: str)-> bool:
4748
plugin_version = get_plugin_version(plugin_directory / plugin_name)
4849
except:
4950
raise ValueError("plugin {} not found".format(plugin_name))
50-
print("Installed plugin: {}:{}!".format(plugin_name,plugin_version))
51-
return True
51+
print("Installed plugin: {}:{}!".format(plugin_name, plugin_version))
52+
return True

openplugin/install/uninstall.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
get_plugin_version,
2525
)
2626

27+
2728
def uninstall_plugin(plugin_name: str) -> bool:
2829
plugin_list = get_plugin_list()
2930
if plugin_name not in plugin_list:
@@ -34,4 +35,4 @@ def uninstall_plugin(plugin_name: str) -> bool:
3435
plugin_version = get_plugin_version(plugin_path)
3536
if plugin_path.exists() and plugin_path.is_dir():
3637
shutil.rmtree(plugin_path)
37-
print("Uninstalled plugin: {}:{}!".format(plugin_name,plugin_version))
38+
print("Uninstalled plugin: {}:{}!".format(plugin_name, plugin_version))

openplugin/install/zip_install.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,26 +19,23 @@
1919
import shutil
2020
import tempfile
2121
import zipfile
22-
2322
from pathlib import Path
2423

2524
from openplugin.utils.local_plugin_utils import check_local_plugin
26-
2725
from openplugin.utils.util import (
28-
get_plugin_list,
2926
get_plugin_directory,
30-
get_plugin_version,
31-
27+
get_plugin_list,
28+
get_plugin_version,
3229
)
3330

31+
3432
def install_zip_plugin(plugin_zip_file_path: str) -> bool:
3533
assert plugin_zip_file_path.endswith(".zip")
3634

3735
tempdir = tempfile.mkdtemp()
3836
z = zipfile.ZipFile(plugin_zip_file_path)
3937
z.extractall(tempdir)
4038

41-
4239
plugin_name = check_local_plugin(Path(tempdir).iterdir().__next__())
4340
shutil.rmtree(tempdir, ignore_errors=True)
4441
plugin_list = get_plugin_list()
@@ -56,6 +53,5 @@ def install_zip_plugin(plugin_zip_file_path: str) -> bool:
5653
except:
5754
raise ValueError("Install {} failed".format(plugin_name))
5855

59-
60-
print("Installed plugin: {}:{}!".format(plugin_name,plugin_version))
61-
return True
56+
print("Installed plugin: {}:{}!".format(plugin_name, plugin_version))
57+
return True

openplugin/utils/local_plugin_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
from pathlib import Path
2020

2121

22-
def check_local_plugin(plugin_path:str = "./") -> str:
23-
info_file = Path(plugin_path)/"info.json"
22+
def check_local_plugin(plugin_path: str = "./") -> str:
23+
info_file = Path(plugin_path) / "info.json"
2424

2525
assert info_file.exists(), "info.json not found"
2626
info_dict = json.load(open(info_file, "r"))

openplugin/utils/util.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@
1515
# limitations under the License.
1616

1717
""""""
18+
import json
1819
import os
1920
import platform
2021
import re
2122
import shutil
2223
from pathlib import Path
23-
from typing import Dict,Union
24+
from typing import Dict, Union
2425

25-
import json
2626
import numpy as np
2727

2828
import openplugin
@@ -47,15 +47,18 @@ def get_plugin_list():
4747
plugin_list.append(plugin.name)
4848
return plugin_list
4949

50-
def get_plugin_version(plugin_path: Union[Path,str]) -> str:
50+
51+
def get_plugin_version(plugin_path: Union[Path, str]) -> str:
5152
if isinstance(plugin_path, str):
5253
plugin_path = Path(plugin_path)
53-
info_file = plugin_path/"info.json"
54+
info_file = plugin_path / "info.json"
5455
assert info_file.exists(), "Plugin info file not found!"
5556

5657
with open(info_file) as f:
5758
info = json.load(f)
5859
return info["version"]
60+
61+
5962
def make_zip_file(dir_to_put_file_in, plugin_directory, plugin_name):
6063
# create a zip file
6164
zip_file_name = plugin_name

0 commit comments

Comments
 (0)