toybox and openrc

[Climber1987muc]

Hello,
while testing OpenRC together with Toybox, I encountered an issue in sh/functions.sh. The script was failing with a shell syntax error when executed under Toybox’s sh.
I investigated the problem and created a fix in functions.sh that resolves the error. With this change applied, OpenRC now works as expected in my Toybox-based environment.
Please let me know if you would like me to open a pull request with the patch, or if further adjustments are needed to make it acceptable upstream.
Thank you very much for your work on OpenRC!
Best regards,
Fabian

funktions.sh.in.patch

[navi-desu]

seems like toybox's sh is not posix complient:

https://pubs.opengroup.org/onlinepubs/9799919799/ -- 2.9.4.2

for name [ in [word ... ]], "Omitting: in word ... shall be equivalent to: in "$@""

so i feel like this bug should be reported to toybox

[eli-schwartz]

At minimum the commit message for the patch is wrong -- it doesn't:

• "fix" parsing of arguments

Rather, it:

• "works around a toybox bug due to an incomplete implementation of the standard", and the workaround is to not utilize parts of the shell command language that aren't available in this incomplete version of a shell

Like @navi-desu I feel that this should be filed as a toybox issue to implement the remaining missing portions of POSIX sh.

...

I must admit I am curious why toybox is being used at all. I wasn't aware of any practical usage of it outside of Android. Its development direction is not really targeting "compliance to the standard" so much as it is targeting "comply with whatever subset of the standard I need in order to accomplish my real goal, which is a self hosting system runtime I've designed myself". Fixing miscellaneous bugs in third-party usage of toybox may not be on the roadmap at all, and at best be "patches welcome".