Fix missing clobber in x86/x86_64 blas_quickdivide inline assembly function (#2017)

martin-frbg · web-flow · commit b55c586faca2 · 2019-02-14T15:21:36.000+01:00
* Fix missing clobber in blas_quickdivide assembly
diff --git a/common_x86.h b/common_x86.h
@@ -187,7 +187,7 @@ static __inline int blas_quickdivide(unsigned int x, unsigned int y){
 	
   y = blas_quick_divide_table[y];
 
-  __asm__ __volatile__  ("mull %0" :"=d" (result) :"a"(x), "0" (y));
+  __asm__ __volatile__  ("mull %0" :"=d" (result), "+a"(x): "0" (y));
 
   return result;
 #endif
diff --git a/common_x86_64.h b/common_x86_64.h
@@ -210,7 +210,7 @@ static __inline int blas_quickdivide(unsigned int x, unsigned int y){
 	
   y = blas_quick_divide_table[y];
 
-  __asm__ __volatile__  ("mull %0" :"=d" (result) :"a"(x), "0" (y));
+  __asm__ __volatile__  ("mull %0" :"=d" (result), "+a"(x) : "0" (y));
 
   return result;
 }

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ static __inline int blas_quickdivide(unsigned int x, unsigned int y){`
`210`	`210`
`211`	`211`	`y = blas_quick_divide_table[y];`
`212`	`212`
`213`		`- __asm__ __volatile__ ("mull %0" :"=d" (result) :"a"(x), "0" (y));`
	`213`	`+ __asm__ __volatile__ ("mull %0" :"=d" (result), "+a"(x) : "0" (y));`
`214`	`214`
`215`	`215`	`return result;`
`216`	`216`	`}`