Skip to content

Commit 886acfc

Browse files
authored
Merge pull request #4819 from martin-frbg/issue4776
Re-enable the SGESDD benchmark after the SCAL fixes
2 parents 0929865 + 4460d3e commit 886acfc

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

benchmark/pybench/benchmarks/bench_blas.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -234,14 +234,10 @@ def test_gesdd(benchmark, mn, variant):
234234
gesdd = ow.get_func('gesdd', variant)
235235
u, s, vt, info = benchmark(run_gesdd, a, lwork, gesdd)
236236

237-
if variant != 's':
238-
# On entry to SLASCL parameter number 4 had an illegal value
239-
# under codspeed (cannot repro locally or on CI w/o codspeed)
240-
# https://github.com/OpenMathLib/OpenBLAS/issues/4776
241-
assert info == 0
242-
243-
atol = {'s': 1e-5, 'd': 1e-13}
244-
np.testing.assert_allclose(u @ np.diag(s) @ vt, a, atol=atol[variant])
237+
assert info == 0
238+
239+
atol = {'s': 1e-5, 'd': 1e-13}
240+
np.testing.assert_allclose(u @ np.diag(s) @ vt, a, atol=atol[variant])
245241

246242

247243
# linalg.eigh

0 commit comments

Comments
 (0)