Skip to content

Commit 51ba70f

Browse files
committed
test_potrs.c: remove pragma darwin-aarch64 support
Using GCC 14.2.0 on Darwin, the pragma ultimately causes a linker error "ld: invalid r_symbolnum=". The current workaround is to use the old linker, but (a) it's deprecated and (b) it can produce libraries that are subsequently not linkable with the newer linker in dependents: the new ld64 does not link to libraries with duplicate rpaths created by the classic linker.
1 parent de2380e commit 51ba70f

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

Makefile.system

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -436,10 +436,6 @@ CCOMMON_OPT += -Wl,-ld_classic
436436
FCOMMON_OPT += -Wl,-ld_classic
437437
endif
438438
ifeq (x$(XCVER), x 16)
439-
ifeq ($(C_COMPILER), GCC)
440-
CCOMMON_OPT += -Wl,-ld_classic
441-
FCOMMON_OPT += -Wl,-ld_classic
442-
endif
443439
ifeq ($(F_COMPILER), GFORTRAN)
444440
override CEXTRALIB := $(filter-out(-lto_library, $(CEXTRALIB)))
445441
endif

utest/test_potrs.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3232
**********************************************************************************/
3333

3434
#include "openblas_utest.h"
35-
#pragma GCC optimize("no-gcse")
3635
/*
3736
void BLASFUNC(cpotrf)(char*, BLASINT*, complex float*, BLASINT*, BLASINT*);
3837
void BLASFUNC(zpotrs_(char*, BLASINT*, BLASINT*, complex double*,

0 commit comments

Comments
 (0)