PhpStan: fix wrong params for trim (#5072)

Author: sreichel

.phpstan.dist.baseline.neon

@@ -378,12 +378,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Adminhtml/Block/System/Convert/Gui/Edit/Tab/Wizard.php
 
-		-
-			rawMessage: 'Parameter #2 $characters of function rtrim expects string, int given.'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Adminhtml/Block/System/Currency/Rate/Matrix.php
-
 		-
 			rawMessage: 'Method Mage_Core_Model_Email_Template::getProcessedTemplate() invoked with 2 parameters, 0-1 required.'
 			identifier: arguments.count
@@ -4182,12 +4176,6 @@ parameters:
 			count: 2
 			path: app/code/core/Mage/Sales/Model/Entity/Quote.php
 
-		-
-			rawMessage: 'Parameter #1 $string of function trim expects string, float given.'
-			identifier: argument.type
-			count: 2
-			path: app/code/core/Mage/Sales/Model/Order/Creditmemo.php
-
 		-
 			rawMessage: 'Property Mage_Sales_Model_Order_Creditmemo::$_items (iterable<Mage_Sales_Model_Order_Creditmemo_Item>&Mage_Sales_Model_Resource_Order_Creditmemo_Item_Collection) in empty() is not falsy.'
 			identifier: empty.property

app/code/core/Mage/Adminhtml/Block/System/Currency/Rate/Matrix.php

@@ -31,7 +31,7 @@ protected function _prepareLayout()
 
         foreach ($currencies as $currency) {
             foreach ($oldCurrencies as $key => $value) {
-                if (!array_key_exists($currency, $oldCurrencies[$key])) {
+                if (!array_key_exists($currency, $value)) {
                     $oldCurrencies[$key][$currency] = '';
                 }
             }
@@ -66,7 +66,7 @@ protected function _prepareRates($array)
             foreach ($rate as $code => $value) {
                 $parts = explode('.', (string) $value);
                 if (count($parts) === 2) {
-                    $parts[1] = str_pad(rtrim($parts[1], 0), 4, '0', STR_PAD_RIGHT);
+                    $parts[1] = str_pad(rtrim($parts[1], '0'), 4, '0', STR_PAD_RIGHT);
                     $array[$key][$code] = implode('.', $parts);
                 } elseif ($value > 0) {
                     $array[$key][$code] = number_format($value, 4);

app/code/core/Mage/Sales/Model/Order/Creditmemo.php

@@ -554,6 +554,7 @@ public function cancel()
      *
      * Apply to order, order items etc.
      *
+     * @throws Mage_Core_Exception
      * @return $this
      */
     public function register()
@@ -660,7 +661,7 @@ public function setShippingAmount($amount)
      */
     public function setAdjustmentPositive($amount)
     {
-        $amount = trim($amount);
+        $amount = trim((string) $amount);
         if (str_ends_with($amount, '%')) {
             $amount = (float) substr($amount, 0, -1);
             $amount = $this->getOrder()->getGrandTotal() * $amount / 100;
@@ -682,7 +683,7 @@ public function setAdjustmentPositive($amount)
      */
     public function setAdjustmentNegative($amount)
     {
-        $amount = trim($amount);
+        $amount = trim((string) $amount);
         if (str_ends_with($amount, '%')) {
             $amount = (float) substr($amount, 0, -1);
             $amount = $this->getOrder()->getGrandTotal() * $amount / 100;
@@ -705,7 +706,7 @@ public function setAdjustmentNegative($amount)
      * @param string $comment
      * @param bool $notify
      * @param bool $visibleOnFront
-     *
+     * @throws Exception
      * @return $this
      */
     public function addComment($comment, $notify = false, $visibleOnFront = false)
@@ -759,6 +760,8 @@ public function getCommentsCollection($reload = false)
      *
      * @param bool $notifyCustomer
      * @param string $comment
+     * @throws Mage_Core_Model_Store_Exception
+     * @throws Exception
      * @return $this
      */
     public function sendEmail($notifyCustomer = true, $comment = '')
@@ -956,6 +959,7 @@ protected function _beforeDelete()
      * After save object manipulations
      *
      * @inheritDoc
+     * @throws Throwable
      */
     protected function _afterSave()
     {
@@ -995,6 +999,7 @@ protected function _beforeSave()
      * Get creditmemos collection filtered by $filter
      *
      * @param null|array $filter
+     * @throws Mage_Core_Exception
      * @return Mage_Sales_Model_Resource_Order_Creditmemo_Collection
      */
     public function getFilteredCollectionItems($filter = null)