Fixed error when payment methods have been deleted (#2772)

sreichel · fballiano · commit d34753a87066 · 2022-12-19T16:44:25.000Z
diff --git a/app/code/core/Mage/Payment/Model/Observer.php b/app/code/core/Mage/Payment/Model/Observer.php
@@ -39,7 +39,7 @@ public function salesOrderBeforeSave($observer)
         /** @var Mage_Sales_Model_Order $order */
         $order = $observer->getEvent()->getOrder();
 
-        if ($order->getPayment()->getMethodInstance()->getCode() != 'free') {
+        if ($order->getPayment() && $order->getPayment()->getMethodInstance()->getCode() != 'free') {
             return $this;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function salesOrderBeforeSave($observer)`
`39`	`39`	`/** @var Mage_Sales_Model_Order $order */`
`40`	`40`	`$order = $observer->getEvent()->getOrder();`
`41`	`41`
`42`		`- if ($order->getPayment()->getMethodInstance()->getCode() != 'free') {`
	`42`	`+ if ($order->getPayment() && $order->getPayment()->getMethodInstance()->getCode() != 'free') {`
`43`	`43`	`return $this;`
`44`	`44`	`}`
`45`	`45`