rebase (#3237)

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>

Author: sreichel

app/code/core/Mage/Catalog/Model/Product/Image.php

@@ -251,14 +251,16 @@ protected function _getMemoryLimit()
             $memoryLimit = "128M";
         }
 
+        $value = (int)substr($memoryLimit, 0, -1);
+
         if (substr($memoryLimit, -1) == 'K') {
-            return substr($memoryLimit, 0, -1) * 1024;
+            return $value * 1024;
         }
         if (substr($memoryLimit, -1) == 'M') {
-            return substr($memoryLimit, 0, -1) * 1024 * 1024;
+            return $value * 1024 * 1024;
         }
         if (substr($memoryLimit, -1) == 'G') {
-            return substr($memoryLimit, 0, -1) * 1024 * 1024 * 1024;
+            return $value * 1024 * 1024 * 1024;
         }
         return $memoryLimit;
     }

app/code/core/Mage/Core/Controller/Request/Http.php

@@ -142,7 +142,7 @@ public function setPathInfo($pathInfo = null)
             if ($baseUrl && $pathInfo && (stripos($pathInfo, '/') !== 0)) {
                 $pathInfo = '';
                 $this->setActionName('noRoute');
-            } elseif (($baseUrl !== null) && ($pathInfo === false)) {
+            } elseif ($baseUrl !== null && !$pathInfo) {
                 $pathInfo = '';
             } elseif ($baseUrl === null) {
                 $pathInfo = $requestUri;

app/code/core/Mage/Core/Helper/Data.php

@@ -973,7 +973,7 @@ public function getEscapedCSVData(array $data)
                 $value = (string)$value;
 
                 $firstLetter = substr($value, 0, 1);
-                if ($firstLetter !== false && in_array($firstLetter, ["=", "+", "-"])) {
+                if ($firstLetter && in_array($firstLetter, ['=', '+', '-'])) {
                     $data[$key] = ' ' . $value;
                 }
             }

app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php

@@ -89,7 +89,7 @@ protected function _getColumnDefinitionFromSql($sql, $column)
      *
      * @param string $haystack
      * @param string $needle
-     * @param array $replacement
+     * @param string $replacement
      * @param bool $caseInsensitive
      * @return string
      */

app/code/core/Mage/Payment/Model/Method/Cc.php

@@ -234,7 +234,7 @@ public function validateCcNum($ccNumber)
         $numSum = 0;
 
         for ($i = 0; $i < strlen($cardNumber); $i++) {
-            $currentNum = substr($cardNumber, $i, 1);
+            $currentNum = (int)substr($cardNumber, $i, 1);
 
             /**
              * Double every second digit

app/code/core/Mage/Uploader/Helper/File.php

@@ -717,7 +717,7 @@ public function getDataMaxSize()
     public function getDataMaxSizeInBytes()
     {
         $iniSize = $this->getDataMaxSize();
-        $size = substr($iniSize, 0, -1);
+        $size = (int)substr($iniSize, 0, -1);
         $parsedSize = 0;
         switch (strtolower(substr($iniSize, strlen($iniSize) - 1))) {
             case 't':

lib/Varien/Data/Form/Element/Time.php

@@ -56,7 +56,7 @@ public function getElementHtml()
 
         if ($value = $this->getValue()) {
             $values = explode(',', $value);
-            if (is_array($values) && count($values) == 3) {
+            if (count($values) === 3) {
                 $value_hrs = $values[0];
                 $value_min = $values[1];
                 $value_sec = $values[2];

phpstan.dist.baseline.neon

@@ -2300,11 +2300,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Core/Model/Resource/Setup.php
 
-		-
-			message: "#^Binary operation \"\\.\" between \\(string\\|false\\) and array results in an error\\.$#"
-			count: 1
-			path: app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php
-
 		-
 			message: "#^Negated boolean expression is always false\\.$#"
 			count: 1
@@ -3345,11 +3340,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Payment/Model/Method/Abstract.php
 
-		-
-			message: "#^Binary operation \"\\-\" between string and int\\<\\-9, 9\\> results in an error\\.$#"
-			count: 1
-			path: app/code/core/Mage/Payment/Model/Method/Cc.php
-
 		-
 			message: "#^Loose comparison using \\!\\= between ''\\|'OT' and 'SS' will always evaluate to true\\.$#"
 			count: 1