TinyMCE: disable WYSIWYG if not installed (#4495)

sreichel · web-flow · commit c67f9356ca1e · 2025-02-14T08:20:31.000+02:00
* TinyMCE: disable WYSIWYG if not installed

* use composer-runtime-api
diff --git a/app/code/core/Mage/Cms/Model/Wysiwyg/Config.php b/app/code/core/Mage/Cms/Model/Wysiwyg/Config.php
@@ -14,6 +14,8 @@
  * @license    https://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
+use Composer\InstalledVersions;
+
 /**
  * Wysiwyg Config for Editor HTML Element
  *
@@ -25,6 +27,11 @@
  */
 class Mage_Cms_Model_Wysiwyg_Config extends Varien_Object
 {
+    /**
+     * Wysiwyg store config path
+     */
+    public const WYSIWYG_CONFIG_ENABLED = 'cms/wysiwyg/enabled';
+
     /**
      * Wysiwyg behaviour: enabled
      */
@@ -138,11 +145,15 @@ public function getSkinImagePlaceholderPath()
      */
     public function isEnabled()
     {
+        if (!InstalledVersions::isInstalled('tinymce/tinymce')) {
+            return false;
+        }
+
         $storeId = $this->getStoreId();
         if (!is_null($storeId)) {
-            $wysiwygState = Mage::getStoreConfig('cms/wysiwyg/enabled', $storeId);
+            $wysiwygState = Mage::getStoreConfig(self::WYSIWYG_CONFIG_ENABLED, $storeId);
         } else {
-            $wysiwygState = Mage::getStoreConfig('cms/wysiwyg/enabled');
+            $wysiwygState = Mage::getStoreConfig(self::WYSIWYG_CONFIG_ENABLED);
         }
         return in_array($wysiwygState, [self::WYSIWYG_ENABLED, self::WYSIWYG_HIDDEN]);
     }
@@ -154,6 +165,6 @@ public function isEnabled()
      */
     public function isHidden()
     {
-        return Mage::getStoreConfig('cms/wysiwyg/enabled') == self::WYSIWYG_HIDDEN;
+        return Mage::getStoreConfig(self::WYSIWYG_CONFIG_ENABLED) == self::WYSIWYG_HIDDEN;
     }
 }
diff --git a/composer.json b/composer.json
@@ -24,6 +24,7 @@
         "ext-simplexml": "*",
         "ext-soap": "*",
         "ext-zlib": "*",
+        "composer-runtime-api": "^2",
         "colinmollenhour/cache-backend-redis": "^1.14",
         "colinmollenhour/magento-redis-session": "^3.2.0",
         "cweagans/composer-patches": "^1.7",
@@ -48,7 +49,6 @@
     },
     "require-dev": {
         "ext-xmlreader": "*",
-        "composer/composer": "^2.7",
         "dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
         "friendsofphp/php-cs-fixer": "^3.6",
         "macopedia/phpstan-magento1": "^1.1",
diff --git a/composer.lock b/composer.lock

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@`
`14`	`14`	`* @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)`
`15`	`15`	`*/`
`16`	`16`
	`17`	`+use Composer\InstalledVersions;`
	`18`	`+`
`17`	`19`	`/**`
`18`	`20`	`* Wysiwyg Config for Editor HTML Element`
`19`	`21`	`*`
`@@ -25,6 +27,11 @@`
`25`	`27`	`*/`
`26`	`28`	`class Mage_Cms_Model_Wysiwyg_Config extends Varien_Object`
`27`	`29`	`{`
	`30`	`+ /**`
	`31`	`+ * Wysiwyg store config path`
	`32`	`+ */`
	`33`	`+ public const WYSIWYG_CONFIG_ENABLED = 'cms/wysiwyg/enabled';`
	`34`	`+`
`28`	`35`	`/**`
`29`	`36`	`* Wysiwyg behaviour: enabled`
`30`	`37`	`*/`
`@@ -138,11 +145,15 @@ public function getSkinImagePlaceholderPath()`
`138`	`145`	`*/`
`139`	`146`	`public function isEnabled()`
`140`	`147`	`{`
	`148`	`+ if (!InstalledVersions::isInstalled('tinymce/tinymce')) {`
	`149`	`+ return false;`
	`150`	`+ }`
	`151`	`+`
`141`	`152`	`$storeId = $this->getStoreId();`
`142`	`153`	`if (!is_null($storeId)) {`
`143`		`- $wysiwygState = Mage::getStoreConfig('cms/wysiwyg/enabled', $storeId);`
	`154`	`+ $wysiwygState = Mage::getStoreConfig(self::WYSIWYG_CONFIG_ENABLED, $storeId);`
`144`	`155`	`} else {`
`145`		`- $wysiwygState = Mage::getStoreConfig('cms/wysiwyg/enabled');`
	`156`	`+ $wysiwygState = Mage::getStoreConfig(self::WYSIWYG_CONFIG_ENABLED);`
`146`	`157`	`}`
`147`	`158`	`return in_array($wysiwygState, [self::WYSIWYG_ENABLED, self::WYSIWYG_HIDDEN]);`
`148`	`159`	`}`
`@@ -154,6 +165,6 @@ public function isEnabled()`
`154`	`165`	`*/`
`155`	`166`	`public function isHidden()`
`156`	`167`	`{`
`157`		`- return Mage::getStoreConfig('cms/wysiwyg/enabled') == self::WYSIWYG_HIDDEN;`
	`168`	`+ return Mage::getStoreConfig(self::WYSIWYG_CONFIG_ENABLED) == self::WYSIWYG_HIDDEN;`
`158`	`169`	`}`
`159`	`170`	`}`