Cast type, ref #735 (#2872)

Author: sreichel

app/code/core/Mage/Admin/Model/Resource/User.php

@@ -235,7 +235,7 @@ public function _saveRelations(Mage_Core_Model_Abstract $user)
 
             $adapter->delete($this->getTable('admin/role'), $conditions);
             foreach ($rolesIds as $rid) {
-                $rid = intval($rid);
+                $rid = (int) $rid;
                 if ($rid > 0) {
                     $role = Mage::getModel('admin/role')->load($rid);
                 } else {

app/code/core/Mage/Admin/Model/User.php

@@ -180,7 +180,7 @@ protected function _beforeSave()
         $this->cleanPasswordsValidationData();
 
         if (!is_null($this->getIsActive())) {
-            $data['is_active'] = intval($this->getIsActive());
+            $data['is_active'] = (int) $this->getIsActive();
         }
 
         $this->addData($data);

app/code/core/Mage/Adminhtml/Block/Api/Buttons.php

@@ -94,7 +94,7 @@ public function getSaveButtonHtml()
 
     public function getDeleteButtonHtml()
     {
-        if (intval($this->getRequest()->getParam('rid')) == 0) {
+        if ((int) $this->getRequest()->getParam('rid') == 0) {
             return;
         }
         return $this->getChildHtml('deleteButton');

app/code/core/Mage/Adminhtml/Block/Api/Editroles.php

@@ -53,7 +53,7 @@ protected function _beforeToHtml()
             'content'   => $this->getLayout()->createBlock('adminhtml/api_tab_rolesedit')->toHtml(),
         ]);
 
-        if (intval($roleId) > 0) {
+        if ((int) $roleId > 0) {
             $this->addTab('roles', [
                 'label'     => Mage::helper('adminhtml')->__('Role Users'),
                 'title'     => Mage::helper('adminhtml')->__('Role Users'),

app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Main/Formgroup.php

@@ -74,8 +74,8 @@ protected function _prepareForm()
 
     protected function _getSetId()
     {
-        return (intval($this->getRequest()->getParam('id')) > 0)
-                    ? intval($this->getRequest()->getParam('id'))
+        return ((int) $this->getRequest()->getParam('id') > 0)
+                    ? (int) $this->getRequest()->getParam('id')
                     : Mage::getModel('eav/entity_type')
                         ->load(Mage::registry('entityType'))
                         ->getDefaultAttributeSetId();

app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Action/Attribute/Tab/Inventory.php

@@ -56,7 +56,7 @@ public function getFieldSuffix()
     public function getStoreId()
     {
         $storeId = $this->getRequest()->getParam('store');
-        return intval($storeId);
+        return (int) $storeId;
     }
 
     /**

app/code/core/Mage/Adminhtml/Block/Permissions/Buttons.php

@@ -94,7 +94,7 @@ public function getSaveButtonHtml()
 
     public function getDeleteButtonHtml()
     {
-        if (intval($this->getRequest()->getParam('rid')) == 0) {
+        if ((int) $this->getRequest()->getParam('rid') == 0) {
             return;
         }
         return $this->getChildHtml('deleteButton');

app/code/core/Mage/Adminhtml/Block/Report/Grid/Column/Renderer/Currency.php

@@ -43,7 +43,7 @@ public function render(Varien_Object $row)
             return $data;
         }
 
-        $data = floatval($data) * $this->_getRate($row);
+        $data = (float) $data * $this->_getRate($row);
         $data = sprintf("%F", $data);
         $data = Mage::app()->getLocale()->currency($currency_code)->toCurrency($data);
         return $data;

app/code/core/Mage/Adminhtml/Block/Review/Rating/Detailed.php

@@ -80,10 +80,10 @@ public function getRating()
                     ->setPositionOrder()
                     ->load()
                     ->addOptionToItems();
-                if (intval($this->getRequest()->getParam('id'))) {
+                if ((int) $this->getRequest()->getParam('id')) {
                     $this->_voteCollection = Mage::getModel('rating/rating_option_vote')
                         ->getResourceCollection()
-                        ->setReviewFilter(intval($this->getRequest()->getParam('id')))
+                        ->setReviewFilter((int) $this->getRequest()->getParam('id'))
                         ->addOptionInfo()
                         ->load()
                         ->addRatingOptions();

app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php

@@ -349,7 +349,7 @@ public function displayPriceInclTax(Varien_Object $item)
         $basePriceTax = 0;
         $priceTax = 0;
 
-        if (floatval($qty)) {
+        if ((float) $qty) {
             $basePriceTax = $item->getBasePrice() + $baseTax / $qty;
             $priceTax = $item->getPrice() + $tax / $qty;
         }