rector: automatic code refactoring (part 1) (#2879)

sreichel · fballiano · commit a264cde4af75 · 2023-01-03T10:29:04.000+01:00
* Add "never" return-type for methods that never return anything - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#returnnevertyperector * Updated phpstan.dist.baseline.neon * Added ddev rector command shortcut * Change array_push() to direct variable assign - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#changearraypushtoarrayassignrector * Replace array_keys() and in_array() to array_key_exists() - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#arraykeysandinarraytoarraykeyexistsrector * Use common != instead of less known <> with same meaning - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#commonnotequalrector * Issue in rector found ...reverted - see rectorphp/rector#7699 * Updated phpstan.dist.baseline.neon * Change compact() call to own array - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#compacttovariablesrector * Change OR, AND to ||, && with more common understanding - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#logicaltobooleanrector * Replace the Double not operator (!!) by type-casting to boolean - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#replacemultiplebooleannotrector * Simplify array_search to in_array - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifyarraysearchrector * Changes compared to value and return of expr to direct return - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifyifexactvaluereturnvaluerector * Updated phpstan.dist.baseline.neon This error goes and comes ... * Changes strlen comparison to 0 to direct empty string compare - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#strlenzerotoidenticalemptystringrector * Simplify conditions - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifyconditionsrector * Simplify tautology ternary to value - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifytautologyternaryrector * Splits [$a, $b] = [5, 10] scalar assign to standalone lines - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#splitlistassigntoseparatelinerector
diff --git a/.ddev/commands/web/rector b/.ddev/commands/web/rector
@@ -0,0 +1,8 @@
+#!/bin/bash
+
+## Description: run rector
+## Usage: rector
+## Example: ddev rector <path-to-files>
+
+cp -n vendor/sreichel/openmage-rector/rector.php rector.php
+php vendor/bin/rector process "$@"
diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Totals.php b/app/code/core/Mage/Adminhtml/Block/Sales/Totals.php
@@ -78,7 +78,7 @@ protected function _initTotals()
         /**
          * Add discount
          */
-        if (((float)$this->getSource()->getDiscountAmount()) != 0) {
+        if ((float)$this->getSource()->getDiscountAmount() != 0) {
             if ($this->getSource()->getDiscountDescription()) {
                 $discountLabel = $this->helper('sales')->__(
                     'Discount (%s)',
diff --git a/app/code/core/Mage/Adminhtml/Block/Widget/Grid.php b/app/code/core/Mage/Adminhtml/Block/Widget/Grid.php
@@ -423,7 +423,7 @@ public function sortColumnsByOrder()
         $values = array_values($this->_columns);
 
         foreach ($this->getColumnsOrder() as $columnId => $after) {
-            if (array_search($after, $keys) !== false) {
+            if (in_array($after, $keys)) {
                 // Moving grid column
                 $positionCurrent = array_search($columnId, $keys);
 
diff --git a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php
@@ -216,7 +216,7 @@ protected function _processActionData($action = null)
         /**
          * Adding products to quote from special grid
          */
-        if ($this->getRequest()->has('item') && !$this->getRequest()->getPost('update_items') && !($action == 'save')) {
+        if ($this->getRequest()->has('item') && !$this->getRequest()->getPost('update_items') && $action != 'save') {
             $items = $this->getRequest()->getPost('item');
             $items = $this->_processFiles($items);
             $this->_getOrderCreateModel()->addProducts($items);
diff --git a/app/code/core/Mage/Api/Helper/Data.php b/app/code/core/Mage/Api/Helper/Data.php
@@ -307,8 +307,8 @@ protected function _parseComplexFilter($complexFilter)
             if (!isset($filter->key) || !isset($filter->value)) {
                 continue;
             }
-
-            list($fieldName, $condition) = [$filter->key, $filter->value];
+            $fieldName = $filter->key;
+            $condition = $filter->value;
             $conditionName = $condition->key;
             $conditionValue = $condition->value;
             $this->formatFilterConditionValue($conditionName, $conditionValue);
diff --git a/app/code/core/Mage/Api/Model/Resource/Abstract.php b/app/code/core/Mage/Api/Model/Resource/Abstract.php
@@ -93,6 +93,7 @@ protected function _getServer()
      * @param string $code
      * @param string|null $customMessage
      * @throws Mage_Api_Exception
+     * @return never
      */
     protected function _fault($code, $customMessage = null)
     {
diff --git a/app/code/core/Mage/Api/Model/Server/Adapter/Xmlrpc.php b/app/code/core/Mage/Api/Model/Server/Adapter/Xmlrpc.php
@@ -112,6 +112,7 @@ public function run()
      *
      * @param int $code
      * @param string $message
+     * @return never
      */
     public function fault($code, $message)
     {
diff --git a/app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php b/app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php
@@ -628,6 +628,7 @@ protected function _isConfigValueUsed($data, $field)
      * @param string $message
      * @param int $code
      * @throws Mage_Api2_Exception
+     * @return never
      */
     protected function _critical($message, $code)
     {
diff --git a/app/code/core/Mage/Catalog/Model/Api2/Product/Website/Validator/Admin/Website.php b/app/code/core/Mage/Catalog/Model/Api2/Product/Website/Validator/Admin/Website.php
@@ -176,7 +176,7 @@ protected function _checkStoreTo($website, $storeData)
      */
     public function isWebsiteAssignedToProduct(Mage_Core_Model_Website $website, Mage_Catalog_Model_Product $product)
     {
-        if (array_search($website->getId(), $product->getWebsiteIds()) === false) {
+        if (!in_array($website->getId(), $product->getWebsiteIds())) {
             $this->_addError(sprintf(
                 'Product #%d isn\'t assigned to website #%d',
                 $product->getId(),
diff --git a/app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Startdate.php b/app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Startdate.php
@@ -39,9 +39,6 @@ protected function _getValueForSave($object)
     {
         $attributeName  = $this->getAttribute()->getName();
         $startDate      = $object->getData($attributeName);
-        if ($startDate === false) {
-            return false;
-        }
         return $startDate;
     }
 
diff --git a/app/code/core/Mage/CatalogInventory/Model/Stock/Status.php b/app/code/core/Mage/CatalogInventory/Model/Stock/Status.php
@@ -312,11 +312,11 @@ protected function _processChildren(
                     $optionStatus = false;
                     foreach ($groupedChildrenIds as $childId) {
                         if (isset($childrenStatus[$childId])
-                            and isset($childrenWebsites[$childId])
-                            and in_array($websiteId, $childrenWebsites[$childId])
-                            and $childrenStatus[$childId] == $this->getProductStatusEnabled()
-                            and isset($childrenStock[$childId])
-                            and $childrenStock[$childId] == self::STATUS_IN_STOCK
+                            && isset($childrenWebsites[$childId])
+                            && in_array($websiteId, $childrenWebsites[$childId])
+                            && $childrenStatus[$childId] == $this->getProductStatusEnabled()
+                            && isset($childrenStock[$childId])
+                            && $childrenStock[$childId] == self::STATUS_IN_STOCK
                         ) {
                             $optionStatus = true;
                         }
diff --git a/app/code/core/Mage/Core/Controller/Response/Http.php b/app/code/core/Mage/Core/Controller/Response/Http.php
@@ -105,6 +105,7 @@ public function setRedirect($url, $code = 302)
 
     /**
      * Method send already collected headers and exit from script
+     * @return never
      */
     public function sendHeadersAndExit()
     {
diff --git a/app/code/core/Mage/Core/Helper/Data.php b/app/code/core/Mage/Core/Helper/Data.php
@@ -404,8 +404,8 @@ public function isDevAllowed($storeId = null)
         $remoteAddr = Mage::helper('core/http')->getRemoteAddr();
         if (!empty($allowedIps) && !empty($remoteAddr)) {
             $allowedIps = preg_split('#\s*,\s*#', $allowedIps, -1, PREG_SPLIT_NO_EMPTY);
-            if (array_search($remoteAddr, $allowedIps) === false
-                && array_search(Mage::helper('core/http')->getHttpHost(), $allowedIps) === false
+            if (!in_array($remoteAddr, $allowedIps)
+                && !in_array(Mage::helper('core/http')->getHttpHost(), $allowedIps)
             ) {
                 $allow = false;
             }
diff --git a/app/code/core/Mage/Core/Helper/Http.php b/app/code/core/Mage/Core/Helper/Http.php
@@ -85,6 +85,7 @@ public function authValidate($headers = null)
     /**
      * Send auth failed Headers and exit
      *
+     * @return never
      */
     public function authFailed()
     {
diff --git a/app/code/core/Mage/Core/Model/App.php b/app/code/core/Mage/Core/Model/App.php
@@ -1434,6 +1434,7 @@ public function getUpdateMode()
     /**
      * @param string $text
      * @throws Mage_Core_Model_Store_Exception
+     * @return never
      */
     public function throwStoreException($text = '')
     {
diff --git a/app/code/core/Mage/Core/Model/Config.php b/app/code/core/Mage/Core/Model/Config.php
@@ -690,10 +690,6 @@ protected function _getSectionConfig($path)
             $this->_cacheLoadedSections[$sectionKey] = $this->_loadSectionCache($sectionKey);
             Varien_Profiler::stop('init_config_section:' . $sectionKey);
         }
-
-        if ($this->_cacheLoadedSections[$sectionKey] === false) {
-            return false;
-        }
         return $this->_cacheLoadedSections[$sectionKey];
     }
 
diff --git a/app/code/core/Mage/Core/Model/Url/Rewrite.php b/app/code/core/Mage/Core/Model/Url/Rewrite.php
@@ -154,7 +154,7 @@ public function hasOption($key)
     {
         $optArr = explode(',', $this->getOptions());
 
-        return array_search($key, $optArr) !== false;
+        return in_array($key, $optArr);
     }
 
     /**
diff --git a/app/code/core/Mage/Dataflow/Model/Profile.php b/app/code/core/Mage/Dataflow/Model/Profile.php
@@ -348,7 +348,7 @@ public function _parseGuiData()
                 $parseFileXml = '<action type="dataflow/convert_parser_xml_excel" method="'
                     . ($import ? 'parse' : 'unparse') . '">' . $nl;
                 $parseFileXml .= '    <var name="single_sheet"><![CDATA['
-                    . ($p['parse']['single_sheet'] !== '' ? $p['parse']['single_sheet'] : '')
+                    . ($p['parse']['single_sheet'])
                     . ']]></var>' . $nl;
                 break;
 
diff --git a/app/code/core/Mage/Downloadable/Model/Link/Api/Validator.php b/app/code/core/Mage/Downloadable/Model/Link/Api/Validator.php
@@ -149,12 +149,12 @@ public function completeCheck(&$resource, $resourceType)
      */
     public function validateFileDetails(&$var)
     {
-        if (!isset($var['name']) || !is_string($var['name']) || strlen($var['name']) === 0) {
+        if (!isset($var['name']) || !is_string($var['name']) || $var['name'] === '') {
             throw new Exception('no_filename');
         }
         if (!isset($var['base64_content'])
             || !is_string($var['base64_content'])
-            || strlen($var['base64_content']) === 0
+            || $var['base64_content'] === ''
         ) {
             throw new Exception('no_file_base64_content');
         }
@@ -186,7 +186,7 @@ protected function _dispatch(&$resource, $fields)
      */
     public function validateTitle(&$var)
     {
-        if (!is_string($var) || strlen($var) === 0) {
+        if (!is_string($var) || $var === '') {
             throw new Exception('no_title');
         }
     }
diff --git a/app/code/core/Mage/Eav/Model/Entity/Abstract.php b/app/code/core/Mage/Eav/Model/Entity/Abstract.php
@@ -1214,7 +1214,13 @@ protected function _collectSaveData($newObject)
             }
         }
 
-        return compact('newObject', 'entityRow', 'insert', 'update', 'delete');
+        return [
+            'newObject' => $newObject,
+            'entityRow' => $entityRow,
+            'insert'    => $insert,
+            'update'    => $update,
+            'delete'    => $delete
+        ];
     }
 
     /**
diff --git a/app/code/core/Mage/ImportExport/Model/Import.php b/app/code/core/Mage/ImportExport/Model/Import.php
@@ -391,8 +391,7 @@ public function expandSource()
     public function uploadSource()
     {
         $entity    = $this->getEntity();
-        $validTypes = array_keys(Mage_ImportExport_Model_Config::getModels(self::CONFIG_KEY_ENTITIES));
-        if (!in_array($entity, $validTypes)) {
+        if (!array_key_exists($entity, Mage_ImportExport_Model_Config::getModels(self::CONFIG_KEY_ENTITIES))) {
             Mage::throwException(Mage::helper('importexport')->__('Incorrect entity type'));
         }
         $uploader  = Mage::getModel('core/file_uploader', self::FIELD_NAME_SOURCE_FILE);
diff --git a/app/code/core/Mage/Oauth/Model/Server.php b/app/code/core/Mage/Oauth/Model/Server.php
@@ -425,6 +425,7 @@ protected function _saveToken()
      *
      * @param string $message Exception message
      * @param int $code Exception code
+     * @return never
      */
     protected function _throwException($message = '', $code = 0)
     {
diff --git a/app/code/core/Mage/Paypal/Model/Cart.php b/app/code/core/Mage/Paypal/Model/Cart.php
@@ -456,7 +456,7 @@ protected function _addRegularItem(Varien_Object $salesItem)
         }
 
         // aggregate item price if item qty * price does not match row total
-        if (($amount * $qty) != $salesItem->getBaseRowTotal()) {
+        if ($amount * $qty != $salesItem->getBaseRowTotal()) {
             $amount = (float) $salesItem->getBaseRowTotal();
             $subAggregatedLabel = ' x' . $qty;
             $qty = 1;
diff --git a/app/code/core/Mage/Paypal/Model/Config.php b/app/code/core/Mage/Paypal/Model/Config.php
@@ -1286,8 +1286,7 @@ public function getAdditionalOptionsLogoUrl($localeCode, $type = false)
         }
         $type = $type ? $type : $configType;
         $locale = $this->_getSupportedLocaleCode($localeCode);
-        $supportedTypes = array_keys($this->getAdditionalOptionsLogoTypes());
-        if (!in_array($type, $supportedTypes)) {
+        if (!array_key_exists($type, $this->getAdditionalOptionsLogoTypes())) {
             $type = self::DEFAULT_LOGO_TYPE;
         }
         return sprintf('https://www.paypalobjects.com/%s/i/bnr/bnr_%s.gif', $locale, $type);
diff --git a/app/code/core/Mage/Sales/Block/Order/Totals.php b/app/code/core/Mage/Sales/Block/Order/Totals.php
@@ -123,7 +123,7 @@ protected function _initTotals()
         /**
          * Add discount
          */
-        if (((float)$this->getSource()->getDiscountAmount()) != 0) {
+        if ((float)$this->getSource()->getDiscountAmount() != 0) {
             if ($this->getSource()->getDiscountDescription()) {
                 $discountLabel = $this->__('Discount (%s)', $source->getDiscountDescription());
             } else {
diff --git a/app/code/core/Mage/Sales/Model/Order/Creditmemo/Api/V2.php b/app/code/core/Mage/Sales/Model/Order/Creditmemo/Api/V2.php
@@ -69,7 +69,7 @@ protected function _prepareListFilter($filters = null)
     protected function _prepareCreateData($data)
     {
         // convert data object to array, if it's null turn it into empty array
-        $data = (isset($data) and is_object($data)) ? get_object_vars($data) : [];
+        $data = (isset($data) && is_object($data)) ? get_object_vars($data) : [];
         // convert qtys object to array
         if (isset($data['qtys']) && count($data['qtys'])) {
             $qtysArray = [];
diff --git a/lib/Mage/Cache/Backend/File.php b/lib/Mage/Cache/Backend/File.php
@@ -369,7 +369,7 @@ public function touch($id, $extraLifetime)
             'tags'   => $metadatas['tags']
         ];
 
-        return !!$this->_filePutContents($file, serialize($newMetadatas) . "\n" . $data);
+        return (bool) $this->_filePutContents($file, serialize($newMetadatas) . "\n" . $data);
     }
 
     /**
diff --git a/lib/Mage/DB/Mysqli.php b/lib/Mage/DB/Mysqli.php
@@ -305,7 +305,7 @@ public function escapeFieldValues(array $arrNames)
     /**
      * Throw connect exception
      * @throws Mage_DB_Exception
-     * @return void
+     * @return never
      */
     protected function throwConnectException()
     {
diff --git a/lib/Mage/HTTP/Client/Curl.php b/lib/Mage/HTTP/Client/Curl.php
@@ -391,6 +391,7 @@ protected function makeRequest($method, $uri, $params = [])
      * Throw error excpetion
      * @param $string
      * @throws Exception
+     * @return never
      */
     public function doError($string)
     {
diff --git a/lib/Mage/HTTP/Client/Socket.php b/lib/Mage/HTTP/Client/Socket.php
@@ -478,6 +478,7 @@ protected function makeRequest($method, $uri, $params = [])
      * Throw error excpetion
      * @param $string
      * @throws Exception
+     * @return never
      */
     public function doError($string)
     {
diff --git a/lib/Varien/Data/Tree/Node.php b/lib/Varien/Data/Tree/Node.php
@@ -300,7 +300,7 @@ public function removeChild($childNode)
     public function getPath(&$prevNodes = [])
     {
         if ($this->_parent) {
-            array_push($prevNodes, $this);
+            $prevNodes[] = $this;
             $this->_parent->getPath($prevNodes);
         }
         return $prevNodes;
diff --git a/lib/Varien/Db/Adapter/Pdo/Mysql.php b/lib/Varien/Db/Adapter/Pdo/Mysql.php
@@ -1745,7 +1745,7 @@ public function describeTable($tableName, $schemaName = null)
              */
             $affected = ['tinyint', 'smallint', 'mediumint', 'int', 'bigint'];
             foreach ($ddl as $key => $columnData) {
-                if (($columnData['DEFAULT'] === '') && (array_search($columnData['DATA_TYPE'], $affected) !== false)) {
+                if (($columnData['DEFAULT'] === '') && (in_array($columnData['DATA_TYPE'], $affected))) {
                     $ddl[$key]['DEFAULT'] = null;
                 }
             }
diff --git a/lib/Varien/Io/Abstract.php b/lib/Varien/Io/Abstract.php
@@ -98,7 +98,7 @@ public function getCleanPath($path)
                 }
             }
 
-            array_push($realPathParts, $pathParts[$i]);
+            $realPathParts[] = $pathParts[$i];
         }
 
         return $pathTokR . implode('/', $realPathParts);
diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon
@@ -2080,36 +2080,6 @@ parameters:
 			count: 2
 			path: app/code/core/Mage/Catalog/Model/Product/Api.php
 
-		-
-			message: "#^Cannot access property \\$additional_attributes on array\\.$#"
-			count: 5
-			path: app/code/core/Mage/Catalog/Model/Product/Api/V2.php
-
-		-
-			message: "#^Cannot access property \\$categories on array\\.$#"
-			count: 2
-			path: app/code/core/Mage/Catalog/Model/Product/Api/V2.php
-
-		-
-			message: "#^Cannot access property \\$stock_data on array\\.$#"
-			count: 1
-			path: app/code/core/Mage/Catalog/Model/Product/Api/V2.php
-
-		-
-			message: "#^Cannot access property \\$tier_price on array\\.$#"
-			count: 1
-			path: app/code/core/Mage/Catalog/Model/Product/Api/V2.php
-
-		-
-			message: "#^Cannot access property \\$website_ids on array\\.$#"
-			count: 2
-			path: app/code/core/Mage/Catalog/Model/Product/Api/V2.php
-
-		-
-			message: "#^Cannot access property \\$websites on array\\.$#"
-			count: 3
-			path: app/code/core/Mage/Catalog/Model/Product/Api/V2.php
-
 		-
 			message: "#^Parameter \\#3 \\$attributes \\(stdClass\\) of method Mage_Catalog_Model_Product_Api_V2\\:\\:info\\(\\) should be compatible with parameter \\$attributes \\(array\\) of method Mage_Catalog_Model_Product_Api\\:\\:info\\(\\)$#"
 			count: 1
@@ -2135,6 +2105,16 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php
 
+		-
+			message: "#^Access to an undefined property object\\:\\:\\$customer_group_id\\.$#"
+			count: 1
+			path: app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api/V2.php
+
+		-
+			message: "#^Access to an undefined property object\\:\\:\\$website\\.$#"
+			count: 1
+			path: app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api/V2.php
+
 		-
 			message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item\\:\\:clean\\(\\) invoked with 1 parameter, 0 required\\.$#"
 			count: 1
@@ -7770,16 +7750,6 @@ parameters:
 			count: 1
 			path: lib/Varien/Image/Adapter/Gd2.php
 
-		-
-			message: "#^Offset 0 on array\\{\\} in isset\\(\\) does not exist\\.$#"
-			count: 1
-			path: lib/Varien/Io/Abstract.php
-
-		-
-			message: "#^Result of && is always false\\.$#"
-			count: 1
-			path: lib/Varien/Io/Abstract.php
-
 		-
 			message: "#^If condition is always true\\.$#"
 			count: 1

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ protected function _getServer()`
`93`	`93`	`* @param string $code`
`94`	`94`	`* @param string\|null $customMessage`
`95`	`95`	`* @throws Mage_Api_Exception`
	`96`	`+ * @return never`
`96`	`97`	`*/`
`97`	`98`	`protected function _fault($code, $customMessage = null)`
`98`	`99`	`{`
Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ public function run()`
`112`	`112`	`*`
`113`	`113`	`* @param int $code`
`114`	`114`	`* @param string $message`
	`115`	`+ * @return never`
`115`	`116`	`*/`
`116`	`117`	`public function fault($code, $message)`
`117`	`118`	`{`
Original file line number	Diff line number	Diff line change
`@@ -628,6 +628,7 @@ protected function _isConfigValueUsed($data, $field)`
`628`	`628`	`* @param string $message`
`629`	`629`	`* @param int $code`
`630`	`630`	`* @throws Mage_Api2_Exception`
	`631`	`+ * @return never`
`631`	`632`	`*/`
`632`	`633`	`protected function _critical($message, $code)`
`633`	`634`	`{`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ protected function _checkStoreTo($website, $storeData)`
`176`	`176`	`*/`
`177`	`177`	`public function isWebsiteAssignedToProduct(Mage_Core_Model_Website $website, Mage_Catalog_Model_Product $product)`
`178`	`178`	`{`
`179`		`- if (array_search($website->getId(), $product->getWebsiteIds()) === false) {`
	`179`	`+ if (!in_array($website->getId(), $product->getWebsiteIds())) {`
`180`	`180`	`$this->_addError(sprintf(`
`181`	`181`	`'Product #%d isn\'t assigned to website #%d',`
`182`	`182`	`$product->getId(),`
Original file line number	Diff line number	Diff line change
`@@ -39,9 +39,6 @@ protected function _getValueForSave($object)`
`39`	`39`	`{`
`40`	`40`	`$attributeName = $this->getAttribute()->getName();`
`41`	`41`	`$startDate = $object->getData($attributeName);`
`42`		`- if ($startDate === false) {`
`43`		`- return false;`
`44`		`- }`
`45`	`42`	`return $startDate;`
`46`	`43`	`}`
`47`	`44`