Fixed PHP8.2 deprecated warning in Mage_Cron_Model_Observer (#3253)

fballiano · kiatng · web-flow · commit 90fefd776e3d · 2023-05-23T16:39:26.000+01:00
Co-authored-by: Ng Kiat Siong &lt;kiatsiong.ng@gmail.com&gt;
diff --git a/app/code/core/Mage/Cron/Model/Observer.php b/app/code/core/Mage/Cron/Model/Observer.php
@@ -220,7 +220,9 @@ public function cleanup()
 
         $now = time();
         foreach ($history->getIterator() as $record) {
-            if (strtotime($record->getExecutedAt()) < $now - $historyLifetimes[$record->getStatus()]) {
+            if (empty($record->getExecutedAt())
+                || (strtotime($record->getExecutedAt()) < $now - $historyLifetimes[$record->getStatus()])
+            ) {
                 $record->delete();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,9 @@ public function cleanup()`
`220`	`220`
`221`	`221`	`$now = time();`
`222`	`222`	`foreach ($history->getIterator() as $record) {`
`223`		`- if (strtotime($record->getExecutedAt()) < $now - $historyLifetimes[$record->getStatus()]) {`
	`223`	`+ if (empty($record->getExecutedAt())`
	`224`	`+ \|\| (strtotime($record->getExecutedAt()) < $now - $historyLifetimes[$record->getStatus()])`
	`225`	`+ ) {`
`224`	`226`	`$record->delete();`
`225`	`227`	`}`
`226`	`228`	`}`