Replace alias methods (#1394)

- join vs implode
- is_integer vs is_int
- ...

Author: sreichel

app/code/core/Mage/Admin/Model/User.php

@@ -563,7 +563,7 @@ public function getStartupPageUrl()
         $startupPage = Mage::getStoreConfig(self::XML_PATH_STARTUP_PAGE);
         $aclResource = 'admin/' . $startupPage;
         if (Mage::getSingleton('admin/session')->isAllowed($aclResource)) {
-            $nodePath = 'menu/' . join('/children/', explode('/', $startupPage)) . '/action';
+            $nodePath = 'menu/' . implode('/children/', explode('/', $startupPage)) . '/action';
             $url = (string)Mage::getSingleton('admin/config')->getAdminhtmlConfig()->getNode($nodePath);
             if ($url) {
                 return $url;

app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field.php

@@ -120,7 +120,7 @@ public function render(Varien_Data_Form_Element_Abstract $element)
                         }
                     }
                 }
-                $defText = join(', ', $defTextArr);
+                $defText = implode(', ', $defTextArr);
             }
 
             // default value

app/code/core/Mage/Adminhtml/Block/System/Currency/Rate/Matrix.php

@@ -86,7 +86,7 @@ protected function _prepareRates($array)
                 $parts = explode('.', $value);
                 if( count($parts) === 2 ) {
                     $parts[1] = str_pad(rtrim($parts[1], 0), 4, '0', STR_PAD_RIGHT);
-                    $array[$key][$code] = join('.', $parts);
+                    $array[$key][$code] = implode('.', $parts);
                 } elseif( $value > 0 ) {
                     $array[$key][$code] = number_format($value, 4);
                 } else {

app/code/core/Mage/Adminhtml/Block/System/Store/Store.php

@@ -85,7 +85,7 @@ public function getGridHtml()
      */
     public function getAddNewButtonHtml()
     {
-        return join(' ', array(
+        return implode(' ', array(
             $this->getChildHtml('add_new_website'),
             $this->getChildHtml('add_new_group'),
             $this->getChildHtml('add_new_store')

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Concat.php

@@ -50,7 +50,7 @@ public function render(Varien_Object $row)
                 $dataArr[] = $data;
             }
         }
-        $data = join($this->getColumn()->getSeparator(), $dataArr);
+        $data = implode($this->getColumn()->getSeparator(), $dataArr);
         // TODO run column type renderer
         return $data;
     }

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Massaction/Abstract.php

@@ -191,7 +191,7 @@ public function getSelectedJson()
     {
         if($selected = $this->getRequest()->getParam($this->getFormFieldNameInternal())) {
             $selected = explode(',', $this->quoteEscape($selected));
-            return join(',', $selected);
+            return implode(',', $selected);
         } else {
             return '';
         }
@@ -243,7 +243,7 @@ public function getGridIdsJson()
         $gridIds = $this->getParentBlock()->getCollection()->getAllIds();
 
         if(!empty($gridIds)) {
-            return join(",", $gridIds);
+            return implode(",", $gridIds);
         }
         return '';
     }

app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Currency/Allow.php

@@ -56,7 +56,7 @@ protected function _afterSave()
         }
 
         if ($exceptions) {
-            Mage::throwException(join("\n", $exceptions));
+            Mage::throwException(implode("\n", $exceptions));
         }
 
         return $this;

app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Currency/Cron.php

@@ -52,7 +52,7 @@ protected function _afterSave()
             ($frequency == $frequencyWeekly) ? '1' : '*',           # Day of the Week
         );
 
-        $cronExprString = join(' ', $cronExprArray);
+        $cronExprString = implode(' ', $cronExprArray);
 
         try {
             Mage::getModel('core/config_data')

app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Locale.php

@@ -138,7 +138,7 @@ protected function _afterSave()
             }
         }
         if ($exceptions) {
-            Mage::throwException(join("\n", $exceptions));
+            Mage::throwException(implode("\n", $exceptions));
         }
 
         return $this;

app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Log/Cron.php

@@ -59,7 +59,7 @@ protected function _afterSave()
                 '*',                                                    # Month of the Year
                 ($frequency == $frequencyWeekly) ? '1' : '*',           # Day of the Week
             );
-            $cronExprString = join(' ', $cronExprArray);
+            $cronExprString = implode(' ', $cronExprArray);
         }
         else {
             $cronExprString = '';