Merge branch 'main' into validation

Author: sreichel

.all-contributorsrc

@@ -1716,6 +1716,15 @@
       "contributions": [
         "code"
       ]
+    },
+    {
+      "login": "vernad",
+      "name": "vernad",
+      "avatar_url": "https://avatars.githubusercontent.com/u/51973447?v=4",
+      "profile": "https://github.com/vernad",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "commitType": "docs"

.phpstan.dist.baseline.neon

@@ -277,6 +277,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
       <td align="center" valign="top" width="14.28%"><a href="http://www.denisahac.xyz"><img src="https://avatars.githubusercontent.com/u/6700576?v=4" loading="lazy" width="100" alt=""/><br /><sub><b>Den Isahac</b></sub></a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/lc-excell"><img src="https://avatars.githubusercontent.com/u/158118232?v=4" loading="lazy" width="100" alt=""/><br /><sub><b>lc-excell</b></sub></a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://www.linkedin.com/in/warley-elias-531a4116/"><img src="https://avatars.githubusercontent.com/u/5356619?v=4" loading="lazy" width="100" alt=""/><br /><sub><b>Warley Elias</b></sub></a></td>
+      <td align="center" valign="top" width="14.28%"><a href="https://github.com/vernard"><img src="https://avatars.githubusercontent.com/u/6733673?v=4" loading="lazy" width="100" alt=""/><br /><sub><b>vernard</b></sub></a></td>
     </tr>
   </tbody>
 </table>

README.md

@@ -487,7 +487,7 @@ public function formatPrice($price)
     /**
      * Retrieve source
      *
-     * @return Mage_Sales_Model_Order_Invoice
+     * @return Mage_Sales_Model_Abstract
      */
     public function getSource()
     {

app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php

@@ -33,7 +33,9 @@ protected function _getCollectionClass()
 
     protected function _prepareCollection()
     {
-        $collection = Mage::getResourceModel($this->_getCollectionClass())
+        /** @var Mage_Sales_Model_Resource_Order_Creditmemo_Grid_Collection $collection */
+        $collection = Mage::getResourceModel($this->_getCollectionClass());
+        $collection
             ->addFieldToSelect('entity_id')
             ->addFieldToSelect('created_at')
             ->addFieldToSelect('increment_id')

app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Creditmemos.php

@@ -33,7 +33,9 @@ protected function _getCollectionClass()
 
     protected function _prepareCollection()
     {
-        $collection = Mage::getResourceModel($this->_getCollectionClass())
+        /** @var Mage_Sales_Model_Resource_Order_Invoice_Grid_Collection $collection */
+        $collection = Mage::getResourceModel($this->_getCollectionClass());
+        $collection
             ->addFieldToSelect('entity_id')
             ->addFieldToSelect('created_at')
             ->addFieldToSelect('order_id')

app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Invoices.php

@@ -33,7 +33,9 @@ protected function _getCollectionClass()
 
     protected function _prepareCollection()
     {
-        $collection = Mage::getResourceModel($this->_getCollectionClass())
+        /** @var Mage_Sales_Model_Resource_Order_Shipment_Grid_Collection $collection */
+        $collection = Mage::getResourceModel($this->_getCollectionClass());
+        $collection
             ->addFieldToSelect('entity_id')
             ->addFieldToSelect('created_at')
             ->addFieldToSelect('increment_id')

app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Shipments.php

@@ -31,7 +31,7 @@ protected function _prepareLayout()
 
         foreach ($currencies as $currency) {
             foreach ($oldCurrencies as $key => $value) {
-                if (!array_key_exists($currency, $oldCurrencies[$key])) {
+                if (!array_key_exists($currency, $value)) {
                     $oldCurrencies[$key][$currency] = '';
                 }
             }
@@ -66,7 +66,7 @@ protected function _prepareRates($array)
             foreach ($rate as $code => $value) {
                 $parts = explode('.', (string) $value);
                 if (count($parts) === 2) {
-                    $parts[1] = str_pad(rtrim($parts[1], 0), 4, '0', STR_PAD_RIGHT);
+                    $parts[1] = str_pad(rtrim($parts[1], '0'), 4, '0', STR_PAD_RIGHT);
                     $array[$key][$code] = implode('.', $parts);
                 } elseif ($value > 0) {
                     $array[$key][$code] = number_format($value, 4);

app/code/core/Mage/Adminhtml/Block/System/Currency/Rate/Matrix.php

@@ -967,7 +967,7 @@ public function getMessageBlockVisibility()
     }
 
     /**
-     * @param int $limit
+     * @param null|int $limit
      * @return $this
      */
     public function setDefaultLimit($limit)

app/code/core/Mage/Adminhtml/Block/Widget/Grid.php

@@ -82,7 +82,7 @@ protected function _initInvoice($update = false)
     protected function _saveInvoice($invoice)
     {
         $invoice->getOrder()->setIsInProcess(true);
-        $transactionSave = Mage::getModel('core/resource_transaction')
+        Mage::getModel('core/resource_transaction')
             ->addObject($invoice)
             ->addObject($invoice->getOrder())
             ->save();