sonar 6

sreichel · sreichel · commit 47af7e2af0e4 · 2025-04-19T19:49:29.000+02:00
diff --git a/tests/unit/Mage/Tax/Helper/DataTest.php b/tests/unit/Mage/Tax/Helper/DataTest.php
@@ -119,8 +119,9 @@ public function testGetPriceDisplayType(): void
      */
     public function testNeedPriceConversion(): void
     {
-        #$this->assertSame(1, self::$subject->needPriceConversion());
-        static::markTestIncomplete();
+        static::markTestSkipped(self::SKIP_INCOMPLETE);
+        /** @phpstan-ignore deadCode.unreachable */
+        $this->assertSame(1, self::$subject->needPriceConversion());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -119,8 +119,9 @@ public function testGetPriceDisplayType(): void`
`119`	`119`	`*/`
`120`	`120`	`public function testNeedPriceConversion(): void`
`121`	`121`	`{`
`122`		`- #$this->assertSame(1, self::$subject->needPriceConversion());`
`123`		`- static::markTestIncomplete();`
	`122`	`+ static::markTestSkipped(self::SKIP_INCOMPLETE);`
	`123`	`+ /** @phpstan-ignore deadCode.unreachable */`
	`124`	`+ $this->assertSame(1, self::$subject->needPriceConversion());`
`124`	`125`	`}`
`125`	`126`
`126`	`127`	`/**`