Cleanup: update addHandle() docblock (#4460)

* Cleanup: update docblock

* fixed workflow

* phpstan

* fixes

Author: sreichel

.phpstan.dist.baseline.neon

@@ -558,12 +558,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php
 
-		-
-			message: '#^Parameter \#1 \$ids of method Mage_Adminhtml_Controller_Action\:\:loadLayout\(\) expects bool\|string\|null, array\<int, string\> given\.$#'
-			identifier: argument.type
-			count: 2
-			path: app/code/core/Mage/Adminhtml/Controller/Action.php
-
 		-
 			message: '#^Return type \(Mage_Admin_Model_Session\) of method Mage_Adminhtml_Controller_Report_Abstract\:\:_getSession\(\) should be compatible with return type \(Mage_Adminhtml_Model_Session\) of method Mage_Adminhtml_Controller_Action\:\:_getSession\(\)$#'
 			identifier: method.childReturnType
@@ -678,12 +672,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/SetController.php
 
-		-
-			message: '#^Parameter \#1 \$ids of method Mage_Adminhtml_Controller_Action\:\:loadLayout\(\) expects bool\|string\|null, array\<int, string\> given\.$#'
-			identifier: argument.type
-			count: 2
-			path: app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php
-
 		-
 			message: '#^Method Mage_Adminhtml_Controller_Action\:\:_setForcedFormKeyActions\(\) invoked with 2 parameters, 1 required\.$#'
 			identifier: arguments.count
@@ -2892,12 +2880,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Core/Controller/Varien/Action.php
 
-		-
-			message: '#^Parameter \#1 \$handles of method Mage_Core_Controller_Varien_Action\:\:loadLayout\(\) expects bool\|string\|null, array\<int, string\> given\.$#'
-			identifier: argument.type
-			count: 2
-			path: app/code/core/Mage/Core/Controller/Varien/Action.php
-
 		-
 			message: '#^Parameter \#2 \$value of method Zend_Controller_Response_Abstract\:\:setHeader\(\) expects string, int\|false given\.$#'
 			identifier: argument.type

.rector.php

@@ -22,7 +22,7 @@
         CodeQuality\BooleanNot\SimplifyDeMorganBinaryRector::class,
         CodeQuality\If_\SimplifyIfReturnBoolRector::class,
         __DIR__ . '/shell/translations.php',
-        __DIR__ . '/shell/update-copyright.php.php'
+        __DIR__ . '/shell/update-copyright.php.php',
     ])
     ->withRules([
         CodeQuality\BooleanNot\ReplaceMultipleBooleanNotRector::class,
@@ -59,4 +59,4 @@
         false,
         false,
         true,
-    );
+    );

app/code/core/Mage/Core/Controller/Varien/Action.php

@@ -225,7 +225,7 @@ public function getLayout()
     /**
      * Load layout by handles(s)
      *
-     * @param   string|null|bool $handles
+     * @param   array|string|null|bool $handles
      * @param   bool $generateBlocks
      * @param   bool $generateXml
      * @return  $this

app/code/core/Mage/Core/Model/Layout/Update.php

@@ -142,14 +142,14 @@ public function resetHandles()
     }
 
     /**
-     * @param string $handle
+     * @param array|string $handle
      * @return $this
      */
     public function addHandle($handle)
     {
         if (is_array($handle)) {
-            foreach ($handle as $h) {
-                $this->_handles[$h] = 1;
+            foreach ($handle as $item) {
+                $this->_handles[$item] = 1;
             }
         } else {
             $this->_handles[$handle] = 1;