Replies: 4 comments 1 reply
-
a PR for 2. would be great, thanks |
Beta Was this translation helpful? Give feedback.
1 reply
-
thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
-
added some tests here 679b496 that also uncovered a minor getter issue, checking the new default OIDC_CONFIG_POS_TIMEOUT_UNSET; these tests should prevent us from breaking your contribution again, apologies for that |
Beta Was this translation helpful? Give feedback.
0 replies
-
Thanks for fixing and letting me know. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
If a ttl value is set via
OIDCMemCacheConnectionsTTL
the value is not taken as seconds but as microseconds. This is because it is missed to convert a given value from seconds to microseconds asapr_memcache_server_create
expects. Due to a design error in the apr-util 1.xapr_memcache_server_create
prototype (it uses anapr_uint32_t
instead of anapr_interval_time_t
) we also need to limit the maximum number of seconds from currently one week to roughly 1 hour and 11 minutes as this is the maximum value in microseconds that fits into anapr_uint32_t
. For solving the missing conversion there are two possible approaches:apr_time_from_sec
to microseconds.ap_timeout_parameter_parse
which also gives more flexibility on specifying sub second timeouts or larger timeouts by adding a unit to the number.I can try to create a PR for 1. or 2. whatever is prefered. My personal preference is 2.
Beta Was this translation helpful? Give feedback.
All reactions