Skip to content
This repository was archived by the owner on Dec 31, 2024. It is now read-only.
This repository was archived by the owner on Dec 31, 2024. It is now read-only.

Support Java Modules #113

@aalmiray

Description

@aalmiray

v3.8.0 defines an automatic module name

$ jarviz module name --file feign-form-3.8.0.jar 
subject: feign-form-3.8.0.jar
name: feign.form
source: filename
automatic: true
valid: true

$ jarviz module descriptor --file feign-form-3.8.0.jar 
subject: feign-form-3.8.0.jar
name: feign.form
version: 3.8.0
open: false
automatic: true
requires:
  java.base mandated
contains:
  feign.form
  feign.form.multipart
  feign.form.util

I'd be great if the library supplied a full Java module descriptor. It's possible to keep bytecode baseline compatible with Java 8 while providing a full module descriptor thanks to ModiTect. This will help modular projects that consume feign-form, specifically those that create custom Java Runtimes with jlink, as the latter does not support automatic modules but explicit modules. If interested I can send a PR to make it happen.

FWIW feign 12.2 added full module descriptors to a set of its Maven modules -> OpenFeign/feign#1357

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions