feat: Add p99 and slow command count #3042

Mixficsol · 2025-03-11T03:31:19Z

P99 命令的统计，每分钟会重置一次

127.0.0.1:9221> info commandp99
# Commands P99
Command: set
TP99 ms: 0.50
TP999 ms: 0.50
TP9999 ms: 0.50
----------------------
Command: config
TP99 ms: 0.50
TP999 ms: 0.50
TP9999 ms: 0.50
----------------------

Slow 慢命令统计, 每分钟会重置一次

127.0.0.1:9221> info slowcommand
# SlowCommand Count
info:slow_count=229
hset:slow_count=72866
config:slow_count=186

coderabbitai · 2025-03-11T03:31:26Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

wangshao1 · 2025-03-12T13:47:12Z

src/pika_client_conn.cc

+  auto end_time = std::chrono::high_resolution_clock::now();

  time_stat_->process_done_ts_ = pstd::NowMicros();
+  std::chrono::duration<double, std::milli> elapsed = end_time - start_time; 


计算慢请求日志的时候，有一个命令处理的总耗时，包括队列排队 + 命令处理 + 写binlog，我理解这个耗时应该是统计这个值。

wangshao1 · 2025-03-12T13:51:13Z

src/pika_client_conn.cc

-void PikaClientConn::ProcessSlowlog(const PikaCmdArgsType& argv, std::shared_ptr<Cmd> c_ptr) {
+void PikaClientConn::ProcessSlowlog(const PikaCmdArgsType& argv, std::shared_ptr<Cmd> c_ptr, std::string opt) {
  if (time_stat_->total_time() > g_pika_conf->slowlog_slower_than()) {
+    auto slow_command_count = g_pika_cmd_table_manager->GetSlowCommandCount();


这里操作slow_command_count是不得加锁？

wangshao1 · 2025-03-14T02:16:10Z

include/pika_cmd_table_manager.h

+  std::shared_mutex histograms_mutex_;
+  std::shared_mutex slow_command_mutex_;
+  std::shared_ptr<prometheus::Registry> prometheus_registry_;
+  prometheus::Family<prometheus::Histogram>* histogram_family_;


historgram_family_，histograms_里的元素这些指针，需要delete吗？

这里的指针是由 prometheus_registry_ 管理的，析构的时候会由 prometheus_registry_ 统一释放

This reverts commit 57585f7.

* Added time statistics for P99 and slow commands --------- Co-authored-by: wuxianrong <wuxianrong@360.cn>

…" (OpenAtomFoundation#3053) This reverts commit 57585f7.

Added time statistics for P99 and slow commands

a45d9f1

github-actions bot added the ✏️ Feature New feature or request label Mar 11, 2025

Added tp99 time consuming and slow command statistics

5dc8448

Mixficsol marked this pull request as ready for review March 12, 2025 08:08

add metric

e65acc3

wangshao1 reviewed Mar 12, 2025

View reviewed changes

review code

e13dd6f

baixin01 approved these changes Mar 13, 2025

View reviewed changes

wangshao1 reviewed Mar 14, 2025

View reviewed changes

Mixficsol merged commit 57585f7 into OpenAtomFoundation:3.5 Mar 14, 2025
16 checks passed

Mixficsol added a commit that referenced this pull request Mar 20, 2025

Revert "feat: Add p99 and slow command count (#3042)"

c5cfd46

This reverts commit 57585f7.

Mixficsol mentioned this pull request Mar 20, 2025

Revert "feat: Add p99 and slow command count" #3053

Merged

Mixficsol added a commit that referenced this pull request Mar 20, 2025

Revert "feat: Add p99 and slow command count (#3042)" (#3053)

05d1c37

This reverts commit 57585f7.

Mixficsol deleted the add_tp99 branch March 27, 2025 02:37

Mixficsol added a commit to Mixficsol/pika that referenced this pull request Apr 1, 2025

feat: Add p99 and slow command count (OpenAtomFoundation#3042)

ef96f3b

* Added time statistics for P99 and slow commands --------- Co-authored-by: wuxianrong <wuxianrong@360.cn>

byseea11 pushed a commit to byseea11/pikiwidb that referenced this pull request Sep 29, 2025

feat: Add p99 and slow command count (OpenAtomFoundation#3042)

274b1b7

* Added time statistics for P99 and slow commands --------- Co-authored-by: wuxianrong <wuxianrong@360.cn>

byseea11 pushed a commit to byseea11/pikiwidb that referenced this pull request Sep 29, 2025

Revert "feat: Add p99 and slow command count (OpenAtomFoundation#3042)…

430ee80

…" (OpenAtomFoundation#3053) This reverts commit 57585f7.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add p99 and slow command count #3042

feat: Add p99 and slow command count #3042

Uh oh!

Mixficsol commented Mar 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 11, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

wangshao1 Mar 12, 2025

Uh oh!

Mixficsol Mar 13, 2025

Uh oh!

wangshao1 Mar 12, 2025

Uh oh!

Mixficsol Mar 13, 2025

Uh oh!

wangshao1 Mar 14, 2025

Uh oh!

Mixficsol Mar 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Add p99 and slow command count #3042

feat: Add p99 and slow command count #3042

Uh oh!

Conversation

Mixficsol commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

wangshao1 Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

Mixficsol Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

wangshao1 Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

Mixficsol Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

wangshao1 Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

Mixficsol Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mixficsol commented Mar 11, 2025 •

edited

Loading

coderabbitai bot commented Mar 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)