feat: summary different stages duration #3036

wangshao1 · 2025-03-04T13:02:16Z

stat different stages cost, including rediscache read/update, write binlog, storage processing time.

coderabbitai · 2025-03-04T13:02:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

baixin01 · 2025-03-05T04:05:39Z

include/pika_conf.h

+  kEnableTime = 5,  // enable count and time stats
+  kOutOfBounds = 6  // N.B. Must always be the last value!
+  */
+  std::atomic_int rocksdb_perf_level_ = 1;


rocksdb_perf_level_设置为1 ，是表示disable perf stats的意思吗？

对，这个地方rocksdb默认值是2，我改回去吧。
kEnableCount是统计了一些步骤上的执行次数，没有掐时间。

rocksdb_perf_level_设置为1 ，是表示disable perf stats的意思吗？

Mixficsol · 2025-03-05T06:25:08Z

src/pika_list.cc


 void LIndexCmd::DoUpdateCache() {
  if (s_.ok()) {
+    STAGE_TIMER_GUARD(cache_duration_ms, true);


这种异步加载cache的命令可以注释一下这里的统计的时间是往队列里面加的时间，不是真正的更新cache的时间

…mFoundation#3036)

* fix: Reduced ReadCache tags for some commands (#3034) * fix: Fixed an issue with asynchronous loading (#3037) * summary different stages duration && add rocksdb perfcontext (#3036) * fix: The number of element updates in RedisCache is configurable (#3043) * The number of element updates in RedisCache is configurable Co-authored-by: wuxianrong <wuxianrong@360.cn> * fix: fix replication on pika node recovering (#3038) * fix: Fix problems found during testing (#3039) * Example Modify the policy for updating big keys except String to Redis-Cache (#3047) Co-authored-by: wuxianrong <wuxianrong@360.cn> * add auth command to admin-thread-pool (#3048) Co-authored-by: wuxianrong <wuxianrong@360.cn> * fix: Example Repair the subjective and objective offline logic of noeds (#3049) * Example Repair the subjective and objective offline logic of primary and secondary nodes * fix comment --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> * fix: Fixed version information for Pika, Pika_exporter, Codis (#3054) * Fixed version information for Pika, Pika_exporter, Codis * Delete redundant logic --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> * fix: Fixed versions of Pika, Pika_exporter, Codis (#3057) * Resolve conflict differences * Resolve conflict differences * Resolve conflict differences * fix string test * change by review --------- Co-authored-by: wangshao1 <30471730+wangshao1@users.noreply.github.com> Co-authored-by: wuxianrong <wuxianrong@360.cn>

* fix: Reduced ReadCache tags for some commands (OpenAtomFoundation#3034) * fix: Fixed an issue with asynchronous loading (OpenAtomFoundation#3037) * summary different stages duration && add rocksdb perfcontext (OpenAtomFoundation#3036) * fix: The number of element updates in RedisCache is configurable (OpenAtomFoundation#3043) * The number of element updates in RedisCache is configurable Co-authored-by: wuxianrong <wuxianrong@360.cn> * fix: fix replication on pika node recovering (OpenAtomFoundation#3038) * fix: Fix problems found during testing (OpenAtomFoundation#3039) * Example Modify the policy for updating big keys except String to Redis-Cache (OpenAtomFoundation#3047) Co-authored-by: wuxianrong <wuxianrong@360.cn> * add auth command to admin-thread-pool (OpenAtomFoundation#3048) Co-authored-by: wuxianrong <wuxianrong@360.cn> * fix: Example Repair the subjective and objective offline logic of noeds (OpenAtomFoundation#3049) * Example Repair the subjective and objective offline logic of primary and secondary nodes * fix comment --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> * fix: Fixed version information for Pika, Pika_exporter, Codis (OpenAtomFoundation#3054) * Fixed version information for Pika, Pika_exporter, Codis * Delete redundant logic --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> * fix: Fixed versions of Pika, Pika_exporter, Codis (OpenAtomFoundation#3057) * Resolve conflict differences * Resolve conflict differences * Resolve conflict differences * fix string test * change by review --------- Co-authored-by: wangshao1 <30471730+wangshao1@users.noreply.github.com> Co-authored-by: wuxianrong <wuxianrong@360.cn>

…mFoundation#3036) Co-authored-by: wangshaoyi <wangshaoyi@360.cn>

github-actions bot added the ✏️ Feature New feature or request label Mar 4, 2025

baixin01 reviewed Mar 5, 2025

View reviewed changes

Mixficsol approved these changes Mar 5, 2025

View reviewed changes

Mixficsol reviewed Mar 5, 2025

View reviewed changes

wangshao1 force-pushed the feature/request_metrics branch from d87b970 to ce829ef Compare March 5, 2025 06:34

summary different stages duration && add rocksdb perfcontext

6aa0e6b

wangshao1 force-pushed the feature/request_metrics branch from 4b5178a to 6aa0e6b Compare March 6, 2025 03:36

wangshao1 merged commit cf92593 into OpenAtomFoundation:3.5 Mar 6, 2025
12 checks passed

Mixficsol pushed a commit to Mixficsol/pika that referenced this pull request Mar 26, 2025

summary different stages duration && add rocksdb perfcontext (OpenAto…

3666554

…mFoundation#3036)

byseea11 pushed a commit to byseea11/pikiwidb that referenced this pull request Sep 29, 2025

summary different stages duration && add rocksdb perfcontext (OpenAto…

6c271c7

…mFoundation#3036) Co-authored-by: wangshaoyi <wangshaoyi@360.cn>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: summary different stages duration #3036

feat: summary different stages duration #3036

Uh oh!

wangshao1 commented Mar 4, 2025

Uh oh!

coderabbitai bot commented Mar 4, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

baixin01 Mar 5, 2025

Uh oh!

wangshao1 Mar 5, 2025

Uh oh!

Mixficsol Mar 5, 2025

Uh oh!

wangshao1 Mar 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: summary different stages duration #3036

feat: summary different stages duration #3036

Uh oh!

Conversation

wangshao1 commented Mar 4, 2025

Uh oh!

coderabbitai bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

baixin01 Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

wangshao1 Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

Mixficsol Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

wangshao1 Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)