Skip to content

Commit c1a689d

Browse files
Review refinements.
- added docs for supported display configurations - removed enforcement for DISPLAY_TYPE_NONE on esp boards
1 parent 0914f2a commit c1a689d

File tree

2 files changed

+20
-17
lines changed

2 files changed

+20
-17
lines changed

Software/Arduino code/OpenAstroTracker/Configuration_adv.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,6 @@
207207
//
208208
// Define some things, dont change: ///
209209
#define ESPBOARD
210-
#undef DISPLAY_TYPE
211-
#define DISPLAY_TYPE DISPLAY_TYPE_NONE
212210
// #define BLUETOOTH_ENABLED
213211
#define WIFI_ENABLED
214212
#if defined(ESP8266)
Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,27 @@
11
#pragma once
22

3-
/*
4-
* This file contains constants that SHOULD NOT BE CHANGED by oat users!
5-
* If you are a developer and want to add new hardware support, add a
6-
* proper definition here with increased value.
7-
*/
3+
/**
4+
* This file contains constants that SHOULD NOT BE CHANGED by oat users!
5+
* If you are a developer and want to add new hardware support, add a
6+
* proper definition here with increased value.
7+
**/
88

9-
// Supported display types
10-
#define DISPLAY_TYPE_NONE 0
11-
#define DISPLAY_TYPE_LCD_KEYPAD 1
9+
/**
10+
* Supported display types. Use one of these values for DISPLAY_TYPE configuration matching your used display.
11+
*
12+
* DISPLAY_TYPE_NONE: No display. Use this if you don't use any display.
13+
* DISPLAY_TYPE_LCD_KEYPAD: 1602 LCD Keypad shield which can be mounted directly to an Arduino UNO / Mega boards.
14+
* Example: https://www.digikey.com/en/products/detail/dfrobot/DFR0009/7597118
15+
**/
16+
#define DISPLAY_TYPE_NONE 0
17+
#define DISPLAY_TYPE_LCD_KEYPAD 1
1218

1319
// Supported stepper models
14-
#define STEPPER_TYPE_28BYJ48 0
15-
#define STEPPER_TYPE_NEMA17 1
20+
#define STEPPER_TYPE_28BYJ48 0
21+
#define STEPPER_TYPE_NEMA17 1
1622

1723
// Supported stepper driver models
18-
#define DRIVER_TYPE_ULN2003 0
19-
#define DRIVER_TYPE_GENERIC 1
20-
#define DRIVER_TYPE_TMC2209_STANDALONE 2
21-
#define DRIVER_TYPE_TMC2209_UART 3
22-
24+
#define DRIVER_TYPE_ULN2003 0
25+
#define DRIVER_TYPE_GENERIC 1
26+
#define DRIVER_TYPE_TMC2209_STANDALONE 2
27+
#define DRIVER_TYPE_TMC2209_UART 3

0 commit comments

Comments
 (0)