V1.6.57 - Updates

- Fixed a bug where negative time was displayed incorrectly.
- Fixed a bug in Set Home that did not account for current RA position.
- Fixed a bug that incorrectly calculated current RA from stepper position.
-  Added some logging for debugging.

Author: ClutchplateDude

Software/Arduino code/OpenAstroTracker/DayTime.cpp

@@ -158,18 +158,23 @@ void DayTime::subtractTime(const DayTime& other)
 char achBuf[32];
 
 // Convert to a standard string (like 14:45:06)
-const char*  DayTime::ToString() const
+const char* DayTime::ToString() const
 {
   char* p = achBuf;
 
-  if (hours < 10) {
+  int absHours = hours < 0 ? -hours : hours;
+  if (hours < 0)
+  {
+    *p++ = '-';
+  }
+  if (absHours < 10) {
     *p++ = '0';
   }
   else {
-    *p++ = '0' + (hours / 10);
+    *p++ = '0' + (absHours / 10);
   }
 
-  *p++ = '0' + (hours % 10);
+  *p++ = '0' + (absHours % 10);
 
   *p++ = ':';
   if (mins < 10) {
@@ -191,7 +196,7 @@ const char*  DayTime::ToString() const
   *p++ = '0' + (secs % 10);
   *p++ = ' ';
   *p++ = '(';
-  strcpy(p, String(this->getTotalHours(), 4).c_str());
+  strcpy(p, String(this->getTotalHours(), 5).c_str());
   strcat(p, ")");
   return achBuf;
 }
@@ -263,7 +268,7 @@ const char* DegreeTime::ToString() const
     *p++ = '0' + (mins / 10);
   }
   *p++ = '0' + (mins % 10);
-  
+
   *p++ = ':';
   if (secs < 10) {
     *p++ = '0';

Software/Arduino code/OpenAstroTracker/Mount.cpp

@@ -392,14 +392,29 @@ DegreeTime& Mount::targetDEC() {
 const DayTime Mount::currentRA() const {
   // How many steps moves the RA ring one sidereal hour along. One sidereal hour moves just shy of 15 degrees
   float stepsPerSiderealHour = _stepsPerRADegree * siderealDegreesInHour;
-  float hourPos = _stepperRA->currentPosition() / stepsPerSiderealHour / 2.0;
+  float hourPos = 2.0 * -_stepperRA->currentPosition() / stepsPerSiderealHour;
+#ifdef DEBUG_MODE
+  logv("CurrentRA: Steps/h    : %s (%d x %s)", String(stepsPerSiderealHour, 2).c_str(), _stepsPerRADegree, String(siderealDegreesInHour, 5).c_str());
+  logv("CurrentRA: RA Steps   : %d", _stepperRA->currentPosition());
+  logv("CurrentRA: POS        : %s", String(hourPos).c_str());
+#endif
   hourPos += _zeroPosRA.getTotalHours();
+#ifdef DEBUG_MODE
+  logv("CurrentRA: ZeroPos    : %s", _zeroPosRA.ToString());
+  logv("CurrentRA: POS (+zp)  : %s", DayTime(hourPos).ToString());
+#endif
   if (_stepperDEC->currentPosition() > 0)
   {
     hourPos += 12;
     if (hourPos > 24) hourPos -= 24;
+#ifdef DEBUG_MODE
+    logv("CurrentRA: RA (+12h): %s", DayTime(hourPos).ToString());
+#endif
   }
 
+#ifdef DEBUG_MODE
+  logv("CurrentRA: RA Pos  -> : %s", DayTime(hourPos).ToString());
+#endif
   return hourPos;
 }
 
@@ -1109,10 +1124,12 @@ void Mount::loop() {
 //
 /////////////////////////////////
 void Mount::setHome() {
+  _zeroPosRA = currentRA();
+
   _stepperRA->setCurrentPosition(0);
   _stepperDEC->setCurrentPosition(0);
   _stepperTRK->setCurrentPosition(0);
-  _zeroPosRA = currentRA();
+
 #ifdef DEBUG_MODE
   logv("Mount::setHome: ZeroPosRA set to %s", _zeroPosRA.ToString());
 #endif

Software/Arduino code/OpenAstroTracker/OpenAstroTracker.ino

@@ -16,7 +16,7 @@
 */
 #include "Globals.h"
 
-String version = "V1.6.56";
+String version = "V1.6.57";
 
 ///////////////////////////////////////////////////////////////////////////
 // Please see the Globals.h file for configuration of the firmware.