Fix php generators treating double as a native type (#13421)

* Fix php generators treating double as a native type

Fixes #13335

* Remove double handling in enum

* Add missed double type removal

Author: neclimdul

docs/generators/php-dt.md

@@ -56,7 +56,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>
-<li>double</li>
 <li>float</li>
 <li>int</li>
 <li>integer</li>

docs/generators/php-laravel.md

@@ -57,7 +57,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>
-<li>double</li>
 <li>float</li>
 <li>int</li>
 <li>integer</li>

docs/generators/php-lumen.md

@@ -57,7 +57,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>
-<li>double</li>
 <li>float</li>
 <li>int</li>
 <li>integer</li>

docs/generators/php-mezzio-ph.md

@@ -56,7 +56,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>
-<li>double</li>
 <li>float</li>
 <li>int</li>
 <li>integer</li>

docs/generators/php-slim-deprecated.md

@@ -57,7 +57,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>
-<li>double</li>
 <li>float</li>
 <li>int</li>
 <li>integer</li>

docs/generators/php-slim4.md

@@ -58,7 +58,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>
-<li>double</li>
 <li>float</li>
 <li>int</li>
 <li>integer</li>

docs/generators/php-symfony.md

@@ -62,7 +62,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 <li>array</li>
 <li>bool</li>
 <li>byte</li>
-<li>double</li>
 <li>float</li>
 <li>int</li>
 <li>mixed</li>

docs/generators/php.md

@@ -58,7 +58,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>
-<li>double</li>
 <li>float</li>
 <li>int</li>
 <li>integer</li>

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPhpCodegen.java

@@ -91,7 +91,6 @@ public AbstractPhpCodegen() {
                         "boolean",
                         "int",
                         "integer",
-                        "double",
                         "float",
                         "string",
                         "object",
@@ -119,7 +118,7 @@ public AbstractPhpCodegen() {
         typeMapping.put("number", "float");
         typeMapping.put("float", "float");
         typeMapping.put("decimal", "float");
-        typeMapping.put("double", "double");
+        typeMapping.put("double", "float");
         typeMapping.put("string", "string");
         typeMapping.put("byte", "int");
         typeMapping.put("boolean", "bool");
@@ -656,7 +655,7 @@ public void setParameterExampleValue(CodegenParameter p) {
 
     @Override
     public String toEnumValue(String value, String datatype) {
-        if ("int".equals(datatype) || "double".equals(datatype) || "float".equals(datatype)) {
+        if ("int".equals(datatype) || "float".equals(datatype)) {
             return value;
         } else {
             return "\'" + escapeText(value) + "\'";
@@ -684,7 +683,7 @@ public String toEnumVarName(String name, String datatype) {
         }
 
         // number
-        if ("int".equals(datatype) || "double".equals(datatype) || "float".equals(datatype)) {
+        if ("int".equals(datatype) || "float".equals(datatype)) {
             String varName = name;
             varName = varName.replaceAll("-", "MINUS_");
             varName = varName.replaceAll("\\+", "PLUS_");

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpDataTransferClientCodegen.java

@@ -92,9 +92,6 @@ public PhpDataTransferClientCodegen() {
                 .stability(Stability.BETA)
                 .build();
 
-        //no point to use double - http://php.net/manual/en/language.types.float.php , especially because of PHP 7+ float type declaration
-        typeMapping.put("double", "float");
-
         // remove these from primitive types to make the output works
         languageSpecificPrimitives.remove("\\DateTime");
         languageSpecificPrimitives.remove("\\SplFileObject");