Skip to content

Commit a6cfef5

Browse files
authored
clean up kotlin spring samples (#20445)
* clean up samples * use 3.0 petstore test spec * update samples * better code format
1 parent 358e8af commit a6cfef5

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+250
-3113
lines changed

.github/workflows/samples-kotlin-server.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ jobs:
3434
- samples/server/petstore/kotlin-springboot-delegate
3535
- samples/server/petstore/kotlin-springboot-modelMutable
3636
- samples/server/petstore/kotlin-springboot-reactive
37-
- samples/server/petstore/kotlin-springboot-reactive-with-flow
3837
- samples/server/petstore/kotlin-springboot-reactive-without-flow
3938
- samples/server/petstore/kotlin-springboot-source-swagger1
4039
- samples/server/petstore/kotlin-springboot-source-swagger2

bin/configs/kotlin-spring-boot-reactive-with-flow.yaml

Lines changed: 0 additions & 13 deletions
This file was deleted.
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
generatorName: kotlin-spring
22
outputDir: samples/server/petstore/kotlin-springboot-reactive
33
library: spring-boot
4-
inputSpec: modules/openapi-generator/src/test/resources/2_0/petstore.yaml
4+
inputSpec: modules/openapi-generator/src/test/resources/3_0/petstore.yaml
55
templateDir: modules/openapi-generator/src/main/resources/kotlin-spring
66
additionalProperties:
77
documentationProvider: springdoc
@@ -10,3 +10,5 @@ additionalProperties:
1010
serviceImplementation: "true"
1111
reactive: "true"
1212
beanValidations: "true"
13+
# the following option is set to true by default
14+
#useFlowForArrayReturnType: "true"

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,26 +40,34 @@ public class KotlinServerCodegen extends AbstractKotlinCodegen implements BeanVa
4040
public static final String DEFAULT_LIBRARY = Constants.KTOR;
4141
private final Logger LOGGER = LoggerFactory.getLogger(KotlinServerCodegen.class);
4242

43-
@Getter @Setter
43+
@Getter
44+
@Setter
4445
private Boolean autoHeadFeatureEnabled = true;
45-
@Getter @Setter
46+
@Getter
47+
@Setter
4648
private Boolean conditionalHeadersFeatureEnabled = false;
47-
@Getter @Setter
49+
@Getter
50+
@Setter
4851
private Boolean hstsFeatureEnabled = true;
49-
@Getter @Setter
52+
@Getter
53+
@Setter
5054
private Boolean corsFeatureEnabled = false;
51-
@Getter @Setter
55+
@Getter
56+
@Setter
5257
private Boolean compressionFeatureEnabled = true;
53-
@Getter @Setter
58+
@Getter
59+
@Setter
5460
private Boolean resourcesFeatureEnabled = true;
55-
@Getter @Setter
61+
@Getter
62+
@Setter
5663
private Boolean metricsFeatureEnabled = true;
5764
private boolean interfaceOnly = false;
5865
private boolean useBeanValidation = false;
5966
private boolean useCoroutines = false;
6067
private boolean useMutiny = false;
6168
private boolean returnResponse = false;
62-
@Setter private boolean omitGradleWrapper = false;
69+
@Setter
70+
private boolean omitGradleWrapper = false;
6371

6472
// This is here to potentially warn the user when an option is not supported by the target framework.
6573
private Map<String, List<String>> optionsSupportedPerFramework = new ImmutableMap.Builder<String, List<String>>()

modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -924,12 +924,12 @@ public void reactiveWithoutFlow() throws Exception {
924924
codegen.additionalProperties().put(KotlinSpringServerCodegen.DELEGATE_PATTERN, true);
925925

926926
List<File> files = new DefaultGenerator()
927-
.opts(
928-
new ClientOptInput()
929-
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
930-
.config(codegen)
931-
)
932-
.generate();
927+
.opts(
928+
new ClientOptInput()
929+
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
930+
.config(codegen)
931+
)
932+
.generate();
933933

934934
Assertions.assertThat(files).contains(
935935
new File(output, "src/main/kotlin/org/openapitools/api/TestV1Api.kt"),
@@ -969,12 +969,12 @@ public void reactiveWithFlow() throws Exception {
969969
codegen.additionalProperties().put(KotlinSpringServerCodegen.DELEGATE_PATTERN, true);
970970

971971
List<File> files = new DefaultGenerator()
972-
.opts(
973-
new ClientOptInput()
974-
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
975-
.config(codegen)
976-
)
977-
.generate();
972+
.opts(
973+
new ClientOptInput()
974+
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
975+
.config(codegen)
976+
)
977+
.generate();
978978

979979
Assertions.assertThat(files).contains(
980980
new File(output, "src/main/kotlin/org/openapitools/api/TestV1Api.kt"),
@@ -1015,12 +1015,12 @@ public void reactiveWithDefaultValueFlow() throws Exception {
10151015
codegen.additionalProperties().put(KotlinSpringServerCodegen.DELEGATE_PATTERN, true);
10161016

10171017
List<File> files = new DefaultGenerator()
1018-
.opts(
1019-
new ClientOptInput()
1020-
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
1021-
.config(codegen)
1022-
)
1023-
.generate();
1018+
.opts(
1019+
new ClientOptInput()
1020+
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
1021+
.config(codegen)
1022+
)
1023+
.generate();
10241024

10251025
Assertions.assertThat(files).contains(
10261026
new File(output, "src/main/kotlin/org/openapitools/api/TestV1Api.kt"),
@@ -1060,12 +1060,12 @@ public void nonReactiveWithoutFlow() throws Exception {
10601060
codegen.additionalProperties().put(KotlinSpringServerCodegen.DELEGATE_PATTERN, true);
10611061

10621062
List<File> files = new DefaultGenerator()
1063-
.opts(
1064-
new ClientOptInput()
1065-
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
1066-
.config(codegen)
1067-
)
1068-
.generate();
1063+
.opts(
1064+
new ClientOptInput()
1065+
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
1066+
.config(codegen)
1067+
)
1068+
.generate();
10691069

10701070
Assertions.assertThat(files).contains(
10711071
new File(output, "src/main/kotlin/org/openapitools/api/TestV1Api.kt"),
@@ -1105,12 +1105,12 @@ public void nonReactiveWithFlow() throws Exception {
11051105
codegen.additionalProperties().put(KotlinSpringServerCodegen.DELEGATE_PATTERN, true);
11061106

11071107
List<File> files = new DefaultGenerator()
1108-
.opts(
1109-
new ClientOptInput()
1110-
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
1111-
.config(codegen)
1112-
)
1113-
.generate();
1108+
.opts(
1109+
new ClientOptInput()
1110+
.openAPI(TestUtils.parseSpec("src/test/resources/3_0/kotlin/issue16130-add-useFlowForArrayReturnType-param.yaml"))
1111+
.config(codegen)
1112+
)
1113+
.generate();
11141114

11151115
Assertions.assertThat(files).contains(
11161116
new File(output, "src/main/kotlin/org/openapitools/api/TestV1Api.kt"),

samples/server/petstore/kotlin-springboot-reactive-with-flow/.openapi-generator-ignore

Lines changed: 0 additions & 23 deletions
This file was deleted.

samples/server/petstore/kotlin-springboot-reactive-with-flow/.openapi-generator/FILES

Lines changed: 0 additions & 28 deletions
This file was deleted.

samples/server/petstore/kotlin-springboot-reactive-with-flow/.openapi-generator/VERSION

Lines changed: 0 additions & 1 deletion
This file was deleted.

samples/server/petstore/kotlin-springboot-reactive-with-flow/README.md

Lines changed: 0 additions & 21 deletions
This file was deleted.

samples/server/petstore/kotlin-springboot-reactive-with-flow/build.gradle.kts

Lines changed: 0 additions & 53 deletions
This file was deleted.

0 commit comments

Comments
 (0)