False positive diff for array with maxItems fix

DrSatyr · web-flow · commit 702673ef826d · 2025-05-13T21:30:18.000+02:00
diff --git a/core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMaxItems.java b/core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMaxItems.java
@@ -17,7 +17,7 @@ public ChangedMaxItems(Integer oldValue, Integer newValue, DiffContext context)
 
   @Override
   public DiffResult isChanged() {
-    if (oldValue == newValue) {
+    if (Objects.equals(oldValue == newValue)) {
       return DiffResult.NO_CHANGES;
     }
     if (oldValue == null || newValue == null) {
diff --git a/core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMinItems.java b/core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMinItems.java
@@ -17,7 +17,7 @@ public ChangedMinItems(Integer oldValue, Integer newValue, DiffContext context)
 
   @Override
   public DiffResult isChanged() {
-    if (oldValue == newValue) {
+    if (Objects.equals(oldValue, newValue)) {
       return DiffResult.NO_CHANGES;
     }
     if (oldValue == null || newValue == null) {

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ public ChangedMaxItems(Integer oldValue, Integer newValue, DiffContext context)`
`17`	`17`
`18`	`18`	`@Override`
`19`	`19`	`public DiffResult isChanged() {`
`20`		`- if (oldValue == newValue) {`
	`20`	`+ if (Objects.equals(oldValue == newValue)) {`
`21`	`21`	`return DiffResult.NO_CHANGES;`
`22`	`22`	`}`
`23`	`23`	`if (oldValue == null \|\| newValue == null) {`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ public ChangedMinItems(Integer oldValue, Integer newValue, DiffContext context)`
`17`	`17`
`18`	`18`	`@Override`
`19`	`19`	`public DiffResult isChanged() {`
`20`		`- if (oldValue == newValue) {`
	`20`	`+ if (Objects.equals(oldValue, newValue)) {`
`21`	`21`	`return DiffResult.NO_CHANGES;`
`22`	`22`	`}`
`23`	`23`	`if (oldValue == null \|\| newValue == null) {`