Skip to content

Commit ebae1f8

Browse files
committed
Fixed LED blink bug
1 parent d3d4085 commit ebae1f8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

XRPLib/board.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def led_blink(self, frequency: int=0):
9595
self._virt_timer.deinit()
9696
# We set it to twice in input frequency so that
9797
# the led flashes on and off frequency times per second
98-
if frequency == 0:
98+
if frequency != 0:
9999
self._virt_timer.init(freq=frequency*2, mode=Timer.PERIODIC,
100100
callback=lambda t:self.led.toggle())
101101
self.is_led_blinking = True

XRPLib/differential_drive.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ def turn(self, turn_degrees: float, max_effort: float = 0.5, timeout: float = No
250250
# Secondary controller to keep encoder values in sync
251251
if secondary_controller is None:
252252
secondary_controller = PID(
253-
kp = 1.0,
253+
kp = 0.8,
254254
)
255255

256256
if use_imu and (self.imu is not None):

0 commit comments

Comments
 (0)