Skip to content

Commit 945c642

Browse files
committed
- prefix user uploaded image with _hidden_image
- fix img url - add base url if it doesn't already have it - revert modifier display for now - fix cover page creation putting in 2 in doc
1 parent 5c9c167 commit 945c642

File tree

5 files changed

+20
-12
lines changed

5 files changed

+20
-12
lines changed

app/js/mms/app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ angular.module('mmsApp', ['mms', 'mms.directives', 'app.tpls', 'fa.directive.bor
422422
},{
423423
viewName: projectOb.name + ' Cover Page',
424424
viewId: eid
425-
}, 2).then(function(data) {
425+
}).then(function(data) {
426426
deferred.resolve(data);
427427
}, function(reason2) {
428428
deferred.resolve(null);

src/directives/Utils.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,9 @@ function Utils($q, $uibModal, $timeout, $templateCache, $compile, $window, URLSe
973973
var fixImgSrc = function(imgDom) {
974974
var src = imgDom.attr('src');
975975
if (src) {
976+
if (src.indexOf('http') < 0) {
977+
src = URLService.getRoot() + src;
978+
}
976979
imgDom.attr('src', src + '?token=' + AuthService.getToken());
977980
}
978981
if (imgDom.width() < 860) { //keep image relative centered with text if less than 9 in

src/directives/mmsCkEditor.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ function mmsCkeditor($uibModal, $templateCache, $timeout, growl, CKEDITOR, _, Ca
504504
var formData = new FormData();
505505
var xhr = fileLoader.xhr;
506506

507-
xhr.open( 'POST', URLService.getPutArtifactsURL({projectId: scope.mmsProjectId, refId: scope.mmsRefId, elementId: UtilsService.createMmsId().replace('MMS', 'VE')}), true );
507+
xhr.open( 'POST', URLService.getPutArtifactsURL({projectId: scope.mmsProjectId, refId: scope.mmsRefId, elementId: UtilsService.createMmsId().replace('MMS', '_hidden_image')}), true );
508508
//xhr.withCredentials = true;
509509
xhr.setRequestHeader('Authorization', URLService.getAuthorizationHeaderValue());
510510
formData.append('file', fileLoader.file, fileLoader.fileName );

src/directives/mmsSpec.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,12 @@ function mmsSpec(Utils, URLService, AuthService, ElementService, UtilsService, V
9696
};
9797

9898
var getModifier = function(modifier) {
99-
AuthService.getUserData(modifier).then(function(modifierData){
99+
return modifier;
100+
/*AuthService.getUserData(modifier).then(function(modifierData){
100101
return modifierData.users[0];
101102
}, function() {
102103
return modifier;
103-
});
104+
});*/
104105
};
105106

106107
if (scope.mmsElement) {
@@ -154,11 +155,12 @@ function mmsSpec(Utils, URLService, AuthService, ElementService, UtilsService, V
154155
return;
155156
}
156157
scope.element = data;
157-
AuthService.getUserData(data._modifier).then(function(modifierData){
158+
scope.modifier = data._modifier;
159+
/*AuthService.getUserData(data._modifier).then(function(modifierData){
158160
scope.modifier = modifierData.users[0];
159161
}, function() {
160162
scope.modifier = data._modifier;
161-
});
163+
});*/
162164
Utils.setupValCf(scope);
163165
if (!scope.mmsCommitId || scope.mmsCommitId === 'latest') {
164166
ElementService.search(reqOb, {

src/directives/mmsView.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,12 @@ function mmsView(Utils, AuthService, ViewService, ElementService, $templateCache
106106
if (elem._modified > $scope.modified && type !== 'Comment') {
107107
$scope.modified = elem._modified;
108108
if (elem._modifier) {
109-
AuthService.getUserData(elem._modifier).then(function(modifierData){
109+
$scope.modifier = elem._modifier;
110+
/*AuthService.getUserData(elem._modifier).then(function(modifierData){
110111
$scope.modifier = modifierData.users[0];
111112
}, function() {
112113
$scope.modifier = elem._modifier;
113-
});
114+
});*/
114115
}
115116
}
116117
if ($scope.mmsViewApi && $scope.mmsViewApi.elementTranscluded)
@@ -187,22 +188,24 @@ function mmsView(Utils, AuthService, ViewService, ElementService, $templateCache
187188
//getting cached individual elements should be faster
188189
scope.view = data;
189190
scope.modified = data._modified;
190-
AuthService.getUserData(data._modifier).then(function(modifierData){
191+
scope.modifier = data._modifier;
192+
/*AuthService.getUserData(data._modifier).then(function(modifierData){
191193
scope.modifier = modifierData.users[0];
192194
}, function() {
193195
scope.modifier = data._modifier;
194-
});
196+
});*/
195197
return;
196198
}
197199
ViewService.getViewElements(reqOb, 1)
198200
.finally(function() {
199201
scope.view = data;
200202
scope.modified = data._modified;
201-
AuthService.getUserData(data._modifier).then(function(modifierData){
203+
scope.modifier = data._modifier;
204+
/*AuthService.getUserData(data._modifier).then(function(modifierData){
202205
scope.modifier = modifierData.users[0];
203206
}, function() {
204207
scope.modifier = data._modifier;
205-
});
208+
});*/
206209
element.removeClass('isLoading');
207210
});
208211
}, function(reason) {

0 commit comments

Comments
 (0)