fix: invalid return in revoke function (#132)

superical · web-flow · commit ac5b71f2af9c · 2023-01-04T15:57:15.000+08:00
diff --git a/contracts/BaseDocumentStore.sol b/contracts/BaseDocumentStore.sol
@@ -48,6 +48,8 @@ contract BaseDocumentStore is Initializable {
   function _revoke(bytes32 document) internal onlyNotRevoked(document) returns (bool) {
     documentRevoked[document] = block.number;
     emit DocumentRevoked(document);
+
+    return true;
   }
 
   function _bulkRevoke(bytes32[] memory documents) internal {
diff --git a/contracts/DocumentStoreWithRevokeReasons.sol b/contracts/DocumentStoreWithRevokeReasons.sol
@@ -21,6 +21,8 @@ contract DocumentStoreWithRevokeReasons is DocumentStore {
     revoke(document);
     revokeReason[document] = reason;
     emit DocumentRevokedWithReason(document, reason);
+
+    return true;
   }
 
   function bulkRevoke(bytes32[] memory documents, uint256 reason) public {

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,8 @@ contract BaseDocumentStore is Initializable {`
`48`	`48`	`function _revoke(bytes32 document) internal onlyNotRevoked(document) returns (bool) {`
`49`	`49`	`documentRevoked[document] = block.number;`
`50`	`50`	`emit DocumentRevoked(document);`
	`51`	`+`
	`52`	`+ return true;`
`51`	`53`	`}`
`52`	`54`
`53`	`55`	`function _bulkRevoke(bytes32[] memory documents) internal {`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@ contract DocumentStoreWithRevokeReasons is DocumentStore {`
`21`	`21`	`revoke(document);`
`22`	`22`	`revokeReason[document] = reason;`
`23`	`23`	`emit DocumentRevokedWithReason(document, reason);`
	`24`	`+`
	`25`	`+ return true;`
`24`	`26`	`}`
`25`	`27`
`26`	`28`	`function bulkRevoke(bytes32[] memory documents, uint256 reason) public {`