miyoogamelist_gen.sh misplaces miyoogamelist.xml and fails to match Skraper’s image folder structure for SCUMMVM #1816
Description
Checklist
- I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
- I have reviewed the Onion Docs and did not find the answer
- I have searched the existing (open and closed) issues to ensure I do not log a duplicate
Onions OS Version
Latest beta
Miyoo Firmware Version
202306282128
Provide a clear and concise description of the issue
Noticed an issue with how miyoogamelist_gen.sh handles SCUMMVM ROMs, particularly when using Skraper to scrape metadata and images.
Skraper assumes the ROM structure is preserved during scraping. For example, if I scrape /mnt/SDCARD/Roms/SCUMMVM/, it’ll generate images for games inside Shortcuts in /mnt/SDCARD/Roms/SCUMMVM/Imgs/Shortcuts.
However, the script does two things that break compatibility with this:
- It writes miyoogamelist.xml inside the Shortcuts/ subdir, even though the SCUMMVM emulator config (
/mnt/SDCARDS/Emu/SCUMMVM/config.json) wants the file in the top-level SCUMMVM/ directory. - It expects scraped images to live in
/mnt/SDCARDS/Roms/SCUMMVM/Imgs, but Skraper puts them in/mnt/SDCARDS/Roms/SCUMMVM/Imgs/Shortcuts.
This seems like a mismatch between Skraper’s output and how the script processes the folder structure.
I’m happy to help contribute a fix, but would appreciate input on preferred direction:
- Should the script be modified to flatten the structure and relocate images/XML?
- Or should we update the script to be subdirectory-aware and align with Skraper’s folder layout?
Let me know how you’d like to approach this and I’ll take a stab at a PR.
Steps to Reproduce
Follow the docs on how to scrape cover art for games with Skraper, and make sure that you add target to the list of extensions.
Provide any additional context or information that may help us investigate your issue
/mnt/SDCARD/Roms/SCUMMVM # ls -la Shortcuts/
total 544
drwxrwxrwx 2 root root 32768 May 17 01:08 .
drwxrwxrwx 16 root root 32768 May 16 18:22 ..
-rwxrwxrwx 1 root root 4 May 15 19:50 Beneath a Steel Sky.target
-rwxrwxrwx 1 root root 9 May 15 19:50 Day of the Tentacle.target
-rwxrwxrwx 1 root root 3 May 15 19:50 Full Throttle.target
-rwxrwxrwx 1 root root 9 May 15 19:50 Indiana Jones and the Fate of Atlantis.target
-rwxrwxrwx 1 root root 9 May 15 19:50 Loom.target
-rwxrwxrwx 1 root root 10 May 15 19:50 Maniac Mansion.target
-rwxrwxrwx 1 root root 8 May 15 19:50 Monkey Island 2 - LeChuck's Revenge.target
-rwxrwxrwx 1 root root 8 May 15 19:50 Sam Max Hit the Road.target
-rwxrwxrwx 1 root root 12288 May 17 01:08 Shortcuts_cache6.db
-rwxrwxrwx 1 root root 4 May 15 19:50 The Dig.target
-rwxrwxrwx 1 root root 9 May 15 19:50 The Legend of Kyrandia.target
-rwxrwxrwx 1 root root 11 May 15 19:50 The Secret of Monkey Island.target
-rwxrwxrwx 1 root root 7 May 15 19:50 Zak McKracken and the Alien Mindbenders.target
-rwxrwxrwx 1 root root 2535 May 17 01:06 miyoogamelist.xml
-rwxrwxrwx 1 root root 58 Jan 1 1980 ~Import games.miyoocmd
/mnt/SDCARD/Roms/SCUMMVM # cat ../../Emu/SCUMMVM/config.json
{
"label": "ScummVM",
"icon": "/mnt/SDCARD/Themes/TechDweeb by TechDweeb/icons/scummvm.png",
"launch": "launch.sh",
"rompath": "../../Roms/SCUMMVM/Shortcuts",
"imgpath": "../../Roms/SCUMMVM/Imgs",
"gamelist": "../../Roms/SCUMMVM/miyoogamelist.xml",
"useswap": 1,
"shortname": 0,
"hidebios": 0,
"extlist": "scummvm|target|miyoocmd"
}