Skip to content

[Bug]: PlayerNotificationTargetIncludeAliases Not up to date #42

@Luuckyy

Description

@Luuckyy

What happened?

The implementation of include_aliases isn't done as it should be, as stated in the documentation we should be able to use any alias or the standards, onesignal_id or external_id. Right now it is set to alias_label which is a set label you would need to use in onesignal.
See include_aliases usage

Steps to reproduce?

1. Install gem with readme.md
2. Initialize config in config.file (would likely be in config/initializers/one_signal.rb)
3. try to send a notification using include_aliases and the key onesignal_id

What did you expect to happen?

I expected to use this
included_aliases = OneSignal::PlayerNotificationTargetIncludeAliases.new( onesignal_id: ['1'] )
which would have created a notification sent to the users with the onesignal_id '1'

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions