Skip to content

Commit 3b399a3

Browse files
authored
Merge pull request #14 from OneSignal/api
Dependency Update
2 parents 91e34a3 + 3c88c84 commit 3b399a3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+4043
-1892
lines changed
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
name: 🙋‍♂️ Ask a question
2+
description: Tell us what's on your mind
3+
title: "[question]: "
4+
labels: ["triage"]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Having issues integrating this API library?
10+
- type: textarea
11+
id: question
12+
attributes:
13+
label: How can we help?
14+
description: Specific question regarding integrating this API library.
15+
placeholder: How do I...?
16+
validations:
17+
required: true
18+
- type: checkboxes
19+
id: terms
20+
attributes:
21+
label: Code of Conduct
22+
description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/OneSignal/api/blob/main/CONTRIBUTING.md)
23+
options:
24+
- label: I agree to follow this project's Code of Conduct
25+
required: true

.github/ISSUE_TEMPLATE/bug-report.yml

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
name: 🪳 Bug report
2+
description: File a bug report
3+
title: "[Bug]: "
4+
labels: ["bug", "triage"]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Thanks for taking the time to fill out this bug report!
10+
- type: textarea
11+
id: what-happened
12+
attributes:
13+
label: What happened?
14+
description: Provide a thorough description of whats going on.
15+
placeholder: The latest version of the API library throws an exception when creating a notification targetting all Active Users.
16+
validations:
17+
required: true
18+
- type: textarea
19+
id: reproduction-steps
20+
attributes:
21+
label: Steps to reproduce?
22+
description: Provide as much detail as posible to reproduce the issue.
23+
placeholder: |
24+
1. Install vX.Y.Z of dependency
25+
2. Run provided code snippet
26+
3. Note that the app crashes
27+
render: Markdown
28+
validations:
29+
required: true
30+
- type: textarea
31+
id: what-are-expectations
32+
attributes:
33+
label: What did you expect to happen?
34+
description: Also tell us, what did you expect to happen?
35+
placeholder: I expected the API library to properly deserialize any response returned by OneSignal.
36+
validations:
37+
required: true
38+
- type: textarea
39+
id: logs
40+
attributes:
41+
label: Relevant log output
42+
description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
43+
render: Shell
44+
- type: checkboxes
45+
id: terms
46+
attributes:
47+
label: Code of Conduct
48+
description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/OneSignal/api/blob/main/CONTRIBUTING.md)
49+
options:
50+
- label: I agree to follow this project's Code of Conduct
51+
required: true
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
name: 📣 General feedback
2+
description: Tell us what's on your mind
3+
title: "[Bug]: "
4+
labels: ["triage"]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Thanks for sharing your valuable feedback!
10+
- type: textarea
11+
id: feedback
12+
attributes:
13+
label: What's on your mind?
14+
description: Feedback regarding this API library.
15+
placeholder: Share your feedback...
16+
validations:
17+
required: true
18+
- type: checkboxes
19+
id: terms
20+
attributes:
21+
label: Code of Conduct
22+
description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/OneSignal/api/blob/main/CONTRIBUTING.md)
23+
options:
24+
- label: I agree to follow this project's Code of Conduct
25+
required: true
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
<!-- START -->
2+
# READ AND DELETE THIS SECTION BEFORE SUBMITTING PR
3+
* **Fill out each _REQUIRED_ section**
4+
* **Fill out _OPTIONAL_ sections, remove section if it doesn't apply to your PR**
5+
* **Read and fill out each of the checklists below**
6+
* **Remove this section after reading**
7+
<!-- END -->
8+
9+
# Description
10+
## One Line Summary
11+
**REQUIRED** - Very short description that summaries the changes in this PR.
12+
13+
## Details
14+
15+
### Motivation
16+
**REQUIRED -** Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X.
17+
18+
### Scope
19+
**RECOMMEND - OPTIONAL -** What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.
20+
21+
### OPTIONAL - Other
22+
**OPTIONAL -** Feel free to add any other sections or sub-sections that can explain your PR better.
23+
24+
# Testing
25+
26+
## Manual testing
27+
**REQUIRED -** Explain what scenarios were tested and the environment.
28+
29+
30+
# Checklist
31+
## Overview
32+
- [ ] I have filled out all **REQUIRED** sections above
33+
- [ ] PR does one thing
34+
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
35+
- [ ] Any Public API changes are explained in the PR details and conform to existing APIs
36+
37+
## Testing
38+
- [ ] I have personally tested this on my device, or explained why that is not possible
39+
40+
## Final pass
41+
- [ ] Code is as readable as possible.
42+
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
43+
- [ ] I have reviewed this PR myself, ensuring it meets each checklist item
44+
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

.gitignore

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,2 @@
1-
node_modules
2-
build
31
dist
4-
npm-debug.log
5-
.env
6-
.DS_Store
2+
node_modules

.npmignore

Whitespace-only changes.

CHANGELOG.md

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)