Skip to content

Commit de555db

Browse files
committed
Cleaning up old iOS categories and various fixes
1 parent 426406d commit de555db

File tree

6 files changed

+10
-28
lines changed

6 files changed

+10
-28
lines changed

ios/Classes/OSFlutterCategories.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,20 @@
4747
- (NSDictionary *)toJson;
4848
@end
4949

50-
@interface OSNotificationOpenedResult (Flutter)
50+
@interface OSInAppMessage (Flutter)
5151
- (NSDictionary *)toJson;
5252
@end
5353

54-
@interface OSInAppMessageAction (Flutter)
55-
- (NSDictionary *)toJson;
54+
@interface NSError (Flutter)
55+
- (FlutterError *)flutterError;
5656
@end
5757

58-
@interface OSInAppMessage (Flutter)
58+
@interface OSInAppMessageWillDisplayEvent (Flutter)
5959
- (NSDictionary *)toJson;
6060
@end
6161

62-
@interface NSError (Flutter)
63-
- (FlutterError *)flutterError;
62+
@interface OSInAppMessageDidDisplayEvent (Flutter)
63+
- (NSDictionary *)toJson;
6464
@end
6565

6666
@interface OSInAppMessageWillDismissEvent (Flutter)

ios/Classes/OSFlutterCategories.m

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -73,17 +73,6 @@ - (NSDictionary *)toJson {
7373
}
7474
@end
7575

76-
@implementation OSNotificationOpenedResult (Flutter)
77-
- (NSDictionary *)toJson {
78-
NSMutableDictionary *json = [NSMutableDictionary new];
79-
80-
if (self.notification) json[@"notification"] = self.notification.toJson;
81-
if (self.action.actionId) json[@"action"] = @{@"type" : @((int)self.action.type), @"id" : self.action.actionId};
82-
83-
return json;
84-
}
85-
@end
86-
8776
@implementation OSNotificationClickEvent (Flutter)
8877
- (NSDictionary *)toJson {
8978
NSMutableDictionary *json = [NSMutableDictionary new];

ios/Classes/OSFlutterInAppMessages.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,4 @@
3535
@property (strong, nonatomic) FlutterMethodChannel *channel;
3636
+ (instancetype)sharedInstance;
3737

38-
@property (atomic) BOOL hasSetInAppMessageClickedHandler;
39-
/*
40-
Holds reference to any in app messages received before any click action
41-
occurs on the body, button or image elements of the in app message
42-
*/
43-
@property (strong, nonatomic) OSInAppMessageAction *inAppMessageClickedResult;
44-
4538
@end

ios/Classes/OSFlutterInAppMessages.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ - (void)paused:(FlutterMethodCall *)call withResult:(FlutterResult)result {
101101
}
102102

103103
- (void)lifecycleInit:(FlutterMethodCall *)call withResult:(FlutterResult)result {
104-
[OneSignal.InAppMessages addClickListener:OSFlutterInAppMessages.sharedInstance]
104+
[OneSignal.InAppMessages addClickListener:OSFlutterInAppMessages.sharedInstance];
105105
[OneSignal.InAppMessages addLifecycleListener:OSFlutterInAppMessages.sharedInstance];
106106
}
107107

ios/Classes/OSFlutterLiveActivities.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ - (void)enterLiveActivity:(FlutterMethodCall *)call withResult:(FlutterResult)re
5353
NSString *activityId = call.arguments[@"activityId"];
5454
NSString *token = call.arguments[@"token"];
5555

56-
[OneSignal enterLiveActivity:activityId withToken:token withSuccess:^(NSDictionary *results) {
56+
[OneSignal.LiveActivities enter:activityId withToken:token withSuccess:^(NSDictionary *results) {
5757
result(results);
5858
} withFailure:^(NSError *error) {
5959
result(error.flutterError);
@@ -63,7 +63,7 @@ - (void)enterLiveActivity:(FlutterMethodCall *)call withResult:(FlutterResult)re
6363
- (void)exitLiveActivity:(FlutterMethodCall *)call withResult:(FlutterResult)result {
6464
NSString *activityId = call.arguments[@"activityId"];
6565

66-
[OneSignal exitLiveActivity:activityId withSuccess:^(NSDictionary *results) {
66+
[OneSignal.LiveActivities exit:activityId withSuccess:^(NSDictionary *results) {
6767
result(results);
6868
} withFailure:^(NSError *error) {
6969
result(error.flutterError);

ios/Classes/OSFlutterNotifications.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ - (void)registerForProvisionalAuthorization:(FlutterMethodCall *)call withResult
9999
}
100100

101101
- (void)lifecycleInit:(FlutterMethodCall *)call withResult:(FlutterResult)result {
102-
[OneSignal.Notifications addLifecycleListener:self];
102+
[OneSignal.Notifications addForegroundLifecycleListener:self];
103103
[OneSignal.Notifications addClickListener:self];
104104
[OneSignal.Notifications addPermissionObserver:self];
105105
result(nil);

0 commit comments

Comments
 (0)