rename notification permission change event

fix

Author: emawby

android/src/main/java/com/onesignal/flutter/OneSignalNotifications.java

@@ -37,7 +37,7 @@
 import io.flutter.plugin.common.PluginRegistry;
 import io.flutter.plugin.common.PluginRegistry.Registrar;
 
-public class OneSignalNotifications extends FlutterRegistrarResponder implements MethodCallHandler, INotificationClickHandler, INotificationWillShowInForegroundHandler, IPermissionChangedHandler {
+public class OneSignalNotifications extends FlutterRegistrarResponder implements MethodCallHandler, INotificationClickHandler, INotificationWillShowInForegroundHandler, IPermissionObserver {
     private boolean hasSetNotificationWillShowInForegroundHandler = false;
     private final HashMap<String, INotificationReceivedEvent> notificationReceivedEventCache = new HashMap<>();
 
@@ -184,8 +184,8 @@ public void notificationWillShowInForeground(INotificationReceivedEvent notifica
     }
 
     @Override
-    public void onPermissionChanged(boolean permission)  { 
-        invokeMethodOnUiThread("OneSignal#OSPermissionChanged", OneSignalSerializer.convertPermissionChanged(permission));
+    public void onNotificationPermissionChange(boolean permission)  { 
+        invokeMethodOnUiThread("OneSignal#onNotificationPermissionDidChange", permission);
     }
 
     private void lifecycleInit() {

android/src/main/java/com/onesignal/flutter/OneSignalSerializer.java

@@ -101,15 +101,6 @@ private static HashMap<String, Object> convertNotificationActionToMap(INotificat
         return hash;
     }
 
-    static HashMap<String, Object> convertPermissionChanged(boolean state) {
-        HashMap<String, Object> permission = new HashMap<>();
-
-        permission.put("permission", state);
-
-        return permission;
-    }
-
-
     static HashMap<String, Object> convertInAppMessageClickedActionToMap(IInAppMessageClickResult result) {
         HashMap<String, Object> hash = new HashMap<>();
 

example/lib/main.dart

@@ -21,7 +21,7 @@ class _MyAppState extends State<MyApp>
   bool _enableConsentButton = false;
 
   // CHANGE THIS parameter to true if you want to test GDPR privacy consent
-  bool _requireConsent = true;
+  bool _requireConsent = false;
 
   @override
   void initState() {
@@ -111,7 +111,7 @@ class _MyAppState extends State<MyApp>
     oneSignalOutcomeExamples();
   }
 
-  void onOSPermissionChanged(bool state) {
+  void onNotificationPermissionDidChange(bool state) {
     print("Has permission " + state.toString());
   }
 

ios/Classes/OSFlutterNotifications.h

@@ -30,7 +30,7 @@
 #import <Flutter/Flutter.h>
 #import <OneSignalNotifications/OneSignalNotifications.h>
 
-@interface OSFlutterNotifications : NSObject<FlutterPlugin, OSPermissionObserver>
+@interface OSFlutterNotifications : NSObject<FlutterPlugin, OSNotificationPermissionObserver>
 
 @property (strong, nonatomic) FlutterMethodChannel *channel;
 + (instancetype)sharedInstance;

ios/Classes/OSFlutterNotifications.m

@@ -79,7 +79,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
 }
 
 - (void)permissionNative:(FlutterMethodCall *)call withResult:(FlutterResult)result {
-    OSNotificationPermission *permission = [OneSignal.Notifications permissionNative];
+    OSNotificationPermission permission = [OneSignal.Notifications permissionNative];
     result(@((int)permission));
 }
 
@@ -110,8 +110,8 @@ - (void)lifecycleInit:(FlutterMethodCall *)call withResult:(FlutterResult)result
     result(nil);
 }
 
-- (void)onOSPermissionChanged:(OSPermissionState*)state {
-    [self.channel invokeMethod:@"OneSignal#OSPermissionChanged" arguments:state.jsonRepresentation];
+- (void)onNotificationPermissionDidChange:(BOOL)permission {
+    [self.channel invokeMethod:@"OneSignal#onNotificationPermissionDidChange" arguments:@{@"permission" : @(permission)}];
 }
 
 #pragma mark Received in Foreground Notification 

lib/src/notifications.dart

@@ -100,7 +100,7 @@ class OneSignalNotifications {
     }
   }
 
-  /// The OSPermissionObserver.onOSPermissionChanged method will be fired on the passed-in object
+  /// The OSNotificationPermissionObserver.onNotificationPermissionDidChange method will be fired on the passed-in object
   /// when a notification permission setting changes. This happens when the user enables or disables
   /// notifications for your app from the system settings outside of your app.
   void addPermissionObserver(OneSignalPermissionObserver observer) {
@@ -131,17 +131,15 @@ class OneSignalNotifications {
         this._onNotificationWillShowInForegroundHandler != null) {
       this._onNotificationWillShowInForegroundHandler!(
           OSNotificationReceivedEvent(call.arguments.cast<String, dynamic>()));
-    } else if (call.method == 'OneSignal#OSPermissionChanged') {
-      this.onOSPermissionChangedHandler(
-          OSPermissionState(call.arguments.cast<String, dynamic>()));
+    } else if (call.method == 'OneSignal#onNotificationPermissionDidChange') {
+      this.onNotificationPermissionDidChange(call.arguments["permission"]);
     }
     return null;
   }
 
-  Future<void> onOSPermissionChangedHandler(OSPermissionState state) async {
-    _permission = state.permission;
+  void onNotificationPermissionDidChange(bool permission) {
     for (var observer in _observers) {
-      observer.onOSPermissionChanged(_permission);
+      observer.onNotificationPermissionDidChange(permission);
     }
   }
 
@@ -167,5 +165,5 @@ class OneSignalNotifications {
 }
 
 class OneSignalPermissionObserver {
-  void onOSPermissionChanged(bool state) {}
+  void onNotificationPermissionDidChange(bool permission) {}
 }