Skip to content

Commit 34b8ca1

Browse files
authored
Merge pull request #800 from OneSignal/fix_android_addtags_await
Fix Android User calls to always resolve
2 parents 6bfc79a + c9c586e commit 34b8ca1

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

android/src/main/java/com/onesignal/flutter/OneSignalUser.java

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,19 @@ else if (call.method.contentEquals("OneSignal#removeTags"))
5454

5555
private void setLanguage(MethodCall call, Result result) {
5656
String language = call.argument("language");
57-
if (language != null && language.length() == 0)
58-
language = null;
59-
60-
OneSignal.getUser().setLanguage(language);
57+
if (language != null && language.length() == 0) {
58+
language = null;
59+
}
60+
OneSignal.getUser().setLanguage(language);
61+
replySuccess(result, null);
6162
}
6263

6364
private void addAliases(MethodCall call, Result result) {
6465
// call.arguments is being casted to a Map<String, Object> so a try-catch with
6566
// a ClassCastException will be thrown
6667
try {
6768
OneSignal.getUser().addAliases((Map<String, String>) call.arguments);
69+
replySuccess(result, null);
6870
} catch(ClassCastException e) {
6971
replyError(result, "OneSignal", "addAliases failed with error: " + e.getMessage() + "\n" + e.getStackTrace(), null);
7072
}
@@ -75,6 +77,7 @@ private void removeAliases(MethodCall call, Result result) {
7577
// a ClassCastException will be thrown
7678
try {
7779
OneSignal.getUser().removeAliases((List<String>) call.arguments);
80+
replySuccess(result, null);
7881
} catch(ClassCastException e) {
7982
replyError(result, "OneSignal", "removeAliases failed with error: " + e.getMessage() + "\n" + e.getStackTrace(), null);
8083
}
@@ -83,27 +86,29 @@ private void removeAliases(MethodCall call, Result result) {
8386
private void addEmail(MethodCall call, Result result) {
8487
OneSignal.getUser().addEmail((String) call.arguments);
8588
replySuccess(result, null);
86-
}
89+
}
8790

88-
private void removeEmail(MethodCall call, Result result) {
91+
private void removeEmail(MethodCall call, Result result) {
8992
OneSignal.getUser().removeEmail((String) call.arguments);
9093
replySuccess(result, null);
91-
}
94+
}
9295

93-
private void addSms(MethodCall call, Result result) {
96+
private void addSms(MethodCall call, Result result) {
9497
OneSignal.getUser().addSms((String) call.arguments);
9598
replySuccess(result, null);
96-
}
99+
}
97100

98-
private void removeSms(MethodCall call, Result result) {
101+
private void removeSms(MethodCall call, Result result) {
99102
OneSignal.getUser().removeSms((String) call.arguments);
100103
replySuccess(result, null);
101-
}
102-
private void addTags(MethodCall call, Result result) {
104+
}
105+
106+
private void addTags(MethodCall call, Result result) {
103107
// call.arguments is being casted to a Map<String, Object> so a try-catch with
104108
// a ClassCastException will be thrown
105109
try {
106110
OneSignal.getUser().addTags((Map<String, String>) call.arguments);
111+
replySuccess(result, null);
107112
} catch(ClassCastException e) {
108113
replyError(result, "OneSignal", "addTags failed with error: " + e.getMessage() + "\n" + e.getStackTrace(), null);
109114
}
@@ -114,10 +119,9 @@ private void removeTags(MethodCall call, Result result) {
114119
// a ClassCastException will be thrown
115120
try {
116121
OneSignal.getUser().removeTags((List<String>) call.arguments);
122+
replySuccess(result, null);
117123
} catch(ClassCastException e) {
118124
replyError(result, "OneSignal", "deleteTags failed with error: " + e.getMessage() + "\n" + e.getStackTrace(), null);
119125
}
120126
}
121-
122-
123127
}

0 commit comments

Comments
 (0)