Skip to content

Commit 1e44f20

Browse files
committed
addTrigger(s) now only accepts String values
1 parent 481edd7 commit 1e44f20

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

android/src/main/java/com/onesignal/flutter/OneSignalInAppMessages.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ private void addTriggers(MethodCall call, Result result) {
5656
// call.arguments is being casted to a Map<String, Object> so a try-catch with
5757
// a ClassCastException will be thrown
5858
try {
59-
OneSignal.getInAppMessages().addTriggers((Map<String, Object>) call.arguments);
59+
OneSignal.getInAppMessages().addTriggers((Map<String, String>) call.arguments);
6060
replySuccess(result, null);
6161
} catch (ClassCastException e) {
6262
replyError(result, "OneSignal", "Add triggers failed with error: " + e.getMessage() + "\n" + e.getStackTrace(), null);

example/lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ class _MyAppState extends State<MyApp>
214214
/// Example addTriggers call for IAM
215215
/// This will add 2 triggers so if there are any IAM satisfying these, they
216216
/// will be shown to the user
217-
Map<String, Object> triggers = new Map<String, Object>();
217+
Map<String, String> triggers = new Map<String, String>();
218218
triggers["trigger_2"] = "two";
219219
triggers["trigger_3"] = "three";
220220
OneSignal.InAppMessages.addTriggers(triggers);

lib/src/inappmessages.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ class OneSignalInAppMessages {
2525

2626
/// Adds a single key, value trigger, which will trigger an in app message
2727
/// if one exists matching the specific trigger added
28-
Future<void> addTrigger(String key, Object value) async {
28+
Future<void> addTrigger(String key, String value) async {
2929
return await _channel.invokeMethod("OneSignal#addTrigger", {key: value});
3030
}
3131

3232
/// Adds one or more key, value triggers, which will trigger in app messages
3333
/// (one at a time) if any exist matching the specific triggers added
34-
Future<void> addTriggers(Map<String, Object> triggers) async {
34+
Future<void> addTriggers(Map<String, String> triggers) async {
3535
return await _channel.invokeMethod("OneSignal#addTriggers", triggers);
3636
}
3737

0 commit comments

Comments
 (0)