Review feedback

Author: fhboswell

MIGRATION_GUIDE.md

@@ -108,8 +108,6 @@ The current device’s push subscription can be retrieved via:
 
 To receive push notifications on the device, call the push subscription’s `optIn` method. If needed, this method will prompt the user for push notifications permission. 
 
-Note: For greater control over prompting for push notification permission, you may use the `OneSignal.Notifications.requestPermission` method detailed below in the API Reference.
-
 
 **Flutter**
 ```dart
@@ -223,12 +221,12 @@ The Push Subscription name space is accessible via `OneSignal.User.pushSubscript
 | `var optedIn = OneSignal.User.pushSubscription.optedIn`                                                                               | *Gets a boolean value indicating whether the current user is opted in to push notifications. This returns `true` when the app has notifications permission and `optedOut` is called. ***Note:*** Does not take into account the existence of the subscription ID and push token. This boolean may return `true` but push notifications may still not be received by the user.* |
 | `OneSignal.User.pushSubscription.optIn();`                                                                                              | *Call this method to receive push notifications on the device or to resume receiving of push notifications after calling `optOut`. If needed, this method will prompt the user for push notifications permission.*                                                                                                                                                                     |
 | `OneSignal.User.pushSubscription.optOut();`                                                                                             | *If at any point you want the user to stop receiving push notifications on the current device (regardless of system-level permission status), you can call this method to opt out.*                                                                                                                                                                                                              |
-| `wOneSignal.User.pushSubscription.addObserver();`<br><br>***See below for usage*** | *The `OSPushSubscriptionObserver.onOSPushSubscriptionChanged` method will be fired on the passed-in object when the push subscription changes. This method returns the current `OSPushSubscriptionState` at the time of adding this observer.*                                                                                                                                 |
+| `wOneSignal.User.pushSubscription.addObserver();`<br><br>***See below for usage*** | *The `OneSignalPushSubscriptionObserver.onOSPushSubscriptionChangedWithState` method will be fired on the passed-in object when the push subscription changes. This method returns the current `OSPushSubscriptionState` at the time of adding this observer.*                                                                                                                                 |
 | `OneSignal.User.pushSubscription.removeObserver();`<br><br>***See below for usage***                             | *Remove a push subscription observer that has been previously added.*                                                                                                                                                                                                                                                                                                                      |
 
 ### Push Subscription Observer
 
-Any object implementing the `OSPushSubscriptionObserver` protocol can be added as an observer. You can call `removeObserver` to remove any existing listeners.
+Any object implementing the `OneSignalPushSubscriptionObserver` protocol can be added as an observer. You can call `removeObserver` to remove any existing listeners.
 
 **Flutter**
 ```dart
@@ -259,7 +257,7 @@ The Notifications namespace is accessible via `OneSignal.Notifications` and prov
 | **Flutter**                                                         |                                                                                              **Description** |
 |---------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------|
 | `var permission = Notifications.permission`               | *Whether this app has push notification permission.*                                                                                                                                                                                                                                                                                                                                                                        |
-| `var canRequest = await OneSignal.Notifications.canRequestPermission();`  | *Whether attempting to request notification permission will show a prompt. Returns `true` if the device has not been prompted for push notification permission already.*                                                                                                                                                                                                                                                |
+| `var canRequest = await OneSignal.Notifications.canRequest();`  | *Whether attempting to request notification permission will show a prompt. Returns `true` if the device has not been prompted for push notification permission already.*                                                                                                                                                                                                                                                |
 | `OneSignal.Notifications.clearAll();`                                           | *Removes all OneSignal notifications.*|                                                                                                                                                           
 | `OneSignal.Notifications.removeNotification(int x);`                                                                                               | *(Android only) Cancels a single OneSignal notification based on its Android notification integer ID. Use instead of Android's [android.app.NotificationManager.cancel], otherwise the notification will be restored when your app is restarted.*|                                                                                                                                                                                                    
 | `OneSignal.Notifications.removeGroupedNotifications("GROUP_KEY");`                                                                                               | *(Android only) Cancels a group of OneSignal notifications with the provided group key. Grouping notifications is a OneSignal concept, there is no [android.app.NotificationManager] equivalent.*|                                                                                                                                                                                                                                                                                                                        

ios/Classes/OSFlutterNotifications.m

@@ -82,7 +82,6 @@ - (void)clearAll:(FlutterMethodCall *)call  withResult:(FlutterResult)result {
 }
 
 - (void)requestPermission:(FlutterMethodCall *)call withResult:(FlutterResult)result {
-     NSLog(@"henryhenryhenryrequestPermission");
     BOOL fallbackToSettings = [call.arguments[@"fallbackToSettings"] boolValue];
 
     [OneSignal.Notifications requestPermission:^(BOOL accepted) {

lib/src/notifications.dart

@@ -34,7 +34,11 @@ class OneSignalNotifications {
   /// Whether attempting to request notification permission will show a prompt.
   /// Returns true if the device has not been prompted for push notification permission already.
   Future<bool> canRequest() async {
-    return await _channel.invokeMethod("OneSignal#canRequest");
+    if (Platform.isIOS) {
+      return await _channel.invokeMethod("OneSignal#canRequest");
+    } else {
+      return false;
+    }
   }
 
   /// Removes a single notification.